Convert remaining fixture add-ons to in-test-generated XPIs

RESOLVED FIXED in Firefox 62

Status

()

enhancement
P3
normal
RESOLVED FIXED
Last year
Last year

People

(Reporter: kmag, Assigned: kmag)

Tracking

(Blocks 1 bug)

Trunk
mozilla62
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment)

Fixture add-ons make tests harder to understand, and particularly make it much harder to convert bootstrap.js add-on tests to use WebExtensions. We have the tools to generated these add-ons directly from test files. We should do so.
Priority: -- → P3
Comment on attachment 8981030 [details]
Bug 1464720: Remove remaining in-tree fixture add-ons.

https://reviewboard.mozilla.org/r/247146/#review257652

thanks

::: toolkit/mozapps/extensions/test/xpcshell/test_delay_update.js:37
(Diff revision 3)
> +    "install.rdf": {
> +      "id": "test_delay_update_complete@tests.mozilla.org",
> +      "version": "2.0",
> +      "name": "Test Delay Update Complete",
> +    },
> +    "bootstrap.js": "ChromeUtils.import(\"resource://gre/modules/Services.jsm\");\nChromeUtils.import(\"resource://gre/modules/AddonManager.jsm\");\n\nconst ADDON_ID = \"test_delay_update_complete@tests.mozilla.org\";\n\nfunction install(data, reason) {}\n\nfunction startup(data, reason) {}\n\nfunction shutdown(data, reason) {}\n"

this doesn't appear to do anything?
Attachment #8981030 - Flags: review?(aswan) → review+
Comment on attachment 8981030 [details]
Bug 1464720: Remove remaining in-tree fixture add-ons.

https://reviewboard.mozilla.org/r/247146/#review257652

> this doesn't appear to do anything?

Hm. Yeah. This was all done by a script that just copied the original contents of the XPIs. I fixed a bunch of cargo-culted bootstrap scripts that looked like this, but I guess I missed some.
https://hg.mozilla.org/mozilla-central/rev/323428ac575e
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.