1464720 - Convert remaining fixture add-ons to in-test-generated XPIs

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P3)

Description

[Kris Maglione [:kmag]]

Fixture add-ons make tests harder to understand, and particularly make it much harder to convert bootstrap.js add-on tests to use WebExtensions. We have the tools to generated these add-ons directly from test files. We should do so.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1464720: Remove remaining in-tree fixture add-ons.

Review commit: https://reviewboard.mozilla.org/r/247146/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247146/

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8981030 [details]
Bug 1464720: Remove remaining in-tree fixture add-ons.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247146/diff/1-2/

Comment 3

[Kris Maglione [:kmag]]

Comment on attachment 8981030 [details]
Bug 1464720: Remove remaining in-tree fixture add-ons.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247146/diff/2-3/

Comment 4

[Andrew Swan [:aswan]]

Comment on attachment 8981030 [details]
Bug 1464720: Remove remaining in-tree fixture add-ons.

https://reviewboard.mozilla.org/r/247146/#review257652

thanks

::: toolkit/mozapps/extensions/test/xpcshell/test_delay_update.js:37
(Diff revision 3)
> +    "install.rdf": {
> +      "id": "[e-mail]",
> +      "version": "2.0",
> +      "name": "Test Delay Update Complete",
> +    },
> +    "bootstrap.js": "ChromeUtils.import(\"resource://gre/modules/Services.jsm\");\nChromeUtils.import(\"resource://gre/modules/AddonManager.jsm\");\n\nconst ADDON_ID = \"[e-mail]\";\n\nfunction install(data, reason) {}\n\nfunction startup(data, reason) {}\n\nfunction shutdown(data, reason) {}\n"

this doesn't appear to do anything?

Comment 5

[Kris Maglione [:kmag]]

Comment on attachment 8981030 [details]
Bug 1464720: Remove remaining in-tree fixture add-ons.

https://reviewboard.mozilla.org/r/247146/#review257652

> this doesn't appear to do anything?

Hm. Yeah. This was all done by a script that just copied the original contents of the XPIs. I fixed a bunch of cargo-culted bootstrap scripts that looked like this, but I guess I missed some.

Comment 6

[Francesco Lodolo [:flod]]

Comment on attachment 8981030 [details]
Bug 1464720: Remove remaining in-tree fixture add-ons.

https://reviewboard.mozilla.org/r/247146/#review258006

Comment 7

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/323428ac575e652a511c9759ea1ceb9366748633
Bug 1464720: Remove remaining in-tree fixture add-ons. r=aswan r=flod

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/323428ac575e