Closed
Bug 1464779
Opened 7 years ago
Closed 7 years ago
Update google_play_button macro to accommodate use of adjust.com links
Categories
(www.mozilla.org :: Pages & Content, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: hectorz, Assigned: hectorz)
Details
Attachments
(1 file)
(In reply to Hector Zhao [:hectorz] from bug 1457024 comment #25)
>
> I somewhat assumed `alt_href` in `google_play_button` macro would only be
> used for apps other than Firefox for Android when I first created it in [1],
> maybe it's better to update the macro to accommodate the use of Adjust
> links, so that it correctly adds the `data-mozillaonline-link` attribute to
> a Google Play button for Fx mobile.
|
Assignee | |
Updated•7 years ago
|
Summary: Update google_play_button macro to accomendate use of adjust.com links → Update google_play_button macro to accommodate use of adjust.com links
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → bzhao
Status: NEW → ASSIGNED
|
||
Comment 1•7 years ago
|
||
|
||
Comment 2•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/bedrock
https://github.com/mozilla/bedrock/commit/7711296b303c3878196f07d8034cb633acc65ddf
Bug 1464779 - Update google_play_button macro to accommodate use of adjust.com links. (#5748)
|
|
Assignee | |
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•