Closed Bug 1464795 Opened 6 years ago Closed 6 years ago

Crash in mozilla::ipc::MessageChannel::AssertWorkerThread | mozilla::dom::PContentParent::SendDataStorageRemove | Firefox crashes when trr is enabled and proxy is configured

Categories

(Core :: Networking: DNS, defect, P2)

60 Branch
defect

Tracking

()

RESOLVED DUPLICATE of bug 1450630

People

(Reporter: makruiten, Assigned: bagder)

Details

(Keywords: crash, Whiteboard: [necko-triaged])

Crash Data

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180523133746

Steps to reproduce:

1. network.trr.bootstrapAddress : 1.1.1.1
2. network.trr.mode: 2 or 3
3. network.trr.uri: https://cloudflare-dns.com/dns-query
4. Automatic proxy configuration URL: file:///home/martijn/.socks.pac
5. Proxy DNS when using SOCKS v5: disabled

PAC file contents:
function FindProxyForURL(url, host)
{
  if (isInNet(host, "192.168.136.0", "255.255.248.0")) {
    return "SOCKS localhost:5000";
  }
  return "DIRECT";
}

This happens regardless of whether I visit a site in the above subnet or not.


Actual results:

Firefox crashes (sometimes after a few minutes) and can only be recovered by starting in safe mode and disabling trr (network.trr.mode: 0). Otherwise it gets stuck in an endless crash loop.


Expected results:

All DNS queries should bypass the proxy (which I didn't test) and Firefox should redirect any traffic for the private subnet through the proxy. Firefox should not crash with this settings enabled.
I currently use FoxyProxy as a workaround and so far that seems to be a stable solution.
Please submit a crash report. Afterwards, enter about:crashes into the address bar and post the crash report ID into a comment here.
https://developer.mozilla.org/docs/Mozilla/How_to_get_a_stacktrace_for_a_bug_report
Severity: normal → critical
Component: Untriaged → Networking: DNS
Flags: needinfo?(makruiten)
Keywords: crash
Product: Firefox → Core
I've submitted three of them, as I only realized after the last one that the box was still ticked.

a9e04245-db2a-4701-add2-cf9e30180523
8aeb89d8-209c-45fd-b0fe-7ea000180523
0c461fa7-eb05-4aad-a083-322dc0180523
Flags: needinfo?(makruiten)
Thank you.

bp-a9e04245-db2a-4701-add2-cf9e30180523
bp-8aeb89d8-209c-45fd-b0fe-7ea000180523
bp-0c461fa7-eb05-4aad-a083-322dc0180523
Crash Signature: [@ mozilla::ipc::MessageChannel::AssertWorkerThread | mozilla::dom::PContentParent::SendDataStorageRemove ]
Summary: Firefox crashes when trr is enabled and proxy is configured → Crash in mozilla::ipc::MessageChannel::AssertWorkerThread | mozilla::dom::PContentParent::SendDataStorageRemove | Firefox crashes when trr is enabled and proxy is configured
Assignee: nobody → daniel
Priority: -- → P2
Whiteboard: [necko-triaged]
Oh, this is Firefox *60* with TRR. I would advice against that. We've fixed numerous TRR related bugs in 61 and even 62 that have not been backported. There's no intention to fix TRR in 60.

If you want to stick to 60, don't enable TRR just yet! Sorry for this inconvenience. We started landing TRR changes in version 60 and it has gotten better and better over time. This particular crash was fixed for real in bug 1450630.
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
(In reply to Daniel Stenberg [:bagder] from comment #5)
> This particular crash was fixed for real in bug 1450630.

Then it's quite peculiar to mark this Wontfix rather than a duplicate.
I was thinking won't-fix-this-bug-in-this-version, but yeah maybe a plain duplicate is more appropriate. Fixing, thanks!
Resolution: WONTFIX → DUPLICATE
You need to log in before you can comment on or make changes to this bug.