1464813 - eDontReparentFrames is unnecessary.

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, enhancement)

Description

[Emilio Cobos Álvarez [:emilio]]

I was trying to look into ways of simplifying our first-line stuff, since it's really bug-ridden (at least on the style side of it).

I noticed that one part of the "lazily set parent frame" optimization isn't really used at all: We only set lazilySetParentPointer on the first reflow, then only call DrainSelfOverflowListInternal with eDontReparentFrames on non-first reflows. Here's a try run that asserts that we don't pass the flag on our test-suite:

  https://treeherder.mozilla.org/#/jobs?repo=try&revision=583161894ad4e6518699d6fedd3f119c3c8c0597

So I think we can safely remove it.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1464813: Remove eDontReparentFrames, since it's not used.

We only set lazilySetParentPointer on the first reflow, then only call
DrainSelfOverflowListInternal on non-first reflows.

Review commit: https://reviewboard.mozilla.org/r/247236/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247236/

Comment 2

[Mats Palmgren (inactive)]

Comment on attachment 8981139 [details]
Bug 1464813: Remove eDontReparentFrames, since it's not used.

https://reviewboard.mozilla.org/r/247236/#review253340

IIRC, we preserved this option since we were planning to extend lazy reparenting to more cases at that time. But that never happened (probably for good reason).
Thanks for cleaning this up!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1057c5c2542
Remove eDontReparentFrames, since it's not used. r=mats

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/a1057c5c2542