1464909 - Sprinkle more profiler category annotations over the codebase

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement)

Description

[Markus Stange [:mstange]]

These categories will soon be used to add some color to the data that's displayed in perf.html. The patches in this bug are based on bug 1462784.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1464909 - Add a dynamic profiler label to nsContentSink::StartLayout that includes the document URL.

Review commit: https://reviewboard.mozilla.org/r/247338/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247338/

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1464909 - Add GRAPHICS category annotations to async-paint-related methods.

Review commit: https://reviewboard.mozilla.org/r/247340/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247340/

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1464909 - Add the "GC / CC" category to AsyncFreeSnowWhite::Run.

Review commit: https://reviewboard.mozilla.org/r/247342/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247342/

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1464909 - Add the "GC / CC" category to IncrementalFinalizeRunnable::Run.

Review commit: https://reviewboard.mozilla.org/r/247344/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247344/

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8981256 [details]
Bug 1464909 - Add the "GC / CC" category to AsyncFreeSnowWhite::Run.

https://reviewboard.mozilla.org/r/247342/#review253390

::: js/xpconnect/src/XPCJSRuntime.cpp:126
(Diff revision 1)
>  {
>  public:
>    NS_IMETHOD Run() override
>    {
> +      AUTO_PROFILER_LABEL("AsyncFreeSnowWhite::Run", GCCC);
> +      

Some weird space here? Or what is MozReview complaining

::: layout/base/nsLayoutUtils.cpp:3646
(Diff revision 1)
>    nsRect visibleRect = visibleRegion.GetBounds();
>    PartialUpdateResult updateState = PartialUpdateResult::Failed;
>  
>    {
>      AUTO_PROFILER_LABEL("nsLayoutUtils::PaintFrame:BuildDisplayList",
> -                        LAYOUT);
> +                        GRAPHICS);

Unrelated change, but should be fine, I guess

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8981257 [details]
Bug 1464909 - Add the "GC / CC" category to IncrementalFinalizeRunnable::Run.

https://reviewboard.mozilla.org/r/247344/#review253392

::: xpcom/base/CycleCollectedJSRuntime.cpp:1409
(Diff revision 1)
>  
>  NS_IMETHODIMP
>  IncrementalFinalizeRunnable::Run()
>  {
> +  AUTO_PROFILER_LABEL("IncrementalFinalizeRunnable::Run", GCCC);
> +      

Again some weird space?

Comment 7

[Ryan Hunt [:rhunt]]

Comment on attachment 8981255 [details]
Bug 1464909 - Add GRAPHICS category annotations to async-paint-related methods.

https://reviewboard.mozilla.org/r/247340/#review253632

::: gfx/layers/PaintThread.cpp:418
(Diff revision 1)
>  void
>  PaintThread::AsyncPaintTiledContents(CompositorBridgeChild* aBridge,
>                                       CapturedTiledPaintState* aState)
>  {
> +  AUTO_PROFILER_LABEL("PaintThread::AsyncPaintTiledContents", GRAPHICS);
> +  

nit: whitespace

::: gfx/layers/client/ClientLayerManager.cpp:497
(Diff revision 1)
>  
>  void
>  ClientLayerManager::FlushAsyncPaints()
>  {
> +  AUTO_PROFILER_LABEL("ClientLayerManager::FlushAsyncPaints", GRAPHICS);
> +  

ditto

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8981254 [details]
Bug 1464909 - Add a dynamic profiler label to nsContentSink::StartLayout that includes the document URL.

https://reviewboard.mozilla.org/r/247338/#review253748

Comment 9

[Markus Stange [:mstange]]

Comment on attachment 8981254 [details]
Bug 1464909 - Add a dynamic profiler label to nsContentSink::StartLayout that includes the document URL.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247338/diff/1-2/

Comment 10

[Markus Stange [:mstange]]

Comment on attachment 8981255 [details]
Bug 1464909 - Add GRAPHICS category annotations to async-paint-related methods.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247340/diff/1-2/

Comment 11

[Markus Stange [:mstange]]

Comment on attachment 8981256 [details]
Bug 1464909 - Add the "GC / CC" category to AsyncFreeSnowWhite::Run.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247342/diff/1-2/

Comment 12

[Markus Stange [:mstange]]

Comment on attachment 8981257 [details]
Bug 1464909 - Add the "GC / CC" category to IncrementalFinalizeRunnable::Run.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247344/diff/1-2/

Comment 13

[Markus Stange [:mstange]]

Comment on attachment 8981254 [details]
Bug 1464909 - Add a dynamic profiler label to nsContentSink::StartLayout that includes the document URL.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247338/diff/2-3/

Comment 14

[Markus Stange [:mstange]]

Comment on attachment 8981255 [details]
Bug 1464909 - Add GRAPHICS category annotations to async-paint-related methods.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247340/diff/2-3/

Comment 15

[Markus Stange [:mstange]]

Comment on attachment 8981256 [details]
Bug 1464909 - Add the "GC / CC" category to AsyncFreeSnowWhite::Run.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247342/diff/2-3/

Comment 16

[Markus Stange [:mstange]]

Comment on attachment 8981257 [details]
Bug 1464909 - Add the "GC / CC" category to IncrementalFinalizeRunnable::Run.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247344/diff/2-3/

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11670c51f572
Add a dynamic profiler label to nsContentSink::StartLayout that includes the document URL. r=bz
https://hg.mozilla.org/integration/autoland/rev/c1e1d74ad27e
Add GRAPHICS category annotations to async-paint-related methods. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/562aeeced55b
Add the "GC / CC" category to AsyncFreeSnowWhite::Run. r=smaug
https://hg.mozilla.org/integration/autoland/rev/119c2055e002
Add the "GC / CC" category to IncrementalFinalizeRunnable::Run. r=smaug

Comment 18

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc7e36fffaa7
Backed out 4 changesets for failures in devtools/client/performance/test/unit/test_tree-model-08.js r=mstange on a CLOSED TREE

Comment 19

[Markus Stange [:mstange]]

Comment on attachment 8981254 [details]
Bug 1464909 - Add a dynamic profiler label to nsContentSink::StartLayout that includes the document URL.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247338/diff/3-4/

Comment 20

[Markus Stange [:mstange]]

Comment on attachment 8981255 [details]
Bug 1464909 - Add GRAPHICS category annotations to async-paint-related methods.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247340/diff/3-4/

Comment 21

[Markus Stange [:mstange]]

Comment on attachment 8981256 [details]
Bug 1464909 - Add the "GC / CC" category to AsyncFreeSnowWhite::Run.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247342/diff/3-4/

Comment 22

[Markus Stange [:mstange]]

Comment on attachment 8981257 [details]
Bug 1464909 - Add the "GC / CC" category to IncrementalFinalizeRunnable::Run.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247344/diff/3-4/

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1af5c07a3780
Add a dynamic profiler label to nsContentSink::StartLayout that includes the document URL. r=bz
https://hg.mozilla.org/integration/autoland/rev/855778d54757
Add GRAPHICS category annotations to async-paint-related methods. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/c9cab9f9461e
Add the "GC / CC" category to AsyncFreeSnowWhite::Run. r=smaug
https://hg.mozilla.org/integration/autoland/rev/882c05a09c56
Add the "GC / CC" category to IncrementalFinalizeRunnable::Run. r=smaug

Comment 24

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/1af5c07a3780
https://hg.mozilla.org/mozilla-central/rev/855778d54757
https://hg.mozilla.org/mozilla-central/rev/c9cab9f9461e
https://hg.mozilla.org/mozilla-central/rev/882c05a09c56