Sprinkle more profiler category annotations over the codebase

RESOLVED FIXED in Firefox 62

Status

()

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: mstange, Assigned: mstange)

Tracking

Trunk
mozilla62
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(4 attachments)

Assignee

Description

Last year
These categories will soon be used to add some color to the data that's displayed in perf.html. The patches in this bug are based on bug 1462784.
Comment hidden (mozreview-request)
Assignee

Updated

Last year
Attachment #8981254 - Flags: review?(bzbarsky)

Comment 5

Last year
mozreview-review
Comment on attachment 8981256 [details]
Bug 1464909 - Add the "GC / CC" category to AsyncFreeSnowWhite::Run.

https://reviewboard.mozilla.org/r/247342/#review253390

::: js/xpconnect/src/XPCJSRuntime.cpp:126
(Diff revision 1)
>  {
>  public:
>    NS_IMETHOD Run() override
>    {
> +      AUTO_PROFILER_LABEL("AsyncFreeSnowWhite::Run", GCCC);
> +      

Some weird space here? Or what is MozReview complaining

::: layout/base/nsLayoutUtils.cpp:3646
(Diff revision 1)
>    nsRect visibleRect = visibleRegion.GetBounds();
>    PartialUpdateResult updateState = PartialUpdateResult::Failed;
>  
>    {
>      AUTO_PROFILER_LABEL("nsLayoutUtils::PaintFrame:BuildDisplayList",
> -                        LAYOUT);
> +                        GRAPHICS);

Unrelated change, but should be fine, I guess
Attachment #8981256 - Flags: review?(bugs) → review+

Comment 6

Last year
mozreview-review
Comment on attachment 8981257 [details]
Bug 1464909 - Add the "GC / CC" category to IncrementalFinalizeRunnable::Run.

https://reviewboard.mozilla.org/r/247344/#review253392

::: xpcom/base/CycleCollectedJSRuntime.cpp:1409
(Diff revision 1)
>  
>  NS_IMETHODIMP
>  IncrementalFinalizeRunnable::Run()
>  {
> +  AUTO_PROFILER_LABEL("IncrementalFinalizeRunnable::Run", GCCC);
> +      

Again some weird space?
Attachment #8981257 - Flags: review?(bugs) → review+

Comment 7

Last year
mozreview-review
Comment on attachment 8981255 [details]
Bug 1464909 - Add GRAPHICS category annotations to async-paint-related methods.

https://reviewboard.mozilla.org/r/247340/#review253632

::: gfx/layers/PaintThread.cpp:418
(Diff revision 1)
>  void
>  PaintThread::AsyncPaintTiledContents(CompositorBridgeChild* aBridge,
>                                       CapturedTiledPaintState* aState)
>  {
> +  AUTO_PROFILER_LABEL("PaintThread::AsyncPaintTiledContents", GRAPHICS);
> +  

nit: whitespace

::: gfx/layers/client/ClientLayerManager.cpp:497
(Diff revision 1)
>  
>  void
>  ClientLayerManager::FlushAsyncPaints()
>  {
> +  AUTO_PROFILER_LABEL("ClientLayerManager::FlushAsyncPaints", GRAPHICS);
> +  

ditto
Attachment #8981255 - Flags: review?(rhunt) → review+

Comment 8

Last year
mozreview-review
Comment on attachment 8981254 [details]
Bug 1464909 - Add a dynamic profiler label to nsContentSink::StartLayout that includes the document URL.

https://reviewboard.mozilla.org/r/247338/#review253748
Attachment #8981254 - Flags: review?(bzbarsky) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 17

Last year
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/11670c51f572
Add a dynamic profiler label to nsContentSink::StartLayout that includes the document URL. r=bz
https://hg.mozilla.org/integration/autoland/rev/c1e1d74ad27e
Add GRAPHICS category annotations to async-paint-related methods. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/562aeeced55b
Add the "GC / CC" category to AsyncFreeSnowWhite::Run. r=smaug
https://hg.mozilla.org/integration/autoland/rev/119c2055e002
Add the "GC / CC" category to IncrementalFinalizeRunnable::Run. r=smaug

Comment 18

Last year
Backout by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bc7e36fffaa7
Backed out 4 changesets for failures in devtools/client/performance/test/unit/test_tree-model-08.js r=mstange on a CLOSED TREE
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 23

Last year
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/1af5c07a3780
Add a dynamic profiler label to nsContentSink::StartLayout that includes the document URL. r=bz
https://hg.mozilla.org/integration/autoland/rev/855778d54757
Add GRAPHICS category annotations to async-paint-related methods. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/c9cab9f9461e
Add the "GC / CC" category to AsyncFreeSnowWhite::Run. r=smaug
https://hg.mozilla.org/integration/autoland/rev/882c05a09c56
Add the "GC / CC" category to IncrementalFinalizeRunnable::Run. r=smaug
You need to log in before you can comment on or make changes to this bug.