Closed
Bug 1464954
Opened 4 years ago
Closed 4 years ago
|mach build binaries| no longer prints information about what directories it's building
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox-esr52 unaffected, firefox-esr60 unaffected, firefox60 unaffected, firefox61 unaffected, firefox62 fixed)
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox-esr60 | --- | unaffected |
firefox60 | --- | unaffected |
firefox61 | --- | unaffected |
firefox62 | --- | fixed |
People
(Reporter: botond, Assigned: chmanchester)
References
Details
(Keywords: in-triage, regression)
Attachments
(2 files, 1 obsolete file)
STR: 1. Starting from an up-to-date build, make a change to a C++ source or header file. 2. Run |mach build binaries| Expected results: The build output contains some indication of which directories are being rebuilt, like it does when you run |mach build|. Actual results: The build output contains no such indication. If you've e.g. touched a widely included header file, this means the build will produce _no_ output after the initial boilerplate until the linking phase, making it seem like your build is stuck. To illustrate, please see the attached output, when I touch a header file and run |mach build binaries|, and then touch the header file again and run |mach build|. The output from the |mach build| invocation contains the following lines: 0:01.37 gfx/layers/apz/test/gtest 0:01.58 gfx/layers indicating the directories being rebuilt, while the output from |mach build binaries| contains no such lines. This is a recent regression.
Reporter | ||
Comment 1•4 years ago
|
||
Forgot to include a line; fixed now.
Attachment #8981297 -
Attachment is obsolete: true
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → cmanchester
Assignee | ||
Comment 2•4 years ago
|
||
The issue here is that ./mach build will set "NO_BUILDSTATUS_MESSAGES", which defeats the fix as implemented in bug 1449965.
Assignee | ||
Comment 3•4 years ago
|
||
I think it's safe to print build status messages if we're building in the topsrcdir, I'll post a patch that does that.
Comment hidden (mozreview-request) |
Comment 5•4 years ago
|
||
mozreview-review |
Comment on attachment 8981657 [details] Bug 1464954 - Call TIERS when invoking the build with individual tier names. https://reviewboard.mozilla.org/r/247772/#review253810
Attachment #8981657 -
Flags: review+
Updated•4 years ago
|
Attachment #8981657 -
Flags: review?(core-build-config-reviews)
Pushed by gszorc@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1bbb18b5af97 Print buildstatus messages when building in the top source directory. r=gps
Comment 7•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1bbb18b5af97
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Updated•4 years ago
|
status-firefox60:
--- → unaffected
status-firefox61:
--- → unaffected
status-firefox-esr52:
--- → unaffected
status-firefox-esr60:
--- → unaffected
Comment 8•4 years ago
|
||
This broke running "mach build foo", where foo is a tier.
Flags: needinfo?(cmanchester)
Assignee | ||
Updated•4 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment hidden (mozreview-request) |
Comment 11•4 years ago
|
||
mozreview-review |
Comment on attachment 8981657 [details] Bug 1464954 - Call TIERS when invoking the build with individual tier names. https://reviewboard.mozilla.org/r/247772/#review255560
Attachment #8981657 -
Flags: review+
Updated•4 years ago
|
Attachment #8981657 -
Flags: review?(core-build-config-reviews)
Comment 12•4 years ago
|
||
Pushed by cmanchester@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/29081ef4774c Call TIERS when invoking the build with individual tier names. r=gps
Comment 13•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/29081ef4774c
Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
Resolution: --- → FIXED
Updated•4 years ago
|
Keywords: in-triage,
regression
Version: Version 3 → 3 Branch
Updated•3 years ago
|
Keywords: in-triage,
regression
You need to log in
before you can comment on or make changes to this bug.
Description
•