Closed Bug 1464954 Opened 4 years ago Closed 4 years ago

|mach build binaries| no longer prints information about what directories it's building

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Version:
3 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox-esr52 unaffected, firefox-esr60 unaffected, firefox60 unaffected, firefox61 unaffected, firefox62 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox60 --- unaffected
firefox61 --- unaffected
firefox62 --- fixed

People

(Reporter: botond, Assigned: chmanchester)

References

Details

(Keywords: in-triage, regression)

Attachments

(2 files, 1 obsolete file)

Output from |mach build binaries| compared to |mach build|
3.36 KB, text/plain
Details
Bug 1464954 - Call TIERS when invoking the build with individual tier names.
59 bytes, text/x-review-board-request
gps
: review+
Details 
STR:

  1. Starting from an up-to-date build, make a change
     to a C++ source or header file.
  2. Run |mach build binaries|

Expected results:

  The build output contains some indication of which
  directories are being rebuilt, like it does when
  you run |mach build|.

Actual results:

  The build output contains no such indication.

  If you've e.g. touched a widely included header
  file, this means the build will produce _no_
  output after the initial boilerplate until the 
  linking phase, making it seem like your build
  is stuck.

To illustrate, please see the attached output, when I touch a header file and run |mach build binaries|, and then touch the header file again and run |mach build|.

The output from the |mach build| invocation contains the following lines:

 0:01.37 gfx/layers/apz/test/gtest
 0:01.58 gfx/layers

indicating the directories being rebuilt, while the output from |mach build binaries| contains no such lines.

This is a recent regression.
Forgot to include a line; fixed now.
Attachment #8981297 - Attachment is obsolete: true
Keywords: in-triage
Assignee: nobody → cmanchester
The issue here is that ./mach build will set "NO_BUILDSTATUS_MESSAGES", which defeats the fix as implemented in bug 1449965.
I think it's safe to print build status messages if we're building in the topsrcdir, I'll post a patch that does that.
Comment on attachment 8981657 [details]
Bug 1464954 - Call TIERS when invoking the build with individual tier names.

https://reviewboard.mozilla.org/r/247772/#review253810
Attachment #8981657 - Flags: review+
Attachment #8981657 - Flags: review?(core-build-config-reviews)
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1bbb18b5af97
Print buildstatus messages when building in the top source directory. r=gps
https://hg.mozilla.org/mozilla-central/rev/1bbb18b5af97
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
This broke running "mach build foo", where foo is a tier.
Flags: needinfo?(cmanchester)
Patch coming up.
Flags: needinfo?(cmanchester)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8981657 [details]
Bug 1464954 - Call TIERS when invoking the build with individual tier names.

https://reviewboard.mozilla.org/r/247772/#review255560
Attachment #8981657 - Flags: review+
Attachment #8981657 - Flags: review?(core-build-config-reviews)
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/29081ef4774c
Call TIERS when invoking the build with individual tier names. r=gps
See Also: → 1465597
https://hg.mozilla.org/mozilla-central/rev/29081ef4774c
Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
Resolution: --- → FIXED
Keywords: in-triage, regression
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.