Open Bug 1464989 Opened 2 years ago Updated 2 years ago

Marionette has to report startup crashes instead of failing with "Failure during harness execution"

Categories

(Testing :: Marionette, enhancement, P3)

enhancement

Tracking

(Not tracked)

People

(Reporter: whimboo, Unassigned)

References

(Depends on 1 open bug)

Details

Yesterday we had a busted commit for Windows builds:

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=39607a36ad6b04083f56fe0a10861cd486a1d399&selectedJob=180540897&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=running&filter-resultStatus=pending&filter-resultStatus=runnable

Mochitests reported the following for the first start of Firefox where Marionette is active:

> PROCESS-CRASH | automation.py | application crashed [@ PLDHashTable::Search(void const *)]

Instead Marionette and FxUI tests reported:

> Failure during harness execution

This is suboptimal because it doesn't let us directly see the underlying problem, and as such failures are getting wrongly starred for bug 1407390.
`raise_for_port` actually checks the process status but due to bug 1433905 it's not correct and as such the loop doesn't exit early but with a socket timeout error:

https://dxr.mozilla.org/mozilla-central/rev/a466172aed4bc2afc21169b749b8068a4b98c93f/testing/marionette/client/marionette_driver/marionette.py#696-697

Once bug 1433905 is fixed we would have to check again if we actually make use of mozcrash under such a condition. The following debug builds would help which seem to crash a lot during startup:

win32: https://queue.taskcluster.net/v1/task/a4A8GOskSGqogcIurk99HQ/runs/0/artifacts/public/build/target.zip
win64: https://queue.taskcluster.net/v1/task/CbcpTQn2TROeoNvex-1ixA/runs/0/artifacts/public/build/target.zip
Depends on: 1433905
Before we can continue here we have to make sure to be able to track and follow detached processes. So bug 1434878 needs to be finished off first.
Depends on: 1434878
You need to log in before you can comment on or make changes to this bug.