libgfx_gtk.so needs to link with X libraries on gtk2

RESOLVED FIXED

Status

RESOLVED FIXED
17 years ago
14 years ago

People

(Reporter: bryner, Assigned: blizzard)

Tracking

Trunk
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

17 years ago
'pkg-config --libs gtk-2.0' does not output the X11 libraries, so we end up with
unresolved symbols for any X functions that we call directly.  These end up
being harmless at runtime since libX is already loaded with symbols globally
visible.   I'd suggest we link with XLIBS in all cases, since we directly
reference functions in libX.
(Reporter)

Comment 1

17 years ago
Created attachment 84808 [details] [diff] [review]
suggested fix
(Reporter)

Comment 2

17 years ago
Actually, it might be better to move them before MOZ_GTK_LDFLAGS.

Comment 3

15 years ago
Created attachment 148703 [details] [diff] [review]
Patch v1

Updated patch to latest trunk.
Attachment #84808 - Attachment is obsolete: true

Comment 4

15 years ago
Comment on attachment 148703 [details] [diff] [review]
Patch v1

This is needed to support building GTK2 builds on AIX without xprint.
Attachment #148703 - Flags: superreview?(blizzard)
Attachment #148703 - Flags: review?(bryner)
(Reporter)

Updated

15 years ago
Attachment #148703 - Flags: review?(bryner) → review+
(Assignee)

Updated

15 years ago
Attachment #148703 - Flags: superreview?(blizzard) → superreview+

Comment 5

15 years ago
Comment on attachment 148703 [details] [diff] [review]
Patch v1

Requesting approval for an AIX build fix when building without xprint.
Attachment #148703 - Flags: approval1.8a1?

Comment 6

15 years ago
Comment on attachment 148703 [details] [diff] [review]
Patch v1

a=asa (on behalf of drivers) for checkin to 1.8a
Attachment #148703 - Flags: approval1.8a1? → approval1.8a1+

Comment 7

15 years ago
Fixed.

Checking in Makefile.in;
/cvsroot/mozilla/gfx/src/gtk/Makefile.in,v  <--  Makefile.in
new revision: 1.111; previous revision: 1.110
done
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.