Closed
Bug 146500
Opened 22 years ago
Closed 20 years ago
libgfx_gtk.so needs to link with X libraries on gtk2
Categories
(SeaMonkey :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bryner, Assigned: blizzard)
References
Details
Attachments
(1 file, 1 obsolete file)
630 bytes,
patch
|
bryner
:
review+
blizzard
:
superreview+
asa
:
approval1.8a1+
|
Details | Diff | Splinter Review |
'pkg-config --libs gtk-2.0' does not output the X11 libraries, so we end up with unresolved symbols for any X functions that we call directly. These end up being harmless at runtime since libX is already loaded with symbols globally visible. I'd suggest we link with XLIBS in all cases, since we directly reference functions in libX.
Reporter | ||
Comment 1•22 years ago
|
||
Reporter | ||
Comment 2•22 years ago
|
||
Actually, it might be better to move them before MOZ_GTK_LDFLAGS.
Comment 3•20 years ago
|
||
Updated patch to latest trunk.
Attachment #84808 -
Attachment is obsolete: true
Comment 4•20 years ago
|
||
Comment on attachment 148703 [details] [diff] [review] Patch v1 This is needed to support building GTK2 builds on AIX without xprint.
Attachment #148703 -
Flags: superreview?(blizzard)
Attachment #148703 -
Flags: review?(bryner)
Reporter | ||
Updated•20 years ago
|
Attachment #148703 -
Flags: review?(bryner) → review+
Assignee | ||
Updated•20 years ago
|
Attachment #148703 -
Flags: superreview?(blizzard) → superreview+
Comment 5•20 years ago
|
||
Comment on attachment 148703 [details] [diff] [review] Patch v1 Requesting approval for an AIX build fix when building without xprint.
Attachment #148703 -
Flags: approval1.8a1?
Comment 6•20 years ago
|
||
Comment on attachment 148703 [details] [diff] [review] Patch v1 a=asa (on behalf of drivers) for checkin to 1.8a
Attachment #148703 -
Flags: approval1.8a1? → approval1.8a1+
Comment 7•20 years ago
|
||
Fixed. Checking in Makefile.in; /cvsroot/mozilla/gfx/src/gtk/Makefile.in,v <-- Makefile.in new revision: 1.111; previous revision: 1.110 done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•