146500 - libgfx_gtk.so needs to link with X libraries on gtk2

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Brian Ryner (not reading)]

'pkg-config --libs gtk-2.0' does not output the X11 libraries, so we end up with
unresolved symbols for any X functions that we call directly.  These end up
being harmless at runtime since libX is already loaded with symbols globally
visible.   I'd suggest we link with XLIBS in all cases, since we directly
reference functions in libX.

Comment 1

[Brian Ryner (not reading)]

Attachment: suggested fix

Comment 2

[Brian Ryner (not reading)]

Actually, it might be better to move them before MOZ_GTK_LDFLAGS.

Comment 3

[Philip K. Warren]

Attachment: Patch v1

Updated patch to latest trunk.

Comment 4

[Philip K. Warren]

Comment on attachment 148703 [details] [diff] [review]
Patch v1

This is needed to support building GTK2 builds on AIX without xprint.

Comment 5

[Philip K. Warren]

Comment on attachment 148703 [details] [diff] [review]
Patch v1

Requesting approval for an AIX build fix when building without xprint.

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 148703 [details] [diff] [review]
Patch v1

a=asa (on behalf of drivers) for checkin to 1.8a

Comment 7

[Philip K. Warren]

Fixed.

Checking in Makefile.in;
/cvsroot/mozilla/gfx/src/gtk/Makefile.in,v  <--  Makefile.in
new revision: 1.111; previous revision: 1.110
done