1465020 - Font editor shows empty values

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Martin Balfanz [:mbalfanz]]

Attachment: empty-values.mp4

On some fonts, the font editor shows empty values / input fields by default.

STR:
1. go to v-fonts.com
2. look for the font "Buffalo Gals"
3. inspect the fonts and check the font editor

Expected result:
- all fields should be pre-populated with the applied values

Actual result:
- some fields have values, some don't, even though everything is set in the computed view

The attached video shows two examples.

Comment 1

[Razvan Caliman [:rcaliman]]

This happens because the custom axes include intentional whitespace, "CK  ", "HR  ", "HV  " (tags must be 4 characters long) that gets trimmed when parsing the axis tag names.

See: https://searchfox.org/mozilla-central/source/devtools/client/inspector/fonts/reducers/font-editor.js#83

The parse method should not trim whitespace from tag names.

Comment 2

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1465020 - Do not trim whitespace from variable font axis tag names.

Review commit: https://reviewboard.mozilla.org/r/249286/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/249286/

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8983449 [details]
Bug 1465020 - Do not trim whitespace from variable font axis tag names.

https://reviewboard.mozilla.org/r/249286/#review255488

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74fded5d5a6b
Do not trim whitespace from variable font axis tag names. r=gl

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/74fded5d5a6b