1465025 - (MAC) Animation properties panel length issue

Status: RESOLVED WORKSFORME

(DevTools :: Inspector: Animations, defect, P3)

Description

[Adrian Florinescu [:aflorinescu]]

[Environment:]
Osx 10.12
62.0a1 2018-05-28

Not reproducible on Ubuntu (16.04) or Windows (10)

[Steps:]
1. Open https://rawgit.com/dadaa/3b73f847427025b51ba1ab7333013d0c/raw/77f3f0bb884875a179c3407f73bf8a8dd54751c9/doc_custom_playback_rate.html
2. Select a <div>, let the animation run 80% and observe the seeker progress for both animation bar and script animation properties.

[Actual Result:]
Note also the difference in size between the animation panel and script animation properties (see Linux and Mac comparison here: https://imgur.com/a/9fxPjrv)

[Expected Result:]
The expected result would be that the Script animation properties panel looks the same across all 3 platforms: win/mac/linux

Comment 1

[Adrian Florinescu [:aflorinescu]]

Additional note:
Although the progress line for the animation bar and script animation seem out of sync on OSX, I would guess the actual progress is correct, just the display seems out of sync because the panels are not aligned.

Comment 2

[Brian Birtles (:birtles, Feb 26~ parental leave)]

(In reply to Adrian Florinescu [:AdrianSV] from comment #1)
> Additional note:
> Although the progress line for the animation bar and script animation seem
> out of sync on OSX, I would guess the actual progress is correct, just the
> display seems out of sync because the panels are not aligned.

The progress bars are not expected to be in sync between those panels. It's just that for many simple animations they happen to be similar.

Comment 3

[Adrian Florinescu [:aflorinescu]]

(In reply to Brian Birtles (:birtles) from comment #2)
> The progress bars are not expected to be in sync between those panels. It's
> just that for many simple animations they happen to be similar.
I agree with that, but the bug here is that for the same animation, there is a length difference on Script Animation properties on MAC vs Linux/Windows.

Comment 4

[Brian Birtles (:birtles, Feb 26~ parental leave)]

I see the length difference in Linux too. It's only Windows that doesn't seem to have it.

Comment 5

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Inspecting the panel on Linux the space seems to be taken up by a <scrollbar> element. Daisuke and I looked into it and it seems to be because we have min-height: 100% and overflow-y: auto on that bottom panel meaning the scrollbar is always present (and on Linux and Mac it occupies room even when disabled).

Perhaps we should redo the scrubber line using some sort of absolutely positioned overlay (with SVG?) and avoid using position:sticky etc.

Comment 6

[Daisuke Akatsuka (:daisuke)]

I think this bug as well was fixed in bug 1456828.
Adrian, could you confirm?

Comment 7

[Adrian Florinescu [:aflorinescu]]

(In reply to Daisuke Akatsuka (:daisuke) from comment #6)
> I think this bug as well was fixed in bug 1456828.
> Adrian, could you confirm?

That is correct. Bug 1456828 is indeed fixing this issue as well. 
Verified that the problem is no longer an issue on Ubuntu 16.04 & Osx 10.13.3 on latest Nightly 06-18-2018.

Based on the above marking this as WFM.