Closed Bug 1465042 Opened Last year Closed Last year
Valid to ::Is Well Formed
46 bytes, text/x-phabricator-request
|Details | Review|
Based on a conversation in bug 1438687, we check for locale tags to be well formed, but not for validity. The latter would include checking that all subtags are in the subtag registry, which doesn't help us much in practice. Let's rename the status to match reality, and call it ::IsWellFormed.
Thanks for filing this Axel! To add details: 1) Change mIsValid -> mIsWellFormed 2) Change IsValid() -> IsWellFormed() 3) Change Invalidate() -> SetWellFormed(false) 4) Switch away from using well-formedness for matching exclusion 5) Document well-formed vs valid in the docs
Assignee: nobody → gandalf
Comment on attachment 9003309 [details] Bug 1465042 - Rename Locale::IsValid to ::IsWellFormed. r=jfkthame Jonathan Kew (:jfkthame) has approved the revision.
Attachment #9003309 - Flags: review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/0a5bf0b74a09 Rename Locale::IsValid to ::IsWellFormed. r=jfkthame
You need to log in before you can comment on or make changes to this bug.