Closed Bug 1465042 Opened 3 years ago Closed 3 years ago

Rename Locale::IsValid to ::IsWellFormed

Categories

(Core :: Internationalization, enhancement, P3)

Product:
Core
Component:
Internationalization
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: Pike, Assigned: zbraniecki)

Details

Attachments

(1 file)

Bug 1465042 - Rename Locale::IsValid to ::IsWellFormed. r=jfkthame
46 bytes, text/x-phabricator-request
jfkthame
: review+
Details | Review 
Based on a conversation in bug 1438687, we check for locale tags to be well formed, but not for validity. The latter would include checking that all subtags are in the subtag registry, which doesn't help us much in practice.

Let's rename the status to match reality, and call it ::IsWellFormed.
Thanks for filing this Axel!

To add details:
1) Change mIsValid -> mIsWellFormed
2) Change IsValid() -> IsWellFormed()
3) Change Invalidate() -> SetWellFormed(false)
4) Switch away from using well-formedness for matching exclusion
5) Document well-formed vs valid in the docs
Assignee: nobody → gandalf
Priority: -- → P3
Status: NEW → ASSIGNED
Comment on attachment 9003309 [details]
Bug 1465042 - Rename Locale::IsValid to ::IsWellFormed. r=jfkthame

Jonathan Kew (:jfkthame) has approved the revision.
Attachment #9003309 - Flags: review+
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a5bf0b74a09
Rename Locale::IsValid to ::IsWellFormed. r=jfkthame
https://hg.mozilla.org/mozilla-central/rev/0a5bf0b74a09
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.