1465050 - config_file_search_path is undefined

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, enhancement)

Description

[Marco Castelluccio [:marco]]

https://dxr.mozilla.org/mozilla-central/rev/a466172aed4bc2afc21169b749b8068a4b98c93f/testing/mozharness/mozharness/mozilla/building/buildbase.py#555

Comment 1

[Chris AtLee [:catlee]]

Where is this causing problems, or is it a linting failure?

Comment 2

[Marco Castelluccio [:marco]]

When adding a new platform, if you make a mistake, the error message that should be printed (`Whoops!\n'--custom-build-variant' was passed but an [...]`) is not printed. So it makes it harder to understand what's wrong.

Comment 3

[Chris AtLee [:catlee]]

Attachment: Bug 1465050: Remove reference to config_file_search_path

Review commit: https://reviewboard.mozilla.org/r/247658/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247658/

Comment 4

[Marco Castelluccio [:marco]]

Comment on attachment 8981560 [details]
Bug 1465050: Remove reference to config_file_search_path

https://reviewboard.mozilla.org/r/247658/#review253690

Thanks ;)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5852258260e1
Remove reference to config_file_search_path r=marco

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/5852258260e1