Closed Bug 1465062 Opened 6 years ago Closed 6 years ago

There are two classes called AutoGCSlice

Categories

(Core :: JavaScript: GC, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: jonco, Assigned: pbone)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file)

There's gcstats::AutoGCSlice and also AutoGCSlice defined in an anonymous namespace in GC.cpp.

The latter enables and disables incremental GC barriers as appropriate.  It should probably be called AutoUpdateBarriers or something like that.
I'll think about the name and do this soon. Thanks.  Part of me knew that there were two of these, that I'd seen it elsewhere, but I didn't notice properly.
Assignee: nobody → pbone
Status: NEW → ASSIGNED
I chose AutoDisableBarriers
Attachment #8981825 - Flags: review?(jcoppeard)
Blocks: 1464986
Comment on attachment 8981825 [details] [diff] [review]
Bug 1465062 - Rename AutoGCSlice to AutoDisableBarriers r?jonco

Review of attachment 8981825 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/gc/GC.cpp
@@ +6963,5 @@
>  
>  namespace {
>  
> +/*
> + * Temporarilly disable barriers during GC slices

nit: full stop at the end please.
Attachment #8981825 - Flags: review?(jcoppeard) → review+
Pushed by pbone@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd3624038a30
Rename AutoGCSlice to AutoDisableBarriers r=jonco
https://hg.mozilla.org/mozilla-central/rev/bd3624038a30
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: