1465064 - Add Canadian English (en-CA) to shipped-locales for Firefox 62

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Francesco Lodolo [:flod]]

Canadian English has been keeping up with changes for this cycle, we want to ship it in Firefox 62.

Comment 1

[Francesco Lodolo [:flod]]

Release Note Request (optional, but appreciated)
[Why is this notable]: new localization
[Affects Firefox for Android]: no
[Suggested wording]: Locale added: English Canadian (en-CA)
[Links (documentation, blog post, etc)]: -

Comment 2

[Francesco Lodolo [:flod]]

Attachment: Bug 1465064 - Add Canadian English (en-CA) to shipped-locales for Firefox 62

Review commit: https://reviewboard.mozilla.org/r/247536/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247536/

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 8981413 [details]
Bug 1465064 - Add Canadian English (en-CA) to shipped-locales for Firefox 62

https://reviewboard.mozilla.org/r/247536/#review254650

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45586dc94edd
Add Canadian English (en-CA) to shipped-locales for Firefox 62 r=Pike

Comment 5

[Justin Wood (:Callek)]

Mihai, can you please add a note in ReleaseWarrior for 62.0rc that we'll need to properly publish en-CA for that release at that time. (I'll cover this more when we speak in person)

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/45586dc94edd

Comment 7

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to Justin Wood (:Callek) from comment #5)
> Mihai, can you please add a note in ReleaseWarrior for 62.0rc that we'll
> need to properly publish en-CA for that release at that time. (I'll cover
> this more when we speak in person)

Done, thanks for the heads-up

Comment 8

[Liz Henry (:lizzard)]

This is in the 62 beta release notes as "Added Canadian English (en-CA) locale"

Comment 9

[Liz Henry (:lizzard)]

Peiying, or flod, can you make sure that we add this locale is added to whatever testing we do for first run, about, and other important pages like the what's new pages?

Comment 10

[Liz Henry (:lizzard)]

Alex, are you the right person to ask about adding automated tests?

Comment 11

[Alex Gibson [:agibson]]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #10)
> Alex, are you the right person to ask about adding automated tests?

It's not quite clear what kind of automated tests you're asking for here, but if this is just regarding enabling the en-CA build of Firefox, it would be covered automatically in our download link tests [1] that crawl through the localized download page [2].

[1] https://github.com/mozilla/bedrock/blob/master/tests/functional/test_download_l10n.py
[2] https://www.mozilla.org/en-US/firefox/all/

If you're asking about functional tests for pages like /firstrun & /whatsnew etc, /firstrun has now moved in-product as of FF 62, so is no longer on mozorg's radar so to speak. For pages like /whatsnew, the list of locales changes frequently for each release so testing is handled on an as needed basis.

Hope that helps.