Closed Bug 1465173 Opened 2 years ago Closed 2 years ago

Automation output reports test harness pid instead of test pid

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: sfink, Assigned: sfink)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This is a nuisance for msan tests, because currently the only way to associate a test with its detailed msan output is by pid, but the pids of the msan sanitize_log.NNNNN reports are of the actual test (appropriately enough), but that file doesn't specify what test ran. You need to correlate them with the log file, except it has the wrong pids so you can't.
Implementation is messy. I kept it as an 'extra' thing because it doesn't make sense on Windows. That may have been a mistake; it might be cleaner to have it as a more first-class thing and just not set it on Windows. (Really, I should dig up what sort of equivalent thing exists on Windows, but at the moment I wouldn't make any use of it anyway.)
Attachment #8981581 - Flags: review?(nicolas.b.pierron)
Attachment #8981581 - Flags: review?(nicolas.b.pierron) → review+
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d0c7ab48964
Set the pid correctly in the automation output, r=nbp
https://hg.mozilla.org/mozilla-central/rev/7d0c7ab48964
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.