Closed Bug 1465175 Opened 2 years ago Closed 2 years ago

Consider to remove mozAutoDocConditionalContentUpdateBatch

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: smaug, Assigned: smaug)

Details

Attachments

(1 file)

The original use from https://bugzilla.mozilla.org/show_bug.cgi?id=423269 is long gone and it is unclear to me why https://bugzilla.mozilla.org/show_bug.cgi?id=522595 used mozAutoDocConditionalContentUpdateBatch
As far as I see the code at least these days should be able to use normal mozAutoDocUpdate


Let's see if tryserver reveals some case I haven't thought about.
remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/9a803854fa76850c06e28c155e2dba99f5d719fd
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a803854fa76850c06e28c155e2dba99f5d719fd
remote: recorded changegroup in replication log in 0.054s
Attachment #8981582 - Flags: review?(dbaron)
Comment on attachment 8981582 [details] [diff] [review]
remove_mozAutoDocConditionalContentUpdateBatch.diff

So this is a substantive change, in that right now the document is non-null for attribute declarations (element.style) and null for style rules, page rules, and keyframe rules.  The two classes differ when the document is null, so this means we'd be calling nsContentUtils::{Add,Remove}ScriptBlocker where we weren't doing so before.  (nsDocument::{Begin,End}Update do that, so it seems like it should be safe.)  If you think that's the right thing to do, then r=dbaron.
Attachment #8981582 - Flags: review?(dbaron) → review+
aaand I pushed to try from a broken m-i.
Same patch
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f2687c052d0a48adfa45f14fc9716466a9558b8
remote: recorded changegroup in replication log in 0.102s
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7a6b594d800
Remove mozAutoDocConditionalContentUpdateBatch, r=dbaron
https://hg.mozilla.org/mozilla-central/rev/f7a6b594d800
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.