Closed
Bug 1465232
Opened 7 years ago
Closed 7 years ago
Separate Top Tabs collectionview logic from TopTabsViewController
Categories
(Firefox for iOS :: Browser, enhancement, P1)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | 13.0 | --- |
People
(Reporter: farhan, Assigned: farhan)
Details
Attachments
(1 file)
We'd like to unify the tab logic of TopTabsViewController and the TabTrayViewController into a single TabDisplayManager.
Both VCs use a collectionview to display tabs and should easily be able to share a single implementation.
This will also help prevent crashes in the TabTray as its implementation of animations/drag and drop is a bit outdated
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → fpatel
|
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8981645 -
Flags: review?(jdarcangelo)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8981645 [details] [review]
Pull Request
One small nit about indentation, otherwise LGTM.
Attachment #8981645 -
Flags: review?(jdarcangelo) → review+
|
|
||
Updated•7 years ago
|
|
|
Assignee | |
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•