Closed Bug 1465347 Opened 2 years ago Closed 2 years ago

Remove the ability to sort results by annotation

Categories

(Toolkit :: Places, enhancement, P1)

Product:
Toolkit
Component:
Places
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: mak, Assigned: standard8)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

Bug 1465347 - Remove the ability to sort results by annotation as it is no longer used.
46 bytes, text/x-phabricator-request
mak
: review+
Details | Review 
nsINavHistoryResult::sortingAnnotation and SORT_BY_ANNOTATION_* can go away along with all the code supporting them.
This is a nice simplification since it may allow us to move all the sorting to SQL in the future.

PS: there's a "newSortingAnnotation" var leftover in treeView.js
Blocks: 1460577
I was going to do this as part of bug 1402890, however, having a separate reminder won't hurt.
we can do this sooner than bug 1402890.
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Priority: P2 → P1
Try push is pending tree re-opening.
Comment on attachment 8985439 [details]
Bug 1465347 - Remove the ability to sort results by annotation as it is no longer used.

Marco Bonardo [::mak] has approved the revision.

https://phabricator.services.mozilla.com/D1662
Attachment #8985439 - Flags: review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/30a61cd82d54
Remove the ability to sort results by annotation as it is no longer used. r=mak
https://hg.mozilla.org/mozilla-central/rev/30a61cd82d54
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.