1465347 - Remove the ability to sort results by annotation

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement, P1)

Description

[Marco Bonardo [:mak] (Away July 4-13)]

nsINavHistoryResult::sortingAnnotation and SORT_BY_ANNOTATION_* can go away along with all the code supporting them.
This is a nice simplification since it may allow us to move all the sorting to SQL in the future.

PS: there's a "newSortingAnnotation" var leftover in treeView.js

Comment 1

[Mark Banner (:standard8)]

I was going to do this as part of bug 1402890, however, having a separate reminder won't hurt.

Comment 2

[Marco Bonardo [:mak] (Away July 4-13)]

we can do this sooner than bug 1402890.

Comment 3

[Phabricator Automation]

Attachment: Bug 1465347 - Remove the ability to sort results by annotation as it is no longer used.

MozReview-Commit-ID: bl588eAmkD

Comment 4

[Mark Banner (:standard8)]

Try push is pending tree re-opening.

Comment 5

[Phabricator Automation]

Comment on attachment 8985439 [details]
Bug 1465347 - Remove the ability to sort results by annotation as it is no longer used.

Marco Bonardo [::mak] has approved the revision.

https://phabricator.services.mozilla.com/D1662

Comment 6

[Mark Banner (:standard8)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=608d0589a96f8f4af2d13e4927cf97a856d2be9e

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30a61cd82d54
Remove the ability to sort results by annotation as it is no longer used. r=mak

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/30a61cd82d54