Closed
Bug 1465347
Opened 7 years ago
Closed 7 years ago
Remove the ability to sort results by annotation
Categories
(Toolkit :: Places, enhancement, P1)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: mak, Assigned: standard8)
References
Details
(Whiteboard: [fxsearch])
Attachments
(1 file)
nsINavHistoryResult::sortingAnnotation and SORT_BY_ANNOTATION_* can go away along with all the code supporting them.
This is a nice simplification since it may allow us to move all the sorting to SQL in the future.
PS: there's a "newSortingAnnotation" var leftover in treeView.js
Assignee | ||
Comment 1•7 years ago
|
||
I was going to do this as part of bug 1402890, however, having a separate reminder won't hurt.
Reporter | ||
Comment 2•7 years ago
|
||
we can do this sooner than bug 1402890.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment 3•7 years ago
|
||
MozReview-Commit-ID: bl588eAmkD
Assignee | ||
Comment 4•7 years ago
|
||
Try push is pending tree re-opening.
Comment 5•7 years ago
|
||
Comment on attachment 8985439 [details]
Bug 1465347 - Remove the ability to sort results by annotation as it is no longer used.
Marco Bonardo [::mak] has approved the revision.
https://phabricator.services.mozilla.com/D1662
Attachment #8985439 -
Flags: review+
Assignee | ||
Comment 6•7 years ago
|
||
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/30a61cd82d54
Remove the ability to sort results by annotation as it is no longer used. r=mak
Comment 8•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•