Does ftp really need to use 64k buffers ?
Darin suggested I try to dumb it down and see the effect. I tried 4k 16k and 64k on both DSL (256kbps) and LAN (5Mbps). No difference. We can safely use 4k buffers for this.
cc'ing FTP folks.
Comment on attachment 84825 [details] [diff] [review] 4k buffers for data channel. Max 32k. sr=darin
Do we really want this? See bug 69836, which increased this originally.
bbaetz: actually, that bug was about the fact that we used to use 64 byte segments with a 512 byte maximum. it doesn't look like anyone tried 4k segments or a maximum of a more reasonable size such as what DP is suggesting here. also, the patch in that bugs shows 32k segments, but the source reads 64k!!
Comment on attachment 84825 [details] [diff] [review] 4k buffers for data channel. Max 32k. If theres no noticable perf difference, r=bbaetz
checked into trunk
VERIFIED as code change in lrx.