remove reference to old winxp in manifest file

RESOLVED FIXED in Firefox 62

Status

()

RESOLVED FIXED
7 months ago
6 months ago

People

(Reporter: jmaher, Assigned: apavel)

Tracking

54 Branch
mozilla62
Points:
---

Firefox Tracking Flags

(firefox62 fixed)

Details

(Whiteboard: [manifest_cleanup] )

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Comment 1

7 months ago
Created attachment 8982138 [details] [diff] [review]
removed old win references from browser.ini
Assignee: nobody → apavel
Attachment #8982138 - Flags: review?(jmaher)
(Assignee)

Comment 2

7 months ago
Created attachment 8982139 [details] [diff] [review]
removed old win references from a11y.ini
Attachment #8982139 - Flags: review?(jmaher)
(Reporter)

Comment 3

7 months ago
Comment on attachment 8982138 [details] [diff] [review]
removed old win references from browser.ini

Review of attachment 8982138 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/tests/browser/browser.ini
@@ +11,4 @@
>  [browser_shutdown_multi_acc_reference_doc.js]
>  [browser_shutdown_multi_reference.js]
>  [browser_shutdown_parent_own_reference.js]
> +skip-if = !e10s || os == 'win' # e10s specific test for a11y start/shutdown between parent and content.

this is skipping now on win7/win10, just leave the !e10s
Attachment #8982138 - Flags: review?(jmaher) → review-
(Reporter)

Comment 4

7 months ago
Comment on attachment 8982139 [details] [diff] [review]
removed old win references from a11y.ini

Review of attachment 8982139 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/tests/mochitest/jsat/a11y.ini
@@ +7,4 @@
>    doc_content_text.html
>    !/accessible/tests/mochitest/*.js
>    !/accessible/tests/mochitest/moz.png
> +skip-if = os == 'win'

remove the whole line here so we can run on win7/win10
Attachment #8982139 - Flags: review?(jmaher) → review-
(Assignee)

Comment 5

7 months ago
Created attachment 8982188 [details] [diff] [review]
updated patch_browser.ini
Attachment #8982138 - Attachment is obsolete: true
Attachment #8982139 - Attachment is obsolete: true
Attachment #8982188 - Flags: review?(jmaher)
(Assignee)

Comment 6

7 months ago
Created attachment 8982189 [details] [diff] [review]
updated patch_a11y.ini
Attachment #8982189 - Flags: review?(jmaher)
(Reporter)

Comment 7

7 months ago
Comment on attachment 8982188 [details] [diff] [review]
updated patch_browser.ini

Review of attachment 8982188 [details] [diff] [review]:
-----------------------------------------------------------------

the other reference to removing winXP are great.

::: accessible/tests/browser/browser.ini
@@ +15,3 @@
>  [browser_shutdown_pref.js]
>  [browser_shutdown_proxy_acc_reference.js]
> +skip-if = !e10s # e10s specific test for a11y start/shutdown between parent and content.

we need to keep the os == 'win' here

@@ +18,2 @@
>  [browser_shutdown_proxy_doc_acc_reference.js]
> +skip-if = !e10s # e10s specific test for a11y start/shutdown between parent and content.

and keep win here as well

@@ +20,2 @@
>  [browser_shutdown_multi_proxy_acc_reference_doc.js]
> +skip-if = !e10s # e10s specific test for a11y start/shutdown between parent and content.

and keep win here as well

@@ +22,2 @@
>  [browser_shutdown_multi_proxy_acc_reference_obj.js]
> +skip-if = !e10s # e10s specific test for a11y start/shutdown between parent and content.

and keep win here as well
Attachment #8982188 - Flags: review?(jmaher) → review-
(Reporter)

Comment 8

7 months ago
Comment on attachment 8982189 [details] [diff] [review]
updated patch_a11y.ini

Review of attachment 8982189 [details] [diff] [review]:
-----------------------------------------------------------------

great!
Attachment #8982189 - Flags: review?(jmaher) → review+
Keywords: checkin-needed
Whiteboard: [manifest_cleanup]

Comment 9

6 months ago
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7989875fbb6
remove reference to old winxp in manifest file r=jmaher
Keywords: checkin-needed

Comment 10

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c7989875fbb6
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.