1465372 - remove reference to old winxp in manifest file

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

there are 4 instances in this file:
https://searchfox.org/mozilla-central/source/accessible/tests/browser/browser.ini#14

and 1 instance in this file:
https://searchfox.org/mozilla-central/source/accessible/tests/mochitest/jsat/a11y.ini#10

Comment 1

[Andreea Pavel [:apavel]]

Attachment: removed old win references from browser.ini

Comment 2

[Andreea Pavel [:apavel]]

Attachment: removed old win references from a11y.ini

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8982138 [details] [diff] [review]
removed old win references from browser.ini

Review of attachment 8982138 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/tests/browser/browser.ini
@@ +11,4 @@
>  [browser_shutdown_multi_acc_reference_doc.js]
>  [browser_shutdown_multi_reference.js]
>  [browser_shutdown_parent_own_reference.js]
> +skip-if = !e10s || os == 'win' # e10s specific test for a11y start/shutdown between parent and content.

this is skipping now on win7/win10, just leave the !e10s

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8982139 [details] [diff] [review]
removed old win references from a11y.ini

Review of attachment 8982139 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/tests/mochitest/jsat/a11y.ini
@@ +7,4 @@
>    doc_content_text.html
>    !/accessible/tests/mochitest/*.js
>    !/accessible/tests/mochitest/moz.png
> +skip-if = os == 'win'

remove the whole line here so we can run on win7/win10

Comment 5

[Andreea Pavel [:apavel]]

Attachment: updated patch_browser.ini

Comment 6

[Andreea Pavel [:apavel]]

Attachment: updated patch_a11y.ini

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8982188 [details] [diff] [review]
updated patch_browser.ini

Review of attachment 8982188 [details] [diff] [review]:
-----------------------------------------------------------------

the other reference to removing winXP are great.

::: accessible/tests/browser/browser.ini
@@ +15,3 @@
>  [browser_shutdown_pref.js]
>  [browser_shutdown_proxy_acc_reference.js]
> +skip-if = !e10s # e10s specific test for a11y start/shutdown between parent and content.

we need to keep the os == 'win' here

@@ +18,2 @@
>  [browser_shutdown_proxy_doc_acc_reference.js]
> +skip-if = !e10s # e10s specific test for a11y start/shutdown between parent and content.

and keep win here as well

@@ +20,2 @@
>  [browser_shutdown_multi_proxy_acc_reference_doc.js]
> +skip-if = !e10s # e10s specific test for a11y start/shutdown between parent and content.

and keep win here as well

@@ +22,2 @@
>  [browser_shutdown_multi_proxy_acc_reference_obj.js]
> +skip-if = !e10s # e10s specific test for a11y start/shutdown between parent and content.

and keep win here as well

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8982189 [details] [diff] [review]
updated patch_a11y.ini

Review of attachment 8982189 [details] [diff] [review]:
-----------------------------------------------------------------

great!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7989875fbb6
remove reference to old winxp in manifest file r=jmaher

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c7989875fbb6