remove reference to old winxp in manifest file

RESOLVED FIXED in Firefox 62

Status

()

P3
normal
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: jmaher, Assigned: apavel)

Tracking

54 Branch
mozilla62
Points:
---

Firefox Tracking Flags

(firefox62 fixed)

Details

(Whiteboard: [domsecurity-backlog3])

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

7 months ago
we have 2 references in this manifest:
https://searchfox.org/mozilla-central/source/testing/web-platform/meta/content-security-policy/generic/generic-0_10.html.ini#5

when removing, if there are no remaining conditions, remove the test name
Priority: -- → P3
Whiteboard: [domsecurity-backlog3]
(Assignee)

Comment 2

7 months ago
Created attachment 8982169 [details] [diff] [review]
remove reference to old winxp in generic-0_10.html.ini
Assignee: nobody → apavel
Attachment #8982169 - Flags: review?(jmaher)
(Reporter)

Comment 3

7 months ago
Comment on attachment 8982169 [details] [diff] [review]
remove reference to old winxp in generic-0_10.html.ini

Review of attachment 8982169 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/web-platform/meta/content-security-policy/generic/generic-0_10.html.ini
@@ +6,3 @@
>    [Violation report status OK.]
>      expected:
> +      if not debug and (os == "win") : TIMEOUT

this now applies to win7/win10 whereas before this applied to winxp only.  We need to remove the entire clause (and delete 'expected' and [<name>] with no conditions)
Attachment #8982169 - Flags: review?(jmaher) → review-
(Assignee)

Comment 4

7 months ago
Created attachment 8982176 [details] [diff] [review]
remove reference to old winxp in generic-0_10.html.ini
Attachment #8982169 - Attachment is obsolete: true
Attachment #8982176 - Flags: review?(jmaher)
(Reporter)

Comment 5

7 months ago
Comment on attachment 8982176 [details] [diff] [review]
remove reference to old winxp in generic-0_10.html.ini

Review of attachment 8982176 [details] [diff] [review]:
-----------------------------------------------------------------

perfect.  As you can see the test is already disabled for all of win/!debug- now it is easier to read
Attachment #8982176 - Flags: review?(jmaher) → review+
(Reporter)

Updated

7 months ago
Keywords: checkin-needed
(Reporter)

Comment 6

7 months ago
:apavel, there are 2 other files (comment 1) that need attention as well- they were the same bugzilla component so I put them in the same bug. lets do checkin-needed after all patches are ready
Flags: needinfo?(apavel)
Keywords: checkin-needed
(Assignee)

Comment 7

7 months ago
Created attachment 8982191 [details] [diff] [review]
removed media-src-redir-bug.sub.html.ini manifest file
Flags: needinfo?(apavel)
Attachment #8982191 - Flags: review?(jmaher)
(Assignee)

Comment 8

7 months ago
Created attachment 8982192 [details] [diff] [review]
removed win XP references in media-src-7_1.html.ini
Attachment #8982192 - Flags: review?(jmaher)
(Reporter)

Comment 9

7 months ago
Comment on attachment 8982191 [details] [diff] [review]
removed media-src-redir-bug.sub.html.ini manifest file

Review of attachment 8982191 [details] [diff] [review]:
-----------------------------------------------------------------

I like removed files
Attachment #8982191 - Flags: review?(jmaher) → review+
(Reporter)

Comment 10

7 months ago
Comment on attachment 8982192 [details] [diff] [review]
removed win XP references in media-src-7_1.html.ini

Review of attachment 8982192 [details] [diff] [review]:
-----------------------------------------------------------------

well done
Attachment #8982192 - Flags: review?(jmaher) → review+
(Reporter)

Updated

7 months ago
Keywords: checkin-needed

Comment 11

7 months ago
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/af54112146f9
remove reference to old winxp in manifest file r=jmaher
https://hg.mozilla.org/integration/mozilla-inbound/rev/cd597e745065
removed manifest file r=jmaher
https://hg.mozilla.org/integration/mozilla-inbound/rev/f443ef59e6da
remove reference to old winxp in manifest file r=jmaher
Keywords: checkin-needed

Comment 12

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/af54112146f9
https://hg.mozilla.org/mozilla-central/rev/cd597e745065
https://hg.mozilla.org/mozilla-central/rev/f443ef59e6da
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.