Closed Bug 1465396 Opened Last year Closed Last year

SpiderMonkey bustages on test262/built-ins/Array/prototype/flat/ when when Gecko 62 merges to Beta on 14-06-2018

Categories

(Core :: JavaScript: Standard Library, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla62
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox60 --- unaffected
firefox61 --- unaffected
firefox62 + verified

People

(Reporter: RaulGurzau, Assigned: evilpie)

References

Details

Attachments

(1 file)

Central as Beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed376ac1d1c4617b98d720c832dded991ef6bd61&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=180858976

Log link of bustage: https://treeherder.mozilla.org/logviewer.html#?job_id=180858976&repo=try&lineNumber=121224

Log snippet:

[task 2018-05-30T10:36:07.756Z] test262/built-ins/Array/prototype/flat/null-undefined-elements.js:13:21 TypeError: [...].flat is not a function
[task 2018-05-30T10:36:07.756Z] Stack:
[task 2018-05-30T10:36:07.756Z]   @test262/built-ins/Array/prototype/flat/null-undefined-elements.js:13:21
[task 2018-05-30T10:36:07.757Z] TEST-UNEXPECTED-FAIL | test262/built-ins/Array/prototype/flat/null-undefined-elements.js | (args: "") [0.1 s]

This seems to affect every flat test. This is a regression from Bug 1465039
Flags: needinfo?(evilpies)
Assignee: nobody → evilpies
Status: NEW → ASSIGNED
Comment on attachment 8981942 [details] [diff] [review]
Skip Array.prototype.flat tests when disabled

Thanks for opening this bug. I should have been a bit more careful while writing this patch.
Flags: needinfo?(evilpies)
Attachment #8981942 - Flags: review?(andrebargull)
Comment on attachment 8981942 [details] [diff] [review]
Skip Array.prototype.flat tests when disabled

Review of attachment 8981942 [details] [diff] [review]:
-----------------------------------------------------------------

Tststs, ignored the (slightly misplaced) review comment in the other bug. :-D
Attachment #8981942 - Flags: review?(andrebargull) → review+
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e47d4f48c695
Skip Array.prototype.flat tests when disabled. r=anba
(In reply to André Bargull [:anba] from comment #3)
> Comment on attachment 8981942 [details] [diff] [review]
> Skip Array.prototype.flat tests when disabled
> 
> Review of attachment 8981942 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Tststs, ignored the (slightly misplaced) review comment in the other bug. :-D

ARGGGH, you are right, that is even worse.
https://hg.mozilla.org/mozilla-central/rev/e47d4f48c695
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Tracking for 62 in case this reopens.
You need to log in before you can comment on or make changes to this bug.