Closed Bug 1465409 Opened Last year Closed Last year

[Eslint] Enforce no spaces around array brackets

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: bryce, Assigned: bryce)

Details

Attachments

(1 file)

Bug 1461785 introduced linting rules to apply spaces around array brackets. E.g. [ "foo", "bar" ] was preferred to ["foo", "bar"]. After discussion with :jib and :jya we've decided that the latter is preferred.

This can easily be fixed by changing the appropriate eslint rule[0] in our mediasource eslintrc.js and auto applying changes via `./mach lint -l eslint dom/media --fix`. Some manual intervention may be required for multiline arrays where we've manually indented to get alignment.

[0]: https://eslint.org/docs/rules/array-bracket-spacing
Assignee: nobody → bvandyk
Status: NEW → ASSIGNED
Priority: -- → P3
Comment on attachment 8981830 [details]
Bug 1465409 - Change lint rules for mediasource tests to prefer no spaces for array notation.

https://reviewboard.mozilla.org/r/247882/#review254268
Attachment #8981830 - Flags: review?(jyavenard) → review+
Pushed by bvandyk@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ae4cc41c1ad
Change lint rules for mediasource tests to prefer no spaces for array notation. r=jya
https://hg.mozilla.org/mozilla-central/rev/4ae4cc41c1ad
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.