1465476 - Support binary expressions for globals evaluation in ESLint

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Mark Banner (:standard8)]

I've just had a report that this doesn't work for defining globals:

XPCOMUtils.defineLazyPreferenceGetter(this, "resetStatus", BROWSER_SEARCH_PREF + "reset.status", "");

The third argument is a binary expression, and our manual handling AST source-reconstruction doesn't cope with that yet. So I'll add a patch for it.

Ideally we should handle template literals as well, but reconstructing those seems a lot harder...

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1465476 - Support binary expressions for globals evaluation in ESLint.

Review commit: https://reviewboard.mozilla.org/r/247928/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247928/

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8981903 [details]
Bug 1465476 - Support binary expressions for globals evaluation in ESLint.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247928/diff/1-2/

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 8981903 [details]
Bug 1465476 - Support binary expressions for globals evaluation in ESLint.

https://reviewboard.mozilla.org/r/247928/#review255182

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/721c4f5f0fe7
Support binary expressions for globals evaluation in ESLint. r=mossop

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/721c4f5f0fe7