1465496 - 9.22 - 16.95% tps / tsvgx (windows10-64) regression on push 85572fbd667360384b63a29a2d7ac0bf1285658d (Tue May 29 2018)

Status: VERIFIED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

Talos has detected a Firefox performance regression from push:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=85572fbd667360384b63a29a2d7ac0bf1285658d

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

 17%  tsvgx windows10-64 opt e10s stylo     148.13 -> 173.24
  9%  tps windows10-64 pgo e10s stylo       13.63 -> 14.91
  9%  tps windows10-64 opt e10s stylo       14.87 -> 16.24


You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=13541

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the Talos jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://wiki.mozilla.org/Buildbot/Talos/Tests

For information on reproducing and debugging the regression, either on try or locally, see: https://wiki.mozilla.org/Buildbot/Talos/Running

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Our wiki page outlines the common responses and expectations: https://wiki.mozilla.org/Buildbot/Talos/RegressionBugsHandling

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

tsvgx profiles:
before: https://perf-html.io/from-url/https%3A%2F%2Fqueue.taskcluster.net%2Fv1%2Ftask%2FeUBluui6S9Cb4JE4N46GDw%2Fruns%2F0%2Fartifacts%2Fpublic%2Ftest_info%2Fprofile_tsvgx.zip

after: https://perf-html.io/from-url/https%3A%2F%2Fqueue.taskcluster.net%2Fv1%2Ftask%2FEUzs2d9oRrStFJuZW_az5g%2Fruns%2F0%2Fartifacts%2Fpublic%2Ftest_info%2Fprofile_tsvgx.zip


tps profiles:
before: https://perf-html.io/from-url/https%3A%2F%2Fqueue.taskcluster.net%2Fv1%2Ftask%2FUGQS-t6MQjuENhj6Bf91_Q%2Fruns%2F0%2Fartifacts%2Fpublic%2Ftest_info%2Fprofile_tps.zip

after: https://perf-html.io/from-url/https%3A%2F%2Fqueue.taskcluster.net%2Fv1%2Ftask%2FYy9tTovrRL-gvhmJQDX6KQ%2Fruns%2F0%2Fartifacts%2Fpublic%2Ftest_info%2Fprofile_tps.zip


for reference here are the before/after pushes:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&group_state=expanded&filter-searchStr=talos%20win%20x64%20-p&tochange=9b516954e1031202b00b924accfb0861a973986f&fromchange=516dc753d6541dd3179a3627b44dd5209b053301

the profiles come from jobs labeled with a -p.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Investigated this with mstange, looks like I broke the optimizer for single frame GIFs with the last part in my bug. I'll correct this.

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Let's make sure backing out part 9 resolves this. There are some optimizations related to this that I will explore in bug 1465619 now that it is obvious to me what a win optimizing the surfaces on Windows will give (this bug/regression aside, we only optimize frames if the image isn't animated, but if we are blending off the main thread, and we don't enter discard mode, we could easily optimize the frames and maybe get a big win?):

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=74ef59c3ad38e26cb6e9dee47829582bafdebd02

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8429320386e
Backout part 9 of bug 1462355 to fix talos regressions. r=aosmond

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/c8429320386e

Comment 6

[Ionuț Goldan [:igoldan]]

All reported regressions have been fixed:

== Change summary for alert #13575 (as of Wed, 30 May 2018 20:35:56 GMT) ==

Improvements:

 14%  tsvgx windows10-64 pgo e10s stylo     165.39 -> 142.30
 14%  tsvgx windows10-64 opt e10s stylo     174.64 -> 150.97
 11%  tps windows10-64 pgo e10s stylo       14.72 -> 13.17
 10%  tps windows10-64 opt e10s stylo       16.20 -> 14.60

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=13575