Closed
Bug 1465547
Opened 7 years ago
Closed 7 years ago
Update Debugger Frontend v61
Categories
(DevTools :: Debugger, enhancement, P3)
DevTools
Debugger
Tracking
(firefox62 fixed)
RESOLVED
FIXED
Firefox 62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: davidwalsh, Assigned: davidwalsh)
References
Details
Attachments
(1 file)
27.87 KB,
patch
|
jdescottes
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
My first attempt at a real release -- be kind jdescottes!
Attachment #8981977 -
Flags: review?(jdescottes)
Updated•7 years ago
|
Severity: normal → enhancement
Status: NEW → ASSIGNED
Comment 3•7 years ago
|
||
Comment on attachment 8981977 [details] [diff] [review]
Release61-1.patch
Review of attachment 8981977 [details] [diff] [review]:
-----------------------------------------------------------------
Very nice! Try is exceptionally green. Quick manual test looks ok. Didn't see anything weird in the updated files.
Talos push: https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=a59ffab9d35192207b99cdef949b37ad9a96257e&newProject=try&newRevision=27edb93f822a0c248082ddce553a70c4608db53e&framework=1
One comment about the GitHub side of things.
Usually Jason includes a last commit when doing a release which updates assets/module-manifest.json. The commit is named after the release number (here it would be "Release 61").
Now that we no longer bundle the debugger though, I'm not sure we should keep doing this?
Jason: can you give your input about this, do you feel like this additional commit is still needed?
Attachment #8981977 -
Flags: review?(jlaster)
Attachment #8981977 -
Flags: review?(jdescottes)
Attachment #8981977 -
Flags: review+
Comment 4•7 years ago
|
||
yep, we should still have it for the other bundles.
the steps are:
1. yarn copy
2. git add .; git commit -m 'release N'
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/335af54ff2cb
Update Debugger Frontend v61 r=jdescottes
Assignee | ||
Comment 6•7 years ago
|
||
I've added the update to assets/module-manifest.json and updated the branch on GitHub.
Comment 7•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•6 years ago
|
Attachment #8981977 -
Flags: review?(jlaster)
You need to log in
before you can comment on or make changes to this bug.
Description
•