Update Debugger Frontend v61

RESOLVED FIXED in Firefox 62

Status

enhancement
P3
normal
RESOLVED FIXED
a year ago
11 months ago

People

(Reporter: davidwalsh, Assigned: davidwalsh)

Tracking

(Blocks 1 bug)

unspecified
Firefox 62
Dependency tree / graph

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment)

Assignee

Updated

a year ago
Assignee: nobody → dwalsh
Priority: -- → P3
Assignee

Comment 2

a year ago
My first attempt at a real release -- be kind jdescottes!
Attachment #8981977 - Flags: review?(jdescottes)
Severity: normal → enhancement
Status: NEW → ASSIGNED
Comment on attachment 8981977 [details] [diff] [review]
Release61-1.patch

Review of attachment 8981977 [details] [diff] [review]:
-----------------------------------------------------------------

Very nice! Try is exceptionally green. Quick manual test looks ok. Didn't see anything weird in the updated files. 

Talos push: https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=a59ffab9d35192207b99cdef949b37ad9a96257e&newProject=try&newRevision=27edb93f822a0c248082ddce553a70c4608db53e&framework=1

One comment about the GitHub side of things. 
Usually Jason includes a last commit when doing a release which updates assets/module-manifest.json. The commit is named after the release number (here it would be "Release 61"). 
Now that we no longer bundle the debugger though, I'm not sure we should keep doing this?

Jason: can you give your input about this, do you feel like this additional commit is still needed?
Attachment #8981977 - Flags: review?(jlaster)
Attachment #8981977 - Flags: review?(jdescottes)
Attachment #8981977 - Flags: review+
yep, we should still have it for the other bundles.

the steps are:
1. yarn copy
2. git add .; git commit -m 'release N'
Assignee

Comment 6

a year ago
I've added the update to assets/module-manifest.json and updated the branch on GitHub.

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/335af54ff2cb
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62

Updated

a year ago
Product: Firefox → DevTools
Attachment #8981977 - Flags: review?(jlaster)
You need to log in before you can comment on or make changes to this bug.