Closed Bug 1465589 Opened 6 years ago Closed 6 years ago

Convert perfherder services to static functions

Categories

(Tree Management :: Perfherder, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wlach, Assigned: sclements)

References

Details

Attachments

(1 file)

We have a bunch of code here which we should mostly just convert into standalone functions and classes:

https://github.com/mozilla/treeherder/tree/master/ui/js/services/perf

The one exception I was going to say was this code which used angular $http, but I don't think it will even work, since it will return the "errors" object before the promise has completed:

https://github.com/mozilla/treeherder/blob/df5cb3fcf400c0da06098e6cac88e5f8c02a06e4/ui/js/services/perf/compare.js#L221

We should either rework whatever calls that function or just remove the code entirely.

:igoldan, this might be another good first bug to work on in this area.
:igoldan, did you want to work on this?
Flags: needinfo?(igoldan)
(In reply to Sarah Clements [:sclements] from comment #1)
> :igoldan, did you want to work on this?

No, since my priorities have changed. Feel free to pick this bug up.
Flags: needinfo?(igoldan)
Assignee: nobody → sclements
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: