1465700 - Remove JS_DeprecatedGetCompartmentPrincipals

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Description

[Jan de Mooij [:jandem]]

Bug 1464374 replaced most JS_GetCompartmentPrincipals calls with JS::GetRealmPrincipals, but there are a few more complicated ones left.

This is a blocker for the Gecko changes. On the JS engine side we can work around it by release-asserting single-realm and then just returning that realm's principals.

Comment 1

[Jan de Mooij [:jandem]]

On top of the patches in the dependent bugs, the main user now is xpc::GetCompartmentPrincipal, and at this point that's called by:

* AccessCheck::subsumes
* AccessCheck::subsumesConsideringDomain
* AccessCheck::subsumesConsideringDomainIgnoringFPD

None of these have a *ton* of callers so hopefully this won't be too hard to fix..

(There are also two JS_GetCompartmentPrincipals calls in WindowDestroyedEvent.cpp, for the wrapper nuking, but these are probably easier to deal with.)

Comment 2

[Jan de Mooij [:jandem]]

Once the dependent bugs are all fixed the remaining uses will be:

1) js::CompartmentsWithPrincipals::match, this is used in the document.domain code with RecomputeWrappers and that will go away at some point.

2) xpc::GetCompartmentPrincipal. The remaining callers of that are AccessCheck::subsumesConsideringDomain{IgnoringFPD} and these are now only used in the wrapping code. These calls will also go away with the other Gecko changes.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1465700. Remove the now-unused JS_DeprecatedGetCompartmentPrincipals API. r=jandem

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/526f7b418884
Remove the now-unused JS_DeprecatedGetCompartmentPrincipals API.  r=jandem

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/526f7b418884