Closed
Bug 1465737
Opened 6 years ago
Closed 6 years ago
error: bad implicit conversion constructor for 'CodeCoverageHandler' in Mac coverage builds
Categories
(Testing :: Code Coverage, defect)
Testing
Code Coverage
Tracking
(firefox62 fixed)
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: marco, Assigned: marco)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.06 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
> [task 2018-05-29T18:44:05.202Z] 18:44:05 INFO - In file included from /builds/worker/workspace/build/src/js/xpconnect/src/XPCShellImpl.cpp:54:
> [task 2018-05-29T18:44:05.202Z] 18:44:05 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/CodeCoverageHandler.h:26:3: error: bad implicit conversion constructor for 'CodeCoverageHandler'
> [task 2018-05-29T18:44:05.203Z] 18:44:05 INFO - CodeCoverageHandler(const CrossProcessMutexHandle& aHandle);
> [task 2018-05-29T18:44:05.203Z] 18:44:05 INFO - ^
> [task 2018-05-29T18:44:05.203Z] 18:44:05 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/CodeCoverageHandler.h:26:3: note: consider adding the explicit keyword to the constructor
> [task 2018-05-29T18:44:05.204Z] 18:44:05 INFO - 1 error generated.
> [task 2018-05-29T18:44:05.204Z] 18:44:05 INFO - /builds/worker/workspace/build/src/config/rules.mk:1031: recipe for target 'Unified_cpp_js_xpconnect_src1.o' failed
> [task 2018-05-29T18:44:05.204Z] 18:44:05 INFO - make[4]: *** [Unified_cpp_js_xpconnect_src1.o] Error 1
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8982166 -
Flags: review?(nfroyd)
|
||
Updated•6 years ago
|
Attachment #8982166 -
Flags: review?(nfroyd) → review+
Pushed by mcastelluccio@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d615a37f01d2 Make CodeCoverageHandler constructor explicit. r=froydnj
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d615a37f01d2
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•