1465785 - Convert the JS tests suites to Python 3.

Status: RESOLVED DUPLICATE of bug 1619475

(Core :: JavaScript Engine, enhancement, P3)

Description

[Nicolas B. Pierron [:nbp]]

As mach forced us to move to Python 3, I am not longer able to run any tests / jit-tests which still requires python 2.7 to run.

Converting the tests / jit-tests harness to python 3 should solve this issue.

Comment 1

[Nicolas B. Pierron [:nbp]]

Attachment: Convert JS tests suites to Python 3.

This patch changes add decoding of bytes strings into strings, and uses io.open
instead of the open builtin such that this code can be used both with Python 2.7
and Python 3.

Note, I had to make the code compatible with Python 2.7 because I do not know
how to run python 3 from mach_commands.py testing commands.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8982548 [details] [diff] [review]
Convert JS tests suites to Python 3.

Review of attachment 8982548 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/tests/lib/tests.py
@@ +59,5 @@
>          return kwargs['none']
>      return JITFLAGS[variant]
>  
>  def valid_jitflags():
> +    return [ x for x in JITFLAGS.keys() ]

`list(JITFLAGS.keys())` will likely work as well.

Comment 3

[Nicolas B. Pierron [:nbp]]

(In reply to :Ms2ger (⌚ UTC+1/+2) from comment #2)
> ::: js/src/tests/lib/tests.py
> >  def valid_jitflags():
> > +    return [ x for x in JITFLAGS.keys() ]
> 
> `list(JITFLAGS.keys())` will likely work as well.

Tested locally, works with both Python 3.5 and 2.7.

Comment 4

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8982548 [details] [diff] [review]
Convert JS tests suites to Python 3.

Review of attachment 8982548 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm. The Queue case thing is kind of crazy. Thank you!

Comment 5

[Nicolas B. Pierron [:nbp]]

One last thing reported by Try on Windows: sys.maxint --> sys.maxsize, which should also work as expected on both python 2 and 3.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2f729e22888574313f2a5a0e1764a559e97dd538

Comment 6

[Nicolas B. Pierron [:nbp]]

The attached patch is no longer sufficient, since the ref test test suite now depends on a HUGE amount of python code which would have to be converted as well.

Giving up on this task for the moment.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:nbp, could you have a look please?

Comment 8

[Nicolas B. Pierron [:nbp]]

(In reply to Release mgmt bot [:sylvestre / :calixte] from comment #7)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:nbp, could you have a look please?

See comment 6.

Someone else added a new dependency preventing this simple patch from applying. Therefore dropping the ownership of this bug. If someone else want to continue from my patch, then are free to do so, but I am not giving more time to this issue.

Comment 9

[Hamzah Akhtar]

Attachment: Bug 1557307 - Bug#1465785 - Convert the JS tests suites to Python 3.

Depends on D32485

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The following patch is waiting for review from a reviewer who resigned from the review:

ID	Title	Author	Reviewer Status
D33365	Bug 1557307 - Bug#1465785 - Convert the JS tests suites to Python 3.	hamzah18051	arai: Resigned from review

:hamzah18051, could you please find another reviewer or abandon the patch if it is no longer relevant?

For more information, please visit auto_nag documentation.

Comment 11

[Steve Fink [:sfink] [:s:]]

It looks like this ended up happening mostly in bug 1619475. There may be something left in this patch that's still useful, but given that we're running the tests under python3 all the time now, it would be minor.