Closed Bug 1465810 Opened 2 years ago Closed 2 years ago

Update Codemirror to 5.38.0

Categories

(DevTools :: Source Editor, defect)

defect
Not set
normal

Tracking

(firefox62 fixed)

RESOLVED FIXED
Firefox 62
Tracking Status
firefox62 --- fixed

People

(Reporter: tjr, Assigned: gl)

References

Details

(Whiteboard: [third-party-lib-audit])

Attachments

(1 file)

This is a (semi-)automated bug making you aware that there is an available upgrade for an embedded third-party library. You can leave this bug open, and it will be updated if a newer version of the library becomes available. If you close it as WONTFIX, please indicate if you do not wish to receive any future bugs upon new releases of the library.

Codemirror is currently at version 5.37.0 in mozilla-central, and the latest version of the library released is 5.38.0. 

I fetched the latest version of the library from https://github.com/codemirror/CodeMirror/.
Assignee: nobody → gl
Status: NEW → ASSIGNED
Comment on attachment 8982545 [details]
Bug 1465810 - Update Codemirror to 5.38.0.

https://reviewboard.mozilla.org/r/248526/#review254748

It looks like the bundle got minified down to one line - was that intentional?
(In reply to Brian Grinstead [:bgrins] from comment #2)
> Comment on attachment 8982545 [details]
> Bug 1465810 - Update Codemirror to 5.38.0.
> 
> https://reviewboard.mozilla.org/r/248526/#review254748
> 
> It looks like the bundle got minified down to one line - was that
> intentional?

It was actually minified the last time we upgraded and then it got reverted in Bug 1465080
Comment on attachment 8982545 [details]
Bug 1465810 - Update Codemirror to 5.38.0.

https://reviewboard.mozilla.org/r/248526/#review254764

> It was actually minified the last time we upgraded and then it got reverted
> in Bug 1465080

Yeah I thought this seemed familiar. What can we do to make sure we don't keep bouncing back and forth between the minified and non-minfiied version?
Attachment #8982545 - Flags: review?(bgrinstead) → review+
https://hg.mozilla.org/mozilla-central/rev/b23905eefff4
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.