1465810 - Update Codemirror to 5.38.0

Status: RESOLVED FIXED

(DevTools :: Source Editor, defect)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

This is a (semi-)automated bug making you aware that there is an available upgrade for an embedded third-party library. You can leave this bug open, and it will be updated if a newer version of the library becomes available. If you close it as WONTFIX, please indicate if you do not wish to receive any future bugs upon new releases of the library.

Codemirror is currently at version 5.37.0 in mozilla-central, and the latest version of the library released is 5.38.0. 

I fetched the latest version of the library from https://github.com/codemirror/CodeMirror/.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1465810 - Update Codemirror to 5.38.0.

Review commit: https://reviewboard.mozilla.org/r/248526/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248526/

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8982545 [details]
Bug 1465810 - Update Codemirror to 5.38.0.

https://reviewboard.mozilla.org/r/248526/#review254748

It looks like the bundle got minified down to one line - was that intentional?

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=20e261f03cf44bc5707083442547f07ffe22af51

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

(In reply to Brian Grinstead [:bgrins] from comment #2)
> Comment on attachment 8982545 [details]
> Bug 1465810 - Update Codemirror to 5.38.0.
> 
> https://reviewboard.mozilla.org/r/248526/#review254748
> 
> It looks like the bundle got minified down to one line - was that
> intentional?

It was actually minified the last time we upgraded and then it got reverted in Bug 1465080

Comment 5

[Brian Grinstead [:bgrins]]

Comment on attachment 8982545 [details]
Bug 1465810 - Update Codemirror to 5.38.0.

https://reviewboard.mozilla.org/r/248526/#review254764

> It was actually minified the last time we upgraded and then it got reverted
> in Bug 1465080

Yeah I thought this seemed familiar. What can we do to make sure we don't keep bouncing back and forth between the minified and non-minfiied version?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b23905eefff4
Update Codemirror to 5.38.0. r=bgrins

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b23905eefff4