1465841 - Allow configuring non-gecko projects

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

We need to support nss and nss-try (which don't have levels) as well as ci-admin and ci-configuration.

This may also involve changing the "gecko_repo" property to something a little clearer.  It sounds like it's boolean right now.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1465841 - rename gecko_repo to parent_repo

This is a bit more clear as to the meaning, `gecko_repo` sounds like a boolean
"is this a gecko repo" flag.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1465841: add nss and ci-* repositories + features

The gecko-roles and gecko-actions features are true for all of the existing
repos, but not for the newly-added, non-gecko repos.

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1465841: fix broken tests

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1465841: use parent_repo instead of gecko_repo

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1465841: handle gecko-actions, gecko-roles features

This also moves the extra_tc_scopes into the `repo:..` role, rather than in the
trust-level-specific role.  I anticipate future work will actually get rid of
all this complex role inheritance, so this is probably a taste of the future.

It also grants active_scm_level_1 access to nss-try's scopes, and
active_scm_level_3 access to ci-admin/ci-configuration's scopes.  I don't think
this is an issue.

Depends on: D2145

Comment 6

[Phabricator Automation]

Comment on attachment 8992087 [details]
Bug 1465841: use parent_repo instead of gecko_repo

Tom Prince [:tomprince] (limited availability Jul 16-29) has approved the revision.

https://phabricator.services.mozilla.com/D2145

Comment 7

[Phabricator Automation]

Comment on attachment 8992084 [details]
Bug 1465841: add nss and ci-* repositories + features

Tom Prince [:tomprince] (limited availability Jul 16-29) has approved the revision.

https://phabricator.services.mozilla.com/D2143

Comment 8

[Phabricator Automation]

Comment on attachment 8992083 [details]
Bug 1465841 - rename gecko_repo to parent_repo

Tom Prince [:tomprince] (limited availability Jul 16-29) has approved the revision.

https://phabricator.services.mozilla.com/D2142

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

I landed this since it was reviwed once and I believe I addressed the feedback -- and it was blocking other stuff.

Comment 10

[Phabricator Automation]

Comment on attachment 8992086 [details]
Bug 1465841: fix broken tests

Tom Prince [:tomprince] (limited availability Jul 16-29) has approved the revision.

https://phabricator.services.mozilla.com/D2144

Comment 11

[Phabricator Automation]

Comment on attachment 8992088 [details]
Bug 1465841: handle gecko-actions, gecko-roles features

Tom Prince [:tomprince] (limited availability Jul 16-29) has approved the revision.

https://phabricator.services.mozilla.com/D2146