Closed Bug 1465870 Opened 4 years ago Closed 4 years ago

Port bug 1459455 to TB: Allow changing the tab separator color

Categories

(Thunderbird :: Theme, enhancement)

x86
Windows 10
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 62.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files)

Bug 1459455 made it possible to set the tab separator colour independent of the tab text colour.
Port of https://hg.mozilla.org/mozilla-central/rev/16f1a4771b09#l1.1 and https://hg.mozilla.org/mozilla-central/rev/16f1a4771b09#l2.1 We don't have a .titlebar-placeholder[type="pre-tabs"], so no need to port this part.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8982282 - Flags: review?(jorgk)
Attached file test-webext-theme.xpi
As usual, my test theme with wonderful colours to show the tab separators in yellow.
Comment on attachment 8982282 [details] [diff] [review]
tab-separator.patch

Something is wrong with WE themes. I built after fixing bustage at lunchtime so I have the latest trunk build. When I enable your theme, I see the ugly colour for a split second, then it reverts back to normal colours. I noticed that it needs a restart now. After the restart, I see the tab separators in the theme colour.

Can you please test and then file a bug: "WE themes need restart to be effective". Any idea when that work correctly?
Attachment #8982282 - Flags: review?(jorgk) → review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/2463d996da66
Port bug 1459455 to TB: Allow changing the tab separator color. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 62.0
You need to log in before you can comment on or make changes to this bug.