1465884 - Remove MOZ_DEV_EDITION checks in HttpChannelChild.cpp

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P3)

Description

[Daniel Holbert [:dholbert]]

HttpChannelChild.cpp has some compile-time MOZ_DEV_EDITION checks that would be nice to remove, in service of bug 1459240.

It looks like these checks were just part of adding a diagnostic assert to investigate a crash, in bug 1322610.

Based on bug 1322610 comment 7, it sounded like maybe the diagnostic might still have some value down the line (when we get to bug 1306801 at least).

valentin, do you have any updates on the usefulness of the diagnostic?  If it's no longer going to be useful, can/should we back it out?  Or if not, would it be OK to make it Nightly-only, so that we've got one fewer compile-time  MOZ_DEV_EDITION check?

Comment 1

[Valentin Gosu [:valentin] (he/him)]

It's no longer useful, and we can remove it.

Comment 2

[Daniel Holbert [:dholbert]]

Great, thanks!

(Sorry to have bothered you on your PTO - this could've waited until you returned. :)  Thank you for the quick reply!)

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: Bug 1465884: Back out no-longer-needed diagnostic for networking crash.

This commit is a (rebased) backout of changeset 016bcae14073 from bug 1322610,
which simply added a diagnostic to gather more information about a crash.
We can remove that diagnostic now, hence this commit.

Review commit: https://reviewboard.mozilla.org/r/248260/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248260/

Comment 4

[Patrick McManus [:mcmanus]]

Comment on attachment 8982315 [details]
Bug 1465884: Back out no-longer-needed diagnostic for networking crash.

https://reviewboard.mozilla.org/r/248260/#review254786

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9fd9a942834c
Back out no-longer-needed diagnostic for networking crash. r=mcmanus

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/9fd9a942834c