Closed Bug 1465884 Opened 2 years ago Closed 2 years ago
_DEV _EDITION checks in Http Channel Child .cpp
59 bytes, text/x-review-board-request
HttpChannelChild.cpp has some compile-time MOZ_DEV_EDITION checks that would be nice to remove, in service of bug 1459240. It looks like these checks were just part of adding a diagnostic assert to investigate a crash, in bug 1322610. Based on bug 1322610 comment 7, it sounded like maybe the diagnostic might still have some value down the line (when we get to bug 1306801 at least). valentin, do you have any updates on the usefulness of the diagnostic? If it's no longer going to be useful, can/should we back it out? Or if not, would it be OK to make it Nightly-only, so that we've got one fewer compile-time MOZ_DEV_EDITION check?
It's no longer useful, and we can remove it.
Great, thanks! (Sorry to have bothered you on your PTO - this could've waited until you returned. :) Thank you for the quick reply!)
Comment on attachment 8982315 [details] Bug 1465884: Back out no-longer-needed diagnostic for networking crash. https://reviewboard.mozilla.org/r/248260/#review254786
Attachment #8982315 - Flags: review?(mcmanus) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/9fd9a942834c Back out no-longer-needed diagnostic for networking crash. r=mcmanus
You need to log in before you can comment on or make changes to this bug.