Closed Bug 1465892 Opened Last year Closed Last year

Re-enable WR hit-testing assertions

Categories

(Core :: Graphics: WebRender, enhancement, P3)

Other Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: kats, Assigned: kats)

References

(Blocks 1 open bug)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

In bug 1436200 I disabled some assertions in the WR hit-testing codepath because they were failing with high frequency. Now that bug 1452845 has landed and async scene building is enabled in CI those assertions should not fail, so we should be able to re-enable them.
The above try push is green, but in https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f34d0a41806f8ad6e53b26c46ea7f1c9f842035 and https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4cc67607fc47f7bad13f0b34cea35b8a2c5eace which build on that I see the assertion triggering still. I'll investigate those before putting this patch up.
The problem here is that the WR hit_tester is getting updated at render time, outside of the scene swap. This doesn't fit with the mdoel I had in mind after the async scene building rearchitecture discussion with nical. mrobinson and I had a discussion on IRC: https://mozilla.logbot.info/gfx/20180601#c14837698 onwards and it should be easy to fix this.
Botond, I've put the gecko patch up for review now since you'll be away next week, but I'll hold off on landing it until we have the WR update with the PR.
Comment on attachment 8982513 [details]
Bug 1465892 - Re-enable assertions for WR hit-testing codepath.

https://reviewboard.mozilla.org/r/248478/#review254868

Sounds good!
Attachment #8982513 - Flags: review?(botond) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8a711fdf59d0
Re-enable assertions for WR hit-testing codepath. r=botond
https://hg.mozilla.org/mozilla-central/rev/8a711fdf59d0
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.