1465892 - Re-enable WR hit-testing assertions

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

In bug 1436200 I disabled some assertions in the WR hit-testing codepath because they were failing with high frequency. Now that bug 1452845 has landed and async scene building is enabled in CI those assertions should not fail, so we should be able to re-enable them.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=193cc2d9dd17edebf7cc71a6c478506841134c28

Comment 2

[Kartikaya Gupta (email:[e-mail])]

The above try push is green, but in https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f34d0a41806f8ad6e53b26c46ea7f1c9f842035 and https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4cc67607fc47f7bad13f0b34cea35b8a2c5eace which build on that I see the assertion triggering still. I'll investigate those before putting this patch up.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

The problem here is that the WR hit_tester is getting updated at render time, outside of the scene swap. This doesn't fit with the mdoel I had in mind after the async scene building rearchitecture discussion with nical. mrobinson and I had a discussion on IRC: https://mozilla.logbot.info/gfx/20180601#c14837698 onwards and it should be easy to fix this.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

New try push with PR included: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c7ae219c9595bd8db118608e28ec29163249e6b9

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1465892 - Re-enable assertions for WR hit-testing codepath.

Review commit: https://reviewboard.mozilla.org/r/248478/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248478/

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Botond, I've put the gecko patch up for review now since you'll be away next week, but I'll hold off on landing it until we have the WR update with the PR.

Comment 7

[Botond Ballo [:botond]]

Comment on attachment 8982513 [details]
Bug 1465892 - Re-enable assertions for WR hit-testing codepath.

https://reviewboard.mozilla.org/r/248478/#review254868

Sounds good!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a711fdf59d0
Re-enable assertions for WR hit-testing codepath. r=botond

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/8a711fdf59d0