Status

()

enhancement
P3
normal
RESOLVED FIXED
11 months ago
a month ago

People

(Reporter: Nika, Assigned: bzbarsky)

Tracking

unspecified
mozilla63
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

11 months ago
It's pretty much unused, so we can just switch to using Attr in the remaining places instead.
(Reporter)

Comment 1

11 months ago
I took the liberty of assigning you. Feel free to unassign yourself.
Flags: needinfo?(bzbarsky)
Attachment #8991718 - Flags: review?(continuation)
(Assignee)

Updated

9 months ago
Flags: needinfo?(bzbarsky)
Comment on attachment 8991717 [details] [diff] [review]
part 1.  Remove nsIAttribute::GetMap, SetMap, SetOwnerDocument, NodeInfo methods

Review of attachment 8991717 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/Attr.cpp
@@ +27,5 @@
>  #include "mozAutoDocUpdate.h"
>  #include "nsWrapperCacheInlines.h"
>  
> +nsIAttribute::nsIAttribute(already_AddRefed<mozilla::dom::NodeInfo>& aNodeInfo)
> +: nsINode(aNodeInfo)

nit: while you are here, this should be indented by 2.

::: dom/base/Attr.h
@@ +50,5 @@
>                                      ErrorResult& aError) override;
>  
>    void GetEventTargetParent(EventChainPreVisitor& aVisitor) override;
>  
> +  nsDOMAttributeMap *GetMap()

nit: * should be on the left.
Attachment #8991717 - Flags: review?(continuation) → review+
Attachment #8991718 - Flags: review?(continuation) → review+
> nit: while you are here, this should be indented by 2.

True, but that line goes away in part 2, so not going to worry about it.

> nit: * should be on the left.

Done.

Comment 6

9 months ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3901250891c
part 1.  Remove nsIAttribute::GetMap, SetMap, SetOwnerDocument, NodeInfo methods.  r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/c5ba337f7afe
part 2.  Remove nsIAttribute.  r=mccr8

Comment 7

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b3901250891c
https://hg.mozilla.org/mozilla-central/rev/c5ba337f7afe
Status: NEW → RESOLVED
Last Resolved: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.