1465922 - Make it possible to choose which threads are sampled when running with --geckoProfile

Status: RESOLVED DUPLICATE of bug 1702310

(Testing :: Talos, enhancement, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

We already have --geckoProfile and --geckoProfileEntries for how big the buffer to be. We should also add something like --geckoProfileThreads to provide a list of thread filters to sample for.

Bonus points if we go the extra mile and add --geckoProfileSamplingRate to override the tests default sampling rate.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

We've added this to Raptor recently. Is there still interest in supporting this in Talos?

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Dave Hunt [:davehunt] [he/him] ⌚️UTC from comment #1)

We've added this to Raptor recently. Is there still interest in supporting this in Talos?

I meant to reference the bug here, it's bug 1544686.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Yes, very much so!

Comment 4

[Steve Fink [:sfink] [:s:]]

I believe this should work once bug 1702310 lands, though you might need to spell it --gecko-profile-entries, --gecko-profile-interval, and --gecko-profile-threads. I left in the existing aliases, but I don't think I added new ones for eg --geckoProfileThreads. They wouldn't be hard to add if the camelCase ones are preferred for some reason; I was just trying to follow the current code that seems to deprecate those names.