Closed Bug 1465976 Opened 2 years ago Closed 2 years ago

remove all find*ByName APIs from PSM PKCS#11 module/slot/token interfaces

Categories

(Core :: Security: PSM, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: keeler, Assigned: keeler)

References

Details

(Whiteboard: [psm-assigned])

Attachments

(1 file)

We expose a few interfaces that revolve around mapping a name to a specific PKCS#11 module, slot, or token. These APIs are all either problematic and/or unnecessary. In theory there could be two tokens in different modules with the same name, so nsIPK11TokenDB.findTokenByName isn't guaranteed to return what the consumer expects it to. In general, these APIs are used by front-end code to go from a handle on the specific object in question to a string identifier and then back to a handle on the object. This is unnecessary - we should just keep the handle around.
Comment on attachment 8982346 [details]
bug 1465976 - remove all find*ByName APIs from PSM PKCS#11 module/slot/token interfaces

https://reviewboard.mozilla.org/r/248302/#review255020

lgtm. +1 for cleaning this up.
Attachment #8982346 - Flags: review?(franziskuskiefer) → review+
Comment on attachment 8982346 [details]
bug 1465976 - remove all find*ByName APIs from PSM PKCS#11 module/slot/token interfaces

https://reviewboard.mozilla.org/r/248302/#review255178

This commentary is equally applicable to this patch: https://www.thinking-drinking.com/uploads/1/0/1/0/10109347/9688830_orig.jpg
Attachment #8982346 - Flags: review?(jjones) → review+
Pushed by dkeeler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/051ef1eb3d23
remove all find*ByName APIs from PSM PKCS#11 module/slot/token interfaces r=fkiefer,jcj
https://hg.mozilla.org/mozilla-central/rev/051ef1eb3d23
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.