1465976 - remove all find*ByName APIs from PSM PKCS#11 module/slot/token interfaces

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P1)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

We expose a few interfaces that revolve around mapping a name to a specific PKCS#11 module, slot, or token. These APIs are all either problematic and/or unnecessary. In theory there could be two tokens in different modules with the same name, so nsIPK11TokenDB.findTokenByName isn't guaranteed to return what the consumer expects it to. In general, these APIs are used by front-end code to go from a handle on the specific object in question to a string identifier and then back to a handle on the object. This is unnecessary - we should just keep the handle around.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: bug 1465976 - remove all find*ByName APIs from PSM PKCS#11 module/slot/token interfaces

Before this patch, we exposed a few interfaces that revolved around mapping a
name to a specific PKCS#11 module, slot, or token. These APIs were all either
problematic and/or unnecessary. In theory there could be two tokens in different
modules with the same name, so nsIPK11TokenDB.findTokenByName wasn't guaranteed
to return what the consumer expected it to. In general, these APIs were used by
front-end code to go from a handle on the specific object in question to a
string identifier and then back to a handle on the object. This was unnecessary
- we can just retain the original handle.

Review commit: https://reviewboard.mozilla.org/r/248302/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248302/

Comment 2

[Franziskus Kiefer [:franziskus]]

Comment on attachment 8982346 [details]
bug 1465976 - remove all find*ByName APIs from PSM PKCS#11 module/slot/token interfaces

https://reviewboard.mozilla.org/r/248302/#review255020

lgtm. +1 for cleaning this up.

Comment 3

[J.C. Jones [:jcj] (he/him)]

Comment on attachment 8982346 [details]
bug 1465976 - remove all find*ByName APIs from PSM PKCS#11 module/slot/token interfaces

https://reviewboard.mozilla.org/r/248302/#review255178

This commentary is equally applicable to this patch: https://www.thinking-drinking.com/uploads/1/0/1/0/10109347/9688830_orig.jpg

Comment 4

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8982346 [details]
bug 1465976 - remove all find*ByName APIs from PSM PKCS#11 module/slot/token interfaces

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/248302/diff/1-2/

Comment 5

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Thanks! Here's try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=80e91f9088046f45af6527f6b6b251756e70815d

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/051ef1eb3d23
remove all find*ByName APIs from PSM PKCS#11 module/slot/token interfaces r=fkiefer,jcj

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/051ef1eb3d23