1466031 - Upstream tests for Web animations <-> CSS animation integration to web-platform-tests

Status: RESOLVED FIXED

(Core :: DOM: Animation, enhancement, P3)

Description

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Apple have asked to us to upstream this and it would be useful to have these in place so we can add tests to them in bug 1459536.

Comment 1

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Use arrow functions in dom/animation/test/css-animations/;

Review commit: https://reviewboard.mozilla.org/r/248364/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248364/

Comment 2

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Replace var with const/let in dom/animation/test/css-animations/;

Review commit: https://reviewboard.mozilla.org/r/248366/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248366/

Comment 3

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Use async/await in dom/animation/test/css-animations/;

Review commit: https://reviewboard.mozilla.org/r/248368/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248368/

Comment 4

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Use for ... of instead of forEach in a few places in dom/animation/test/css-animations/;

Review commit: https://reviewboard.mozilla.org/r/248370/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248370/

Comment 5

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Fix the spelling of canceled/canceling in dom/animation/test/css-animations/;

Review commit: https://reviewboard.mozilla.org/r/248372/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248372/

Comment 6

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Update the titles of each test file;

Some of these names will make more sense after the renaming of files towards the
end of this patch series.

Also a couple of files do not have titles added since they will be subsequently
removed.

Review commit: https://reviewboard.mozilla.org/r/248374/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248374/

Comment 7

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Apply various whitespace tweaks to test_animation-computed-timing.html;

Review commit: https://reviewboard.mozilla.org/r/248376/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248376/

Comment 8

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Re-arrange tests in test_animations-currenttime.html;

A number of these tests are redundant with other tests or are otherwise
unnecessary. Other tests should be moved to a more appropriate file.

Some notable examples:

* A number of the tests relate to dispatching events in various phases and have
  been moved to test_event-dispatch.html.
* The "Seeking finished -> paused dispatches animationstart" test is covered
  by the "After -> Active" test in test_event-dispatch.html (which also
  operates on a paused animation).
* The "Animation.currentTime clamping" is really just testing finishing
  behavior and is covered by the updating-the-finished-state.html tests in the
  Web Animations web-platform-tests (specifically the "Updating the finished
  state when playing past end" test).
* Likewise for the "Animation.currentTime clamping for reversed animation"
  test.

Review commit: https://reviewboard.mozilla.org/r/248378/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248378/

Comment 9

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Drop test_animation-finish.html;

These tests are all covered elsewhere:

* The "Test exceptions when finishing infinite animation" test is covered by
  the "Finishing an infinite animation throws" test in
  finishing-an-animation.html in the Web Animations web-platform-tests.
* The "Test finish() while paused" test is covered by the "Finishing a paused
  animation resolves the start time" test in finishing-an-animation.html in
  the Web Animations web-platform-tests.
* The "Test finish() while pause-pending with positive playbackRate" test is
  covered by the "Finishing a pause-pending animation resolves the pending
  task immediately and update the start time" test in
  finishing-an-animation.html in the Web Animations web-platform-tests.
* The 'Test finish() while pause-pending with negative playbackRate" test is
  covered by the "Finishing a pause-pending animation with negative playback
  rate resolves the pending task immediately" test in
  finishing-an-animation.html in the Web Animations web-platform-tests.

In fact, it very much looks like these tests were copied to Web Animations'
web-platform-tests at some point without deleting the original.

Review commit: https://reviewboard.mozilla.org/r/248380/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248380/

Comment 10

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Tidy up test_animation-finished.html;

This mostly just involves using promise_rejects to simplify some test code.

The change to the test description of the last test might seem like it is giving
it the opposite meaning but the original test name was "Test finished promise
changes when animationPlayState set to running"[1], and it is about testing
that there are NO changes but that got lost when the "Test" part of the
description was dropped.


[1] https://searchfox.org/mozilla-central/rev/cb846d13d3f9ec5d38ace93a74f749a18e9c67f5/dom/animation/test/css-animations/test_animation-player-finished.html#287

Review commit: https://reviewboard.mozilla.org/r/248382/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248382/

Comment 11

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Tweak whitespace in test_animation-id.html;

This just makes the grouping a little more clear I think.

Review commit: https://reviewboard.mozilla.org/r/248384/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248384/

Comment 12

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Tidy up test_animations-playstate.html;

Review commit: https://reviewboard.mozilla.org/r/248386/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248386/

Comment 13

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Tidy up test_animation-ready.html;

Although many of these tests are similar to tests in the Web Animations
web-platform-tests test suite they focus on the interaction with
animation-play-state and so are probably worth keeping.

There are two exceptions that I felt were worth changing:

* The test for the handling of a ready promise on an aborted pause. I could not
  find a similar test in the Web Animations wpt and it the test is not really
  particular to CSS animations so this patch moves it to Web Animations wpt.

* The test for the resolution value of the ready promise for a paused animation
  is covered by the "A pending ready promise should be resolved and not replaced
  when the animation is paused" in pausing-an-animation.html in the Web
  Animations wpt (although peripherally) and that seems like the better place
  for this test anyway (it is not specific to CSS animations) so I have simply
  deleted it from this file.

Review commit: https://reviewboard.mozilla.org/r/248388/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248388/

Comment 14

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Move the reversing test to Web Animations web-platform-tests;

Review commit: https://reviewboard.mozilla.org/r/248390/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248390/

Comment 15

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Update test_animation-starttime.html;

This patch updates the tests in this file as follows:

* startTime of a newly created (play-pending) animation is unresolved
  -> Covered by 'startTime of a play-pending animation is unresolved'
     in wpt/web-animations/interfaces/Animation/startTime.html

     However, it would be useful to have a test a new CSS animation is
     play-pending so I have extended the test in test_animation-playstate.html
     to cover this.

* startTime of a newly created (pause-pending) animation is unresolved
  -> Covered by 'startTime of a pause-pending animation is unresolved'
     in wpt/web-animations/interfaces/Animation/startTime.html

* startTime is resolved when running
  -> Covered by 'startTime is resolved when running'
     in wpt/web-animations/interfaces/Animation/startTime.html

* startTime is unresolved when paused
  -> Moved to wpt/web-animations/timing-model/animations/pausing-an-animation.html

* startTime while pause-pending and play-pending
  -> Moved to wpt/web-animations/timing-model/animations/pausing-an-animation.html

* startTime while play-pending from finished state,
  startTime while play-pending from finished state using finish()
  -> Merged and moved to wpt/web-animations/timing-model/animations/playing-an-animation.html

* Pausing should make the startTime become null
  -> Simplified and merged into the test for 'startTime is unresolved when
     paused' / 'Pausing clears the start time' test in
     wpt/web-animations/timing-model/animations/pausing-an-animation.html

* Sanity test to check round-tripping assigning to a new animation's startTime
  -> Updated and left.

* Skipping forward through animation
  -> This is really testing two things:
     (a) That you can seek a CSS animation using the start time.
         For this it makes sense to have a separate test that also checks that
         the computed style is updated (like we have for current time).
     (b) That seeking a CSS animation using the start time triggers
         dispatching events.

     This patch splits the above into two separate tests.

* Skipping backwards through animation,
  Redundant change, before -> active, then back,
  Redundant change, before -> after, then back,
  Redundant change, active -> before, then back,
  Redundant change, active -> after, then back,
  Redundant change, after -> before, then back,
  Redundant change, after -> active, then back
  -> All these tests are really just exercising event dispatch which is
     already covered by test_event-dispatch.html.

     Provided we have a test that checks that events are dispatched when
     setting the startTime we don't need to test each combination again since
     we have tests for each of these combinations already when using the
     currentTime to seek and we can assume UAs are following the same code
     path at this point.

     As a result this patch drops these tests.

* Setting startTime to null
  -> Covered by 'Setting an unresolved start time sets the hold time'
     in wpt/web-animations/timing-model/animations/setting-the-start-time-of-an-animation.html

* Animation.startTime after pausing
  -> Covered by the new 'Pausing clears the start time' test in
     wpt/web-animations/timing-model/animations/pausing-an-animation.html

* Animation.startTime after canceling
  -> Merged into
     wpt/web-animations/timing-model/animations/canceling-an-animation.html
     and made it follow the spec a little more closely (which requires
     clearing the start time and hold time).

Review commit: https://reviewboard.mozilla.org/r/248392/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248392/

Comment 16

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Update test_animations-dynamic-changes.html;

Review commit: https://reviewboard.mozilla.org/r/248394/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248394/

Comment 17

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Update test_element-get-animations.html;

As well as addressing a few FIXMEs this patch drops the checking of start times
since that seems out of scope for this file and is covered elsewhere (I believe
we only added it at first to bootstrap this work).

Review commit: https://reviewboard.mozilla.org/r/248396/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248396/

Comment 18

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Update test description in test_pseudoElement-get-animations.html;

Review commit: https://reviewboard.mozilla.org/r/248398/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248398/

Comment 19

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Update test_setting-effect.html;

Apart from whitespace / test description tests this patch also drops an
assertion about the animation playState since it seems unrelated to the purpose
of that particular test.

Review commit: https://reviewboard.mozilla.org/r/248400/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248400/

Comment 20

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Move CSS animations / Web animation integration tests to web-platform-tests;

Review commit: https://reviewboard.mozilla.org/r/248402/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248402/

Comment 21

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Update event-dispatch test now that we can use the updated EventWatcher;

Review commit: https://reviewboard.mozilla.org/r/248404/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248404/

Comment 22

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Move CSS animations / Web animation integration tests to web-platform-tests;

Review commit: https://reviewboard.mozilla.org/r/248410/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248410/

Comment 23

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Add spec links to test files;

Review commit: https://reviewboard.mozilla.org/r/248412/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248412/

Comment 24

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Update event-dispatch test now that we can use the updated EventWatcher;

Review commit: https://reviewboard.mozilla.org/r/248414/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248414/

Comment 25

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8982418 [details]
Bug 1466031 - Use arrow functions in dom/animation/test/css-animations/;

https://reviewboard.mozilla.org/r/248364/#review254622

::: dom/animation/test/css-animations/test_animation-starttime.html:213
(Diff revision 1)
>  
>      // Despite going backwards from just after the active interval starts to
>      // the animation start time, we now expect an animationend event
>      // because we went from inside to outside the active interval.
>      return eventWatcher.wait_for('animationend');
> -  }).then(function() {
> +                                }).then(() => {

On MozReview, this identation looks broken.

Comment 26

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8982419 [details]
Bug 1466031 - Replace var with const/let in dom/animation/test/css-animations/;

https://reviewboard.mozilla.org/r/248366/#review254628

If the next 'async/await' patch came prior to this patch, it would be easier to review.

Comment 27

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8982420 [details]
Bug 1466031 - Use async/await in dom/animation/test/css-animations/;

https://reviewboard.mozilla.org/r/248368/#review254624

::: dom/animation/test/css-animations/test_animations-dynamic-changes.html:21
(Diff revision 1)
>    let originalStartTime;
>    let originalCurrentTime;
>  
>    // Wait a moment so we can confirm the startTime doesn't change (and doesn't
>    // simply reflect the current time).
> -  return originalAnimation.ready.then(() => {
> +  await originalAnimation.ready;
> +
> -    originalStartTime = originalAnimation.startTime;
> +  originalStartTime = originalAnimation.startTime;
> -    originalCurrentTime = originalAnimation.currentTime;
> +  originalCurrentTime = originalAnimation.currentTime;

Nit:
const originalStartTime =
const originalCurrentTime =

::: dom/animation/test/css-animations/test_animations-dynamic-changes.html:137
(Diff revision 1)
>    // Wait and add second Animation
> -  return firstAddedAnimation.ready.then(waitForFrame).then(() => {
> +  await firstAddedAnimation.ready;
> +  await waitForFrame();
> +
> -    div.style.animation = 'anim1 100s, anim1 100s';
> +  div.style.animation = 'anim1 100s, anim1 100s';
> -    secondAddedAnimation = div.getAnimations()[0];
> +  secondAddedAnimation = div.getAnimations()[0];

Nit:
const secondAddedAnimation =

::: dom/animation/test/css-animations/test_animations-dynamic-changes.html:144
(Diff revision 1)
> -    // Wait again and add another Animation
> +  // Wait again and add another Animation
> -    return secondAddedAnimation.ready.then(waitForFrame);
> -  }).then(() => {
> +  await secondAddedAnimation.ready;
> +  await waitForFrame();
> +
> -    div.style.animation = 'anim1 100s, anim2 100s, anim1 100s';
> +  div.style.animation = 'anim1 100s, anim2 100s, anim1 100s';
> -    animations = div.getAnimations();
> +  animations = div.getAnimations();

Nit:
const animations = div.getAnimations();

Comment 28

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8982421 [details]
Bug 1466031 - Use for ... of instead of forEach in a few places in dom/animation/test/css-animations/;

https://reviewboard.mozilla.org/r/248370/#review254638

Comment 29

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8982422 [details]
Bug 1466031 - Fix the spelling of canceled/canceling in dom/animation/test/css-animations/;

https://reviewboard.mozilla.org/r/248372/#review254640

Comment 30

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8982423 [details]
Bug 1466031 - Update the titles of each test file;

https://reviewboard.mozilla.org/r/248374/#review254642

::: dom/animation/test/css-animations/test_animation-pausing.html:3
(Diff revision 1)
>  <!doctype html>
>  <meta charset=utf-8>
> +<title>CSSAnimation pausing</title>

For consistency, this should be 'Pausing a CSSAniamtion'?

::: dom/animation/test/css-animations/test_effect-target.html:3
(Diff revision 1)
>  <!doctype html>
>  <meta charset=utf-8>
> +<title>KeyframeEffect.target for CSS Animations</title>

If this is 'CSSAnimation.effect.target', it would be ambiguous?

I really prefer 'CSSAnimation.startTime' or some such in this patch, they are pretty simple and easy to understand what the test supposes.

Comment 31

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8982424 [details]
Bug 1466031 - Apply various whitespace tweaks to test_animation-computed-timing.html;

https://reviewboard.mozilla.org/r/248376/#review254644

Comment 32

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8982425 [details]
Bug 1466031 - Re-arrange tests in test_animations-currenttime.html;

https://reviewboard.mozilla.org/r/248378/#review254646

::: testing/web-platform/tests/web-animations/timing-model/animations/pausing-an-animation.html:57
(Diff revision 1)
> +  animation.pause();
> +  await animation.ready;
> +
> +  const currentTimeAfterPausing = animation.currentTime;
> +
> +  await waitForNextFrame();

Nice!

Comment 33

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8982426 [details]
Bug 1466031 - Drop test_animation-finish.html;

https://reviewboard.mozilla.org/r/248380/#review254652

Comment 34

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8982427 [details]
Bug 1466031 - Tidy up test_animation-finished.html;

https://reviewboard.mozilla.org/r/248382/#review254654

Comment 35

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8982428 [details]
Bug 1466031 - Tweak whitespace in test_animation-id.html;

https://reviewboard.mozilla.org/r/248384/#review254656

Comment 36

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8982429 [details]
Bug 1466031 - Tidy up test_animations-playstate.html;

https://reviewboard.mozilla.org/r/248386/#review254658

Comment 37

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8982430 [details]
Bug 1466031 - Tidy up test_animation-ready.html;

https://reviewboard.mozilla.org/r/248388/#review254660

::: commit-message-d2b09:10
(Diff revision 1)
> +animation-play-state and so are probably worth keeping.
> +
> +There are two exceptions that I felt were worth changing:
> +
> +* The test for the handling of a ready promise on an aborted pause. I could not
> +  find a similar test in the Web Animations wpt and it the test is not really

Nit:

'it the test is not' -> 'it is not' or 'the test is not' ?

Comment 38

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8982431 [details]
Bug 1466031 - Move the reversing test to Web Animations web-platform-tests;

https://reviewboard.mozilla.org/r/248390/#review254664

Comment 39

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8982433 [details]
Bug 1466031 - Update test_animations-dynamic-changes.html;

https://reviewboard.mozilla.org/r/248394/#review254670

I didn't notice this change when I left the comments for 'async/await' change.

Comment 40

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8982435 [details]
Bug 1466031 - Update test description in test_pseudoElement-get-animations.html;

https://reviewboard.mozilla.org/r/248398/#review254672

Comment 41

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8982436 [details]
Bug 1466031 - Update test_setting-effect.html;

https://reviewboard.mozilla.org/r/248400/#review254676

Comment 42

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8982442 [details]
Bug 1466031 - Move CSS animations / Web animation integration tests to web-platform-tests;

https://reviewboard.mozilla.org/r/248410/#review254678

Comment 43

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8982443 [details]
Bug 1466031 - Add spec links to test files;

https://reviewboard.mozilla.org/r/248412/#review254680

::: testing/web-platform/tests/css/css-animations/CSSAnimation-canceling.tentative.html:5
(Diff revision 1)
>  <!doctype html>
>  <meta charset=utf-8>
>  <title>Canceling a CSS animation</title>
> +<!-- TODO: Add a more specific link for this one it is specified. -->
> +<link rel="help" href="https://drafts.csswg.org/css-animations-2/">

I guess you might have wanted to link https://drafts.csswg.org/css-animations-2/#cssanimation ?  It's not a big deal though.

::: testing/web-platform/tests/css/css-animations/CSSAnimation-playState.tentative.html:5
(Diff revision 1)
>  <!doctype html>
>  <meta charset=utf-8>
>  <title>CSSAnimation.playState</title>
> +<!-- TODO: Add a more specific link for this one it is specified. -->
> +<link rel="help" href="https://drafts.csswg.org/css-animations-2/#cssanimation">

I don't quite understand why we can use https://drafts.csswg.org/css-animations-2/#animation-play-state ?

::: testing/web-platform/tests/css/css-animations/Document-getAnimations.tentative.html:4
(Diff revision 1)
>  <!doctype html>
>  <meta charset=utf-8>
>  <title>Document.getAnimations() for CSS animations</title>
> +<link rel="help" href="https://drafts.csswg.org/css-animations-2/#animation-composite-order">

Is this the correct link?

Comment 44

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8982444 [details]
Bug 1466031 - Update event-dispatch test now that we can use the updated EventWatcher;

https://reviewboard.mozilla.org/r/248414/#review254682

\o/

Comment 45

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8982434 [details]
Bug 1466031 - Update test_element-get-animations.html;

https://reviewboard.mozilla.org/r/248396/#review254684

::: dom/animation/test/css-animations/test_element-get-animations.html:352
(Diff revision 1)
>    const animations = parent.getAnimations({ subtree: false });
>    assert_equals(animations.length, 1,
>                  'Should find only the element even if it has a child');
>    assert_equals(animations[0].effect.target, parent,
>                  'Effect target shuld be the element');
> -}, 'Test AnimationFilter{ subtree: false } with element that has a child');
> +}, '{ subtree: false } on an element with a child returns only the element\'s'

I am wondering pseudo elements isn't counted as child?

::: dom/animation/test/css-animations/test_element-get-animations.html:397
(Diff revision 1)
>    assert_equals(animations[5].effect.target.type, '::after',
>                  'The animation targeting the ::after pesudo-element ' +
>                  'should be returned last');
>    assert_equals(animations[5].effect.target.parentElement, child,
>                  'This ::after element should be child of child element');
> -}, 'Test AnimationFilter{ subtree: true } with element that has a child');
> +}, '{ subtree: true } on an element with a child returns animations from the'

Hmm, it seems pseudo elements are not child.  Ignore the previous comment.

::: dom/animation/test/css-animations/test_element-get-animations.html:443
(Diff revision 1)
>  
>    assert_equals(animations[4].effect.target, child2,
>                  'The animation targeting the child2 element ' +
>                  'should be returned last');
>  
> -}, 'Test AnimationFilter{ subtree: true } with element that has many descendant');
> +}, '{ subtree: true } on element with many descendants returns animations'

Nit: 'on an element' for consistency.

Comment 46

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8982432 [details]
Bug 1466031 - Update test_animation-starttime.html;

https://reviewboard.mozilla.org/r/248392/#review254688

::: dom/animation/test/css-animations/test_animation-starttime.html:69
(Diff revision 1)
>    animation.startTime = animation.timeline.currentTime - 100 * MS_PER_SEC;
>    await eventWatcher.wait_for('animationstart');
>  
>    animation.startTime = animation.timeline.currentTime - 200 * MS_PER_SEC;
>    await eventWatcher.wait_for('animationend');
> -}, 'Skipping forward through animation');
> +}, 'Seeking a CSS animation using the start time dispatchs animation events');

I am not sure this test case should be moved into event-dispath.html or not.

Comment 47

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8982434 [details]
Bug 1466031 - Update test_element-get-animations.html;

https://reviewboard.mozilla.org/r/248396/#review254904

MozReview didn't respond my r+?

Comment 48

[Brian Birtles (:birtles, Feb 26~ parental leave)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #25)
> Comment on attachment 8982418 [details]
> Bug 1466031 - Use arrow functions in dom/animation/test/css-animations/;
> 
> https://reviewboard.mozilla.org/r/248364/#review254622
> 
> ::: dom/animation/test/css-animations/test_animation-starttime.html:213
> (Diff revision 1)
> >  
> >      // Despite going backwards from just after the active interval starts to
> >      // the animation start time, we now expect an animationend event
> >      // because we went from inside to outside the active interval.
> >      return eventWatcher.wait_for('animationend');
> > -  }).then(function() {
> > +                                }).then(() => {
> 
> On MozReview, this identation looks broken.

Yeah, MozReview is right, it's broken. Fixed.

Comment 49

[Brian Birtles (:birtles, Feb 26~ parental leave)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #26)
> Comment on attachment 8982419 [details]
> Bug 1466031 - Replace var with const/let in
> dom/animation/test/css-animations/;
> 
> https://reviewboard.mozilla.org/r/248366/#review254628
> 
> If the next 'async/await' patch came prior to this patch, it would be easier
> to review.

I couldn't bring myself to add more var declarations so I decided to do this first.

Comment 50

[Brian Birtles (:birtles, Feb 26~ parental leave)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #27)
> Comment on attachment 8982420 [details]
> Bug 1466031 - Use async/await in dom/animation/test/css-animations/;
> 
> https://reviewboard.mozilla.org/r/248368/#review254624
> 
> ::: dom/animation/test/css-animations/test_animations-dynamic-changes.html:21
> (Diff revision 1)
> >    let originalStartTime;
> >    let originalCurrentTime;
> >  
> >    // Wait a moment so we can confirm the startTime doesn't change (and doesn't
> >    // simply reflect the current time).
> > -  return originalAnimation.ready.then(() => {
> > +  await originalAnimation.ready;
> > +
> > -    originalStartTime = originalAnimation.startTime;
> > +  originalStartTime = originalAnimation.startTime;
> > -    originalCurrentTime = originalAnimation.currentTime;
> > +  originalCurrentTime = originalAnimation.currentTime;
> 
> Nit:
> const originalStartTime =
> const originalCurrentTime =

These and the following are all fixed in subsequent patches so I've left them as-is.

Comment 51

[Brian Birtles (:birtles, Feb 26~ parental leave)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #30)
> Comment on attachment 8982423 [details]
> Bug 1466031 - Update the titles of each test file;
> 
> https://reviewboard.mozilla.org/r/248374/#review254642
> 
> ::: dom/animation/test/css-animations/test_animation-pausing.html:3
> (Diff revision 1)
> >  <!doctype html>
> >  <meta charset=utf-8>
> > +<title>CSSAnimation pausing</title>
> 
> For consistency, this should be 'Pausing a CSSAniamtion'?

Yes.

> ::: dom/animation/test/css-animations/test_effect-target.html:3
> (Diff revision 1)
> >  <!doctype html>
> >  <meta charset=utf-8>
> > +<title>KeyframeEffect.target for CSS Animations</title>
> 
> If this is 'CSSAnimation.effect.target', it would be ambiguous?
> 
> I really prefer 'CSSAnimation.startTime' or some such in this patch, they
> are pretty simple and easy to understand what the test supposes.

Sounds good to me.

Comment 52

[Brian Birtles (:birtles, Feb 26~ parental leave)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #43)
> Comment on attachment 8982443 [details]
> Bug 1466031 - Add spec links to test files;
> 
> https://reviewboard.mozilla.org/r/248412/#review254680
> 
> :::
> testing/web-platform/tests/css/css-animations/CSSAnimation-canceling.
> tentative.html:5
> (Diff revision 1)
> >  <!doctype html>
> >  <meta charset=utf-8>
> >  <title>Canceling a CSS animation</title>
> > +<!-- TODO: Add a more specific link for this one it is specified. -->
> > +<link rel="help" href="https://drafts.csswg.org/css-animations-2/">
> 
> I guess you might have wanted to link
> https://drafts.csswg.org/css-animations-2/#cssanimation ?  It's not a big
> deal though.

I deliberately didn't link to the API there because I suspect we'll end up specifying the canceling behavior apart from the API.

> :::
> testing/web-platform/tests/css/css-animations/CSSAnimation-playState.
> tentative.html:5
> (Diff revision 1)
> >  <!doctype html>
> >  <meta charset=utf-8>
> >  <title>CSSAnimation.playState</title>
> > +<!-- TODO: Add a more specific link for this one it is specified. -->
> > +<link rel="help" href="https://drafts.csswg.org/css-animations-2/#cssanimation">
> 
> I don't quite understand why we can use
> https://drafts.csswg.org/css-animations-2/#animation-play-state ?

Yeah, that's because this test is more about the playState member than about the specific play state handling (which is covered by the "Pausing a CSSAnimation" tests).

> :::
> testing/web-platform/tests/css/css-animations/Document-getAnimations.
> tentative.html:4
> (Diff revision 1)
> >  <!doctype html>
> >  <meta charset=utf-8>
> >  <title>Document.getAnimations() for CSS animations</title>
> > +<link rel="help" href="https://drafts.csswg.org/css-animations-2/#animation-composite-order">
> 
> Is this the correct link?

Yeah, the composite order determines the order in which these animations get returned and this test is all about the ordering so it seems to be the most appropriate place to link to.

Comment 53

[Brian Birtles (:birtles, Feb 26~ parental leave)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #45)
> ::: dom/animation/test/css-animations/test_element-get-animations.html:443
> (Diff revision 1)
> >  
> >    assert_equals(animations[4].effect.target, child2,
> >                  'The animation targeting the child2 element ' +
> >                  'should be returned last');
> >  
> > -}, 'Test AnimationFilter{ subtree: true } with element that has many descendant');
> > +}, '{ subtree: true } on element with many descendants returns animations'
> 
> Nit: 'on an element' for consistency.

Fixed.

Comment 54

[Brian Birtles (:birtles, Feb 26~ parental leave)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #46)
> Comment on attachment 8982432 [details]
> Bug 1466031 - Update test_animation-starttime.html;
> 
> https://reviewboard.mozilla.org/r/248392/#review254688
> 
> ::: dom/animation/test/css-animations/test_animation-starttime.html:69
> (Diff revision 1)
> >    animation.startTime = animation.timeline.currentTime - 100 * MS_PER_SEC;
> >    await eventWatcher.wait_for('animationstart');
> >  
> >    animation.startTime = animation.timeline.currentTime - 200 * MS_PER_SEC;
> >    await eventWatcher.wait_for('animationend');
> > -}, 'Skipping forward through animation');
> > +}, 'Seeking a CSS animation using the start time dispatchs animation events');
> 
> I am not sure this test case should be moved into event-dispath.html or not.

Yes, I wanted to leave one test that ensures that setting the start time does trigger event dispatching for CSS animation events (since I think that's why we added these tests here in the first place).

Comment 55

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Thanks for reviewing these so quickly!

I didn't mean for you to review them on Friday and on PTO! I just thought I'd send them since I know they overlap with some work you are doing (e.g. dropping the EventHandler code) and I thought it would be good for you to know I'd taken care of that in case you started working on it on Monday before I got to work.

I'm going to update the patches now but since I've been using mq for this (touching MANIFEST.json so much) I expect MozReview might fail to match up the r+'s. If so I'll just push to m-i so please review any review spam that comes from this!

Comment 56

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Use arrow functions in dom/animation/test/css-animations/;

Review commit: https://reviewboard.mozilla.org/r/248766/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248766/

Comment 57

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Replace var with const/let in dom/animation/test/css-animations/;

Review commit: https://reviewboard.mozilla.org/r/248768/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248768/

Comment 58

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Use async/await in dom/animation/test/css-animations/;

Review commit: https://reviewboard.mozilla.org/r/248770/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248770/

Comment 59

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Use for ... of instead of forEach in a few places in dom/animation/test/css-animations/;

Review commit: https://reviewboard.mozilla.org/r/248772/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248772/

Comment 60

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Fix the spelling of canceled/canceling in dom/animation/test/css-animations/;

Review commit: https://reviewboard.mozilla.org/r/248774/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248774/

Comment 61

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Update the titles of each test file;

Some of these names will make more sense after the renaming of files towards the
end of this patch series.

Also a couple of files do not have titles added since they will be subsequently
removed.

Review commit: https://reviewboard.mozilla.org/r/248776/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248776/

Comment 62

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Apply various whitespace tweaks to test_animation-computed-timing.html;

Review commit: https://reviewboard.mozilla.org/r/248778/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248778/

Comment 63

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Re-arrange tests in test_animations-currenttime.html;

A number of these tests are redundant with other tests or are otherwise
unnecessary. Other tests should be moved to a more appropriate file.

Some notable examples:

* A number of the tests relate to dispatching events in various phases and have
  been moved to test_event-dispatch.html.
* The "Seeking finished -> paused dispatches animationstart" test is covered
  by the "After -> Active" test in test_event-dispatch.html (which also
  operates on a paused animation).
* The "Animation.currentTime clamping" is really just testing finishing
  behavior and is covered by the updating-the-finished-state.html tests in the
  Web Animations web-platform-tests (specifically the "Updating the finished
  state when playing past end" test).
* Likewise for the "Animation.currentTime clamping for reversed animation"
  test.

Review commit: https://reviewboard.mozilla.org/r/248780/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248780/

Comment 64

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Drop test_animation-finish.html;

These tests are all covered elsewhere:

* The "Test exceptions when finishing infinite animation" test is covered by
  the "Finishing an infinite animation throws" test in
  finishing-an-animation.html in the Web Animations web-platform-tests.
* The "Test finish() while paused" test is covered by the "Finishing a paused
  animation resolves the start time" test in finishing-an-animation.html in
  the Web Animations web-platform-tests.
* The "Test finish() while pause-pending with positive playbackRate" test is
  covered by the "Finishing a pause-pending animation resolves the pending
  task immediately and update the start time" test in
  finishing-an-animation.html in the Web Animations web-platform-tests.
* The 'Test finish() while pause-pending with negative playbackRate" test is
  covered by the "Finishing a pause-pending animation with negative playback
  rate resolves the pending task immediately" test in
  finishing-an-animation.html in the Web Animations web-platform-tests.

In fact, it very much looks like these tests were copied to Web Animations'
web-platform-tests at some point without deleting the original.

Review commit: https://reviewboard.mozilla.org/r/248782/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248782/

Comment 65

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Tidy up test_animation-finished.html;

This mostly just involves using promise_rejects to simplify some test code.

The change to the test description of the last test might seem like it is giving
it the opposite meaning but the original test name was "Test finished promise
changes when animationPlayState set to running"[1], and it is about testing
that there are NO changes but that got lost when the "Test" part of the
description was dropped.


[1] https://searchfox.org/mozilla-central/rev/cb846d13d3f9ec5d38ace93a74f749a18e9c67f5/dom/animation/test/css-animations/test_animation-player-finished.html#287

Review commit: https://reviewboard.mozilla.org/r/248784/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248784/

Comment 66

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Tweak whitespace in test_animation-id.html;

This just makes the grouping a little more clear I think.

Review commit: https://reviewboard.mozilla.org/r/248786/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248786/

Comment 67

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Tidy up test_animations-playstate.html;

Review commit: https://reviewboard.mozilla.org/r/248788/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248788/

Comment 68

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Tidy up test_animation-ready.html;

Although many of these tests are similar to tests in the Web Animations
web-platform-tests test suite they focus on the interaction with
animation-play-state and so are probably worth keeping.

There are two exceptions that I felt were worth changing:

* The test for the handling of a ready promise on an aborted pause. I could not
  find a similar test in the Web Animations wpt and the test is not really
  particular to CSS animations so this patch moves it to Web Animations wpt.

* The test for the resolution value of the ready promise for a paused animation
  is covered by the "A pending ready promise should be resolved and not replaced
  when the animation is paused" in pausing-an-animation.html in the Web
  Animations wpt (although peripherally) and that seems like the better place
  for this test anyway (it is not specific to CSS animations) so I have simply
  deleted it from this file.

Review commit: https://reviewboard.mozilla.org/r/248790/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248790/

Comment 69

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Move the reversing test to Web Animations web-platform-tests;

Review commit: https://reviewboard.mozilla.org/r/248792/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248792/

Comment 70

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Update test_animation-starttime.html;

This patch updates the tests in this file as follows:

* startTime of a newly created (play-pending) animation is unresolved
  -> Covered by 'startTime of a play-pending animation is unresolved'
     in wpt/web-animations/interfaces/Animation/startTime.html

     However, it would be useful to have a test a new CSS animation is
     play-pending so I have extended the test in test_animation-playstate.html
     to cover this.

* startTime of a newly created (pause-pending) animation is unresolved
  -> Covered by 'startTime of a pause-pending animation is unresolved'
     in wpt/web-animations/interfaces/Animation/startTime.html

* startTime is resolved when running
  -> Covered by 'startTime is resolved when running'
     in wpt/web-animations/interfaces/Animation/startTime.html

* startTime is unresolved when paused
  -> Moved to wpt/web-animations/timing-model/animations/pausing-an-animation.html

* startTime while pause-pending and play-pending
  -> Moved to wpt/web-animations/timing-model/animations/pausing-an-animation.html

* startTime while play-pending from finished state,
  startTime while play-pending from finished state using finish()
  -> Merged and moved to wpt/web-animations/timing-model/animations/playing-an-animation.html

* Pausing should make the startTime become null
  -> Simplified and merged into the test for 'startTime is unresolved when
     paused' / 'Pausing clears the start time' test in
     wpt/web-animations/timing-model/animations/pausing-an-animation.html

* Sanity test to check round-tripping assigning to a new animation's startTime
  -> Updated and left.

* Skipping forward through animation
  -> This is really testing two things:
     (a) That you can seek a CSS animation using the start time.
         For this it makes sense to have a separate test that also checks that
         the computed style is updated (like we have for current time).
     (b) That seeking a CSS animation using the start time triggers
         dispatching events.

     This patch splits the above into two separate tests.

* Skipping backwards through animation,
  Redundant change, before -> active, then back,
  Redundant change, before -> after, then back,
  Redundant change, active -> before, then back,
  Redundant change, active -> after, then back,
  Redundant change, after -> before, then back,
  Redundant change, after -> active, then back
  -> All these tests are really just exercising event dispatch which is
     already covered by test_event-dispatch.html.

     Provided we have a test that checks that events are dispatched when
     setting the startTime we don't need to test each combination again since
     we have tests for each of these combinations already when using the
     currentTime to seek and we can assume UAs are following the same code
     path at this point.

     As a result this patch drops these tests.

* Setting startTime to null
  -> Covered by 'Setting an unresolved start time sets the hold time'
     in wpt/web-animations/timing-model/animations/setting-the-start-time-of-an-animation.html

* Animation.startTime after pausing
  -> Covered by the new 'Pausing clears the start time' test in
     wpt/web-animations/timing-model/animations/pausing-an-animation.html

* Animation.startTime after canceling
  -> Merged into
     wpt/web-animations/timing-model/animations/canceling-an-animation.html
     and made it follow the spec a little more closely (which requires
     clearing the start time and hold time).

Review commit: https://reviewboard.mozilla.org/r/248794/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248794/

Comment 71

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Update test_animations-dynamic-changes.html;

Review commit: https://reviewboard.mozilla.org/r/248796/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248796/

Comment 72

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Update test_element-get-animations.html;

As well as addressing a few FIXMEs this patch drops the checking of start times
since that seems out of scope for this file and is covered elsewhere (I believe
we only added it at first to bootstrap this work).

Review commit: https://reviewboard.mozilla.org/r/248798/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248798/

Comment 73

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Update test description in test_pseudoElement-get-animations.html;

Review commit: https://reviewboard.mozilla.org/r/248800/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248800/

Comment 74

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Update test_setting-effect.html;

Apart from whitespace / test description tests this patch also drops an
assertion about the animation playState since it seems unrelated to the purpose
of that particular test.

Review commit: https://reviewboard.mozilla.org/r/248802/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248802/

Comment 75

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Move CSS animations / Web animation integration tests to web-platform-tests;

Review commit: https://reviewboard.mozilla.org/r/248804/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248804/

Comment 76

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Add spec links to test files;

Review commit: https://reviewboard.mozilla.org/r/248806/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248806/

Comment 77

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1466031 - Update event-dispatch test now that we can use the updated EventWatcher;

Review commit: https://reviewboard.mozilla.org/r/248808/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248808/

Comment 78

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Oh, MozReview :(

Comment 79

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/841c624e3daf
Use arrow functions in dom/animation/test/css-animations/; r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/34668c9b0d60
Replace var with const/let in dom/animation/test/css-animations/; r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/814a885cf046
Use async/await in dom/animation/test/css-animations/; r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/2337de0fc6d6
Use for ... of instead of forEach in a few places in dom/animation/test/css-animations/; r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4926e77c345
Fix the spelling of canceled/canceling in dom/animation/test/css-animations/; r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/3bba27064558
Update the titles of each test file; r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/89a749ca3580
Apply various whitespace tweaks to test_animation-computed-timing.html; r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/bdf0455bd3ec
Re-arrange tests in test_animations-currenttime.html; r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8dd07176c5c
Drop test_animation-finish.html; r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/865062de80fb
Tidy up test_animation-finished.html; r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/43b6a7546524
Tweak whitespace in test_animation-id.html; r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f526a64e149
Tidy up test_animations-playstate.html; r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/225a32bacfbc
Tidy up test_animation-ready.html; r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/357a5f2a456b
Move the reversing test to Web Animations web-platform-tests; r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/bfe96f889a3b
Update test_animation-starttime.html; r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/93a6b929c042
Update test_animations-dynamic-changes.html; r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/2181d4e46ec8
Update test_element-get-animations.html; r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/31b0c91a0237
Update test description in test_pseudoElement-get-animations.html; r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7fb7955c589
Update test_setting-effect.html; r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a4aafa588f8
Move CSS animations / Web animation integration tests to web-platform-tests; r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/1156ef220859
Add spec links to test files; r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/d87bf0bd52e2
Update event-dispatch test now that we can use the updated EventWatcher; r=hiro

Comment 80

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/11318 for changes under testing/web-platform/tests

Comment 81

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 82

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/841c624e3daf
https://hg.mozilla.org/mozilla-central/rev/34668c9b0d60
https://hg.mozilla.org/mozilla-central/rev/814a885cf046
https://hg.mozilla.org/mozilla-central/rev/2337de0fc6d6
https://hg.mozilla.org/mozilla-central/rev/e4926e77c345
https://hg.mozilla.org/mozilla-central/rev/3bba27064558
https://hg.mozilla.org/mozilla-central/rev/89a749ca3580
https://hg.mozilla.org/mozilla-central/rev/bdf0455bd3ec
https://hg.mozilla.org/mozilla-central/rev/c8dd07176c5c
https://hg.mozilla.org/mozilla-central/rev/865062de80fb
https://hg.mozilla.org/mozilla-central/rev/43b6a7546524
https://hg.mozilla.org/mozilla-central/rev/4f526a64e149
https://hg.mozilla.org/mozilla-central/rev/225a32bacfbc
https://hg.mozilla.org/mozilla-central/rev/357a5f2a456b
https://hg.mozilla.org/mozilla-central/rev/bfe96f889a3b
https://hg.mozilla.org/mozilla-central/rev/93a6b929c042
https://hg.mozilla.org/mozilla-central/rev/2181d4e46ec8
https://hg.mozilla.org/mozilla-central/rev/31b0c91a0237
https://hg.mozilla.org/mozilla-central/rev/e7fb7955c589
https://hg.mozilla.org/mozilla-central/rev/4a4aafa588f8
https://hg.mozilla.org/mozilla-central/rev/1156ef220859
https://hg.mozilla.org/mozilla-central/rev/d87bf0bd52e2

Comment 83

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged