Intermittent browser/base/content/test/webextensions/browser_extension_update_background_noprompt.js | Addon update_origins@tests.mozilla.org was left installed at the end of the test -

RESOLVED FIXED

Status

defect
P5
normal
RESOLVED FIXED
Last year
7 months ago

People

(Reporter: intermittent-bug-filer, Assigned: rpl)

Tracking

({intermittent-failure})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [stockwell fixed])

Attachments

(2 attachments)

Product: Toolkit → WebExtensions
There are 44 failures asociated to this bug in the last 7 days. These are occurring on windows10-64 opt and linux64 pgo.

:ddurst any updates on this?
Flags: needinfo?(ddurst)
Whiteboard: [stockwell needswork]
In the last 7 days there have been 46 occurrences on Linux 64, Windows 7 and Windows 10 on debug, opt and pgo.
Attachment #9021947 - Flags: review?(jmaher) → review+
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/16b41d40392f
disable browser_extension_update_background_noprompt.js on win and linux for frequent failures r=jmaher
Keywords: checkin-needed

I took a look to a bunch of the failures collected and it seems that the reason for the failure is just that the test wasn't waiting for the test addon to be fully uninstalled and that was triggering a failure once the test was exiting (because the extension was still around when the test was exiting fast enough).

As an additional confirmation (that the test extension was already being uninstalled), on every one of the failures logs that I looked into, the following message was logged right after the failure:

Attempted to remove update_origins@tests.mozilla.org from app-profile but it was already gone

e.g. like in this one: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=221558850&repo=autoland&lineNumber=2373-2374

I was able to trigger the same failure locally (using a debug build and --verify), and the attached patch was able to consistently avoid the failure and complete the "--verify test run" successfully.

Flags: needinfo?(ddurst)
Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/24982570fc83
Fix intermittency issue and re-enabled browser_extension_update_background_noprompt.js test. r=aswan

Marking as "resolved, fixed" and updating the whiteboard field, as this test has been re-enabled by the patch linked in comment 43.

Assignee: ccoroiu → lgreco
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Whiteboard: [stockwell disabled] → [stockwell fixed]
You need to log in before you can comment on or make changes to this bug.