Closed Bug 1466116 Opened 2 years ago Closed Last year

[wpt-sync] Sync PR 11299 - Ensure that Config's set of ports is generated atomically.

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 11299 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11299
Details from upstream follow.

Josh Matthews <josh@joshmatthews.net> wrote:
>  Ensure that Config's set of ports is generated atomically.
>  
>  My theory is that when there are several browsers pointed at the same server, we can end up having two threads that enter the `ports` method simultanesouly, create an empty `old_ports` dictionary, and generate unique ports for any "auto" entries. One of these threads will finish last and overwrite the other thread's results, leading to an inconsistent set of ports between threads.
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd318d9b9a2b
[wpt PR 11299] - Ensure that Config's set of ports is generated atomically., a=testonly
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/943d3d6c55c9
[wpt PR 11299] - Ensure that Config's set of ports is generated atomically., a=testonly
https://hg.mozilla.org/mozilla-central/rev/943d3d6c55c9
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Result changes from PR not available.
You need to log in before you can comment on or make changes to this bug.