Closed Bug 1466124 Opened Last year Closed Last year

Missing new_disabled flag on TestNode in manifestupdate.py

Categories

(Testing :: web-platform-tests, defect)

defect
Not set

Tracking

(firefox62 fixed)

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: jgraham, Assigned: jgraham)

Details

(Keywords: regression)

Attachments

(1 file)

Traceback (most recent call last):
  File "/app/workspace/work/gecko/downstream/11206/testing/web-platform/mach_commands.py", line 140, in run_update
    update.run_update(logger, **kwargs)
  File "/app/workspace/work/gecko/downstream/11206/testing/web-platform/update/__init__.py", line 25, in run_update
    return updater.run()
  File "/app/workspace/work/gecko/downstream/11206/testing/web-platform/tests/tools/wptrunner/wptrunner/update/update.py", line 151, in run
    rv = update_runner.run()
  File "/app/workspace/work/gecko/downstream/11206/testing/web-platform/tests/tools/wptrunner/wptrunner/update/base.py", line 61, in run
    rv = step(self.logger).run(step_index, self.state)
  File "/app/workspace/work/gecko/downstream/11206/testing/web-platform/tests/tools/wptrunner/wptrunner/update/base.py", line 32, in run
    self.create(state)
  File "/app/workspace/work/gecko/downstream/11206/testing/web-platform/tests/tools/wptrunner/wptrunner/update/update.py", line 97, in create
    runner.run()
  File "/app/workspace/work/gecko/downstream/11206/testing/web-platform/tests/tools/wptrunner/wptrunner/update/base.py", line 61, in run
    rv = step(self.logger).run(step_index, self.state)
  File "/app/workspace/work/gecko/downstream/11206/testing/web-platform/tests/tools/wptrunner/wptrunner/update/base.py", line 32, in run
    self.create(state)
  File "/app/workspace/work/gecko/downstream/11206/testing/web-platform/tests/tools/wptrunner/wptrunner/update/metadata.py", line 37, in create
    stability=state.stability)
  File "/app/workspace/work/gecko/downstream/11206/testing/web-platform/tests/tools/wptrunner/wptrunner/metadata.py", line 76, in update_expected
    if test.new_disabled:
AttributeError: 'TestNode' object has no attribute 'new_disabled'


This is a regression from Bug 1265584
Comment on attachment 8982522 [details]
Bug 1466124 - Readd new_disabled flag on expectation manifest root,

https://reviewboard.mozilla.org/r/248510/#review254776
Attachment #8982522 - Flags: review?(mjzffr) → review+
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/autoland/rev/1fbf7e0d341d
Readd new_disabled flag on expectation manifest root, r=maja_zf
https://hg.mozilla.org/mozilla-central/rev/1fbf7e0d341d
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Assignee: nobody → james
Version: Version 3 → Trunk
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/11805 for changes under testing/web-platform/tests
Upstream PR merged
You need to log in before you can comment on or make changes to this bug.