1466139 - Devtools failures on browser_telemetry_sidebar.js when Gecko 62 merges to Beta on 14-06-2018

Status: VERIFIED FIXED

(DevTools :: Inspector, defect)

Description

[Cosmin Sabou [:CosminS]]

Central as beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=86bd65f4193bb4d637ef137f0a07dd404bc8abbe&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-searchStr=devtools&selectedJob=181332089

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=181332089&repo=try&lineNumber=2722

[task 2018-06-01T12:19:49.753Z] 12:19:49     INFO - TEST-UNEXPECTED-FAIL | devtools/client/shared/test/browser_telemetry_sidebar.js | newpanel is correct - Got animationinspector, expected fontinspector
[task 2018-06-01T12:19:49.754Z] 12:19:49     INFO - Stack trace:
[task 2018-06-01T12:19:49.755Z] 12:19:49     INFO - chrome://mochikit/content/browser-test.js:test_is:1285
[task 2018-06-01T12:19:49.757Z] 12:19:49     INFO - chrome://mochitests/content/browser/devtools/client/shared/test/browser_telemetry_sidebar.js:checkEventTelemetry:165
[task 2018-06-01T12:19:49.761Z] 12:19:49     INFO - chrome://mochitests/content/browser/devtools/client/shared/test/browser_telemetry_sidebar.js:null:100
[task 2018-06-01T12:19:49.762Z] 12:19:49     INFO - TEST-PASS | devtools/client/shared/test/browser_telemetry_sidebar.js | timestamp is greater than 0 - 
[task 2018-06-01T12:19:49.762Z] 12:19:49     INFO - TEST-PASS | devtools/client/shared/test/browser_telemetry_sidebar.js | category is correct - 
[task 2018-06-01T12:19:49.763Z] 12:19:49     INFO - TEST-PASS | devtools/client/shared/test/browser_telemetry_sidebar.js | method is correct - 
[task 2018-06-01T12:19:49.767Z] 12:19:49     INFO - TEST-PASS | devtools/client/shared/test/browser_telemetry_sidebar.js | object is correct - 
[task 2018-06-01T12:19:49.768Z] 12:19:49     INFO - TEST-PASS | devtools/client/shared/test/browser_telemetry_sidebar.js | value is correct - 
[task 2018-06-01T12:19:49.769Z] 12:19:49     INFO - Not taking screenshot here: see the one that was previously logged

This looks like a regression from https://bugzilla.mozilla.org/show_bug.cgi?id=1463083

https://hg.mozilla.org/integration/autoland/rev/375638c8a433

Comment 1

[Intermittent Failures Robot]

34 failures in 655 pushes (0.052 failures/push) were associated with this bug in the last 7 days. 

This is the #43 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* try: 34

Platform breakdown:
* linux64: 8
* macosx64-devedition: 4
* linux64-nightly: 4
* osx-10-10: 3
* linux64-devedition: 3
* linux32-nightly: 3
* linux32-devedition: 3
* linux32: 3
* windows7-32-nightly: 1
* windows7-32: 1
* windows10-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1466139&startday=2018-05-28&endday=2018-06-03&tree=trunk

Comment 2

[Intermittent Failures Robot]

39 failures in 99 pushes (0.394 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* try: 39

Platform breakdown:
* windows10-64: 6
* linux64: 6
* windows10-64-devedition: 4
* windows7-32-nightly: 2
* windows7-32-devedition: 2
* windows10-64-nightly: 2
* osx-10-10: 2
* macosx64-devedition: 2
* macosx64-ccov: 2
* linux64-nightly: 2
* linux64-devedition: 2
* linux32-nightly: 2
* linux32-devedition: 2
* linux32: 2
* windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1466139&startday=2018-06-04&endday=2018-06-04&tree=trunk

Comment 3

[Intermittent Failures Robot]

40 failures in 50 pushes (0.8 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* try: 40

Platform breakdown:
* windows10-64: 6
* linux64: 6
* osx-10-10: 4
* windows7-32-nightly: 2
* windows7-32-devedition: 2
* windows7-32: 2
* windows10-64-nightly: 2
* windows10-64-devedition: 2
* macosx64-nightly: 2
* macosx64-devedition: 2
* linux64-nightly: 2
* linux64-devedition: 2
* linux32-nightly: 2
* linux32-devedition: 2
* linux32: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1466139&startday=2018-06-09&endday=2018-06-09&tree=trunk

Comment 4

[Intermittent Failures Robot]

118 failures in 669 pushes (0.176 failures/push) were associated with this bug in the last 7 days. 

This is the #5 most frequent failure this week.   

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. ** 

Repository breakdown:
* try: 118

Platform breakdown:
* linux64: 17
* windows10-64: 16
* osx-10-10: 12
* macosx64-devedition: 8
* windows7-32-nightly: 7
* windows10-64-devedition: 7
* linux64-nightly: 6
* linux64-devedition: 6
* linux32-nightly: 6
* linux32-devedition: 6
* linux32: 6
* windows7-32-devedition: 5
* windows10-64-nightly: 5
* macosx64-nightly: 5
* windows7-32: 4
* macosx64-ccov: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1466139&startday=2018-06-04&endday=2018-06-10&tree=trunk

Comment 5

[Intermittent Failures Robot]

27 failures in 41 pushes (0.659 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* try: 27

Platform breakdown:
* osx-10-10: 4
* linux64: 4
* windows10-64: 3
* macosx64-nightly: 2
* macosx64-devedition: 2
* linux64-devedition: 2
* linux32-nightly: 2
* linux32: 2
* windows7-32-nightly: 1
* windows7-32-devedition: 1
* windows7-32: 1
* windows10-64-devedition: 1
* linux64-nightly: 1
* linux32-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1466139&startday=2018-06-11&endday=2018-06-11&tree=trunk

Comment 6

[Intermittent Failures Robot]

21 failures in 66 pushes (0.318 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* try: 21

Platform breakdown:
* windows10-64: 3
* linux64: 3
* osx-10-10: 2
* macosx64-devedition: 2
* windows7-32-nightly: 1
* windows7-32-devedition: 1
* windows7-32: 1
* windows10-64-nightly: 1
* windows10-64-devedition: 1
* macosx64-nightly: 1
* linux64-nightly: 1
* linux64-devedition: 1
* linux32-nightly: 1
* linux32-devedition: 1
* linux32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1466139&startday=2018-06-12&endday=2018-06-12&tree=trunk

Comment 7

[Andreea Pavel [:apavel]]

:miker hi, can you please take a look at this?

Comment 8

[Intermittent Failures Robot]

56 failures in 408 pushes (0.137 failures/push) were associated with this bug in the last 7 days. 

This is the #7 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* try: 56

Platform breakdown:
* windows10-64: 8
* linux64: 8
* osx-10-10: 7
* macosx64-devedition: 6
* macosx64-nightly: 4
* windows7-32: 3
* linux64-devedition: 3
* linux32-nightly: 3
* linux32: 3
* windows7-32-nightly: 2
* windows7-32-devedition: 2
* windows10-64-devedition: 2
* linux64-nightly: 2
* linux32-devedition: 2
* windows10-64-nightly: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1466139&startday=2018-06-11&endday=2018-06-17&tree=trunk

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1466139 - set animation panel ID depending on devtools.new-animationinspector.enabled.

Review commit: https://reviewboard.mozilla.org/r/251394/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/251394/

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Successful Beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c64bf16be7f3f13cab9fa0716b801c247b6b32fd&group_state=expanded

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Comment on attachment 8985902 [details]
Bug 1466139 - set animation panel ID depending on devtools.new-animationinspector.enabled.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/251394/diff/1-2/

Comment 12

[Yulia Startsev [:yulia]]

Comment on attachment 8985902 [details]
Bug 1466139 - set animation panel ID depending on devtools.new-animationinspector.enabled.

https://reviewboard.mozilla.org/r/251394/#review258164

::: devtools/client/shared/test/browser_telemetry_sidebar.js:15
(Diff revision 2)
>  // Because we need to gather stats for the period of time that a tool has been
>  // opened we make use of setTimeout() to create tool active times.
>  const TOOL_DELAY = 200;
>  
> +var animationPanelId;
> +if (Services.prefs.getBoolPref("devtools.new-animationinspector.enabled")) {

thanks for catching this. I noticed that the test is not setting the bool -- are we testing both branches or is this set by default somewhere? If this isn't known at the moment we can do a follow up, just want to check

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The pref is set in devtools-client.js https://dxr.mozilla.org/mozilla-central/rev/e429320fcdd2d5236bb4713e6c435456146e42b9/devtools/client/preferences/devtools-client.js#65-69
Nightly uses the new one, beta and release the old one until the new one rides the trains. No branch tests with both pref values.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c5bd07226ca
set animation panel ID depending on devtools.new-animationinspector.enabled. r=yulia

Comment 15

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1c5bd07226ca

Comment 16

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed in recent beta simulations: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ab490786fd29454fab7bc274a5248d9bd462dd6&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable

Comment 17

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8985902 [details]
Bug 1466139 - set animation panel ID depending on devtools.new-animationinspector.enabled.

https://reviewboard.mozilla.org/r/251394/#review263620

Well spotted, r+.