Closed Bug 1466155 Opened 6 years ago Closed 5 years ago

Remove unused labels in CacheIRCompiler::emitGuardIsInt32

Categories

(Core :: JavaScript Engine: JIT, enhancement, P3)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: mgaudet, Assigned: championshuttler, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Bug 1466155 - Remove unused labels in CacheIRCompiler::emitGuardIsInt32. r=tcampbell
47 bytes, text/x-phabricator-request
Details | Review 
CacheIRCompiler::emitIsInt32 has two unused label variables: 

https://searchfox.org/mozilla-central/rev/38bcf897f1fa19c1eba441a611cf309482e0d6e5/js/src/jit/CacheIRCompiler.cpp#1376

They can safely be removed.
Hey Matthew,

I would like work on this bug. I understand that the line pointed out by you needs to be removed, I am currently building the source, I will upload the patch once I have built Firefox.

Regards,
Abhishek [:avp]
Assignee: nobody → abhishekp.bugzilla
Status: NEW → ASSIGNED
Hi @Abhishek are you working on it? If not can i work on it?

Thanks
Flags: needinfo?(abhishekp.bugzilla)
Assignee: abhishekp.bugzilla → shivams2799
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d70fba3550b4
Remove unused labels in CacheIRCompiler::emitGuardIsInt32. r=tcampbell
https://hg.mozilla.org/mozilla-central/rev/d70fba3550b4
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Flags: needinfo?(abhishekp.bugzilla)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: