1466200 - Remove speedometer support from Talos

Status: RESOLVED FIXED

(Testing :: Talos, task, P3)

Description

[Robert Wood [:rwood]]

Once speedometer is up and running on Raptor in production on all platforms, remove the talos-specific code (i.e. 'gecko?' etc/) from the speedometer source (third_party/...).

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

There are no longer any production jobs running speedometer in Talos, so let's clean up the code and remove the support to run this locally. We can also take care of the Talos specific changes to the third_party speedometer code.

Comment 2

[Hamzah Akhtar]

Which are the files associated with the bug?

Comment 3

[Robert Wood [:rwood]]

(In reply to Hamzah Akhtar from comment #2)

Which are the files associated with the bug?

First step is to learn more about Talos, please see the wiki [0] and [1].

The speedometer source can be found here [2]. This source is used by both talos and raptor so we need to keep the source, however the talos-specific code can be removed. Talos-specific code is only in one file in the speedometer source [3] (the '?gecko' url param, and the tpRecordTime method call are talos specific).

The speedometer test definition and test manifest and other speedometer-specific code can be removed from talos itself [4] and [5], as well as the taskcluster configuration files [6] and [7] which add the ability to schedule the talos speedometer test in our CI but is no longer necessary.

[0] https://wiki.mozilla.org/Performance_sheriffing/Talos

[1] https://wiki.mozilla.org/Performance_sheriffing/Talos/Tests#speedometer

[2] https://searchfox.org/mozilla-central/source/third_party/webkit/PerformanceTests/Speedometer

[3] https://searchfox.org/mozilla-central/source/third_party/webkit/PerformanceTests/Speedometer/resources/benchmark-report.js

[4] https://searchfox.org/mozilla-central/rev/40e889be8ff926e32f7567957f4c316f14f6fbef/testing/talos/talos.json#56

[5] https://searchfox.org/mozilla-central/source/testing/talos/talos/tests/speedometer

[6] https://searchfox.org/mozilla-central/rev/40e889be8ff926e32f7567957f4c316f14f6fbef/taskcluster/ci/test/talos.yml#327

[7] https://searchfox.org/mozilla-central/source/taskcluster/ci/test/test-sets.yml

Comment 4

[Hamzah Akhtar]

Attachment: Bug 1466200 - Remove speedometer support from Talos

...from TalosBug 1466220 - Remove speedometer support from TalosBug 1466220 - Remove speedometer support from TalosBug 1466220 - Remove speedometer support from TalosBug 1466220 - Remove speedometer support from TalosBug 1466220 - Remove speedometer support from TalosBug 1466220 - Remove speedometer support from TalosBug 1466220 - Remove speedometer support from TalosBug 1466220 - Remove speedometer support from TalosBug 1466220 - Remove speedometer support from Talos

Comment 5

[Robert Wood [:rwood]]

Pushed to try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5f8bca1342866cd5d510bd07bdc5c21d9be22462

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c26864bb07d
Remove speedometer support from Talos r=rwood,davehunt,perftest-reviewers

Comment 7

[Robert Wood [:rwood]]

Thanks for the patch Hamzah!

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/9c26864bb07d