Status
()
People
(Reporter: mats, Assigned: masayuki)
Tracking
({leave-open})
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(22 attachments)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
Follow-up from bug 1430813 comment #21: > PresShell::HandleEvent is a horrible mess. > Here we might reassign 'frame' to the root frame of some shell ancestor: > https://searchfox.org/mozilla-central/rev/a30a60eadcff99d2a043241955d215dbeccad876/layout/base/PresShell.cpp#6911 > but the rest of HandleEvent quite happily continues to use 'this' > to access members etc. > > The IME block at the end for example makes the assumption that > 'frame' belongs to 'this': > https://searchfox.org/mozilla-central/rev/a30a60eadcff99d2a043241955d215dbeccad876/layout/base/PresShell.cpp#7268 > It even assigns mCurrentEventFrame = frame which is clearly > a recipe for disaster (exploitable UAFs). Although the code lives under layout/ it seems this code is mostly doing event handling / IME, so I'm assuming DOM Events is appropriate.
Updated•9 months ago
|
(Reporter) | ||
Comment 1•6 months ago
|
||
This bug is scary. Can we find an owner for it please?
(Assignee) | ||
Comment 2•6 months ago
|
||
(In reply to Mats Palmgren (:mats) from comment #1) > This bug is scary. Can we find an owner for it please? I'd like to work on this when I have much time. Do you think when should we fix this by? (FYI: I'm working on redesigning editor for InputEvent.inputType and beforeinput event. Therefore, I don't have much time at least for a couple of months.)
Comment 3•6 months ago
|
||
(For comment 2. I agree that Masayuki would be great for this, assuming timelines align.)
(Assignee) | ||
Comment 5•a month ago
|
||
I think that it is really risky method to change. So, we should fix this bug slowly for detecting regressions.
(Assignee) | ||
Comment 6•a month ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f3e19e496ba8cff3694a109531df9273fae22dec
(Assignee) | ||
Comment 7•a month ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e71982973369495dde0d280d790ab62b56a897b
(Assignee) | ||
Comment 8•a month ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d045d68076e62557a54633b18ace3e2e79316111
(Assignee) | ||
Comment 9•a month ago
|
||
Well, I was thinking that the best solution is to split each block in HandleEvent() and HandleEventInternal() to methods of PresShell. However, this approach makes too many small methods into PresShell. And badly, some of them may be designed only for specific situations and need to take caller's local variables.
PresShell is a class not only for event handling. So, for grouping event handling helpers, I think that we should create a nexted stack based class called EventHandler
and HandleEvent() should use it. Then, methods can share some variables with members.
Comment 10•a month ago
|
||
I think I like that approach. It could lead to quite elegant code.
(Assignee) | ||
Comment 11•a month ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c6f9cc1ea88cec9ac9a1850a8746626f4a490370
(Assignee) | ||
Comment 12•a month ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=27c0ae1d079f9d92c50921f3ec44ab4d50951aff
(Assignee) | ||
Comment 13•a month ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=39af5b6e26e5b15de5aec39a5ac4c1563d5e14c7
(Assignee) | ||
Comment 14•a month ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac0454f269aba3e1e2b4ca53182bb4bc8d564049
(Assignee) | ||
Comment 15•a month ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=85b138c9351e71a294c10dd7411bf23247a26a9a
(Assignee) | ||
Comment 16•a month ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cdf2a0f3b4f2351e78809472444bdca1e51fc270
(Assignee) | ||
Comment 17•a month ago
|
||
Created attachment 9037501 [details]
Bug 1466208 - part 1: Create stack class to handle events in PresShell
PresShell::HandleEvent() and PresShell::HandleEventInternal() are too big.
Additionally, we have a lot of methods used only by them. So, if we'll
split those big methods, PresShell will have a lot of small methods which
are not grouped as a part of event handling. That's too bad because some
of them may depend on the calling order, etc.
So, for grouping them, PresShell should create a stack class instance to handle
each event. Then, we can store shared information in it only while we're
handling an event.
This patch creates PresShell::EventHandler and PresShell methods become
wrappers of the stack class, but this patch does not change any logic in the
code, i.e., just reorganizing existing methods.
Note that HandleEventWithTarget() and HandleEventInternal() need to take
WidgetEvent rather than WidgetGUIEvent. Additionally, some other methods
require WidgetGUIEvent to refer WidgetGUIEvent::mWidget. Therefore, this
patch does not make the new class store the event as a member.
(Assignee) | ||
Comment 18•a month ago
|
||
Created attachment 9037502 [details]
Bug 1466208 - part 2: Create PresShell::EventHandler::MaybeHandleEventWithAccessibleCaret() to handle event with AccessbleCaretEventHub
PresShell::EventHandler::HandleEvent() is too big. That makes us difficult to
understand the flow of them. So, first of all, we should split the method to
smaller chunks. Then, we can understand what we're doing in HandleEvent() more.
This patch creates MaybeHandleEventWithAccessibleCaret() for first handling
block in HandleEvent(). Note that the following patch will clean it up.
I.e., this patch just moves the existing block into the new method.
(Assignee) | ||
Comment 19•a month ago
|
||
Created attachment 9037505 [details]
Bug 1466208 - part 3: Rewrite PresShell::EventHandler::MaybeHandleEventWithAccessibleCaret() with early-return style
Because of spinning out from PresShell::EventHandler::HandleEvent(), we can use
early-return style in MaybeHandleEventWithAccessibleCaret(). This patch
rewrites MaybeHandleEventWithAccessibleCaret() with the style.
(Assignee) | ||
Comment 20•a month ago
|
||
Created attachment 9037506 [details]
Bug 1466208 - part 4: Create PresShell::EventHandler::GetCapturingContentFor() to retrieve capturing content for specific event
PresShell::HandleEvent() treats capturing content only when received event is
related to pointing device. And it's used in 2 purposes. One is for computing
to target document of coming event. The other is for handling events using
coordinates. Therefore, if we create a helper method to retrieve it, we can
move the variable into smaller blocks.
(Assignee) | ||
Comment 21•a month ago
|
||
Created attachment 9037509 [details]
Bug 1466208 - part 5: Create PresShell::EventHandler::GetRetargetEventDocument() retrieve retarget document of coming event
In some cases, PresShell::EventHandler::HandleEvent() needs to call
HandleEvent() of another instance.
For retrieving the instance, we need to compute retarget document first.
This patch makes new method to retrieve it. The following patch will clean
up it.
(Assignee) | ||
Comment 22•a month ago
|
||
Created attachment 9037511 [details]
Bug 1466208 - part 6: Clean up PresShell::EventHandler::GetRetargetEventDocument()
(Assignee) | ||
Comment 23•a month ago
|
||
Created attachment 9037512 [details]
Bug 1466208 - part 7: Create PresShell::EventHandler::GetFrameForHandlingEventWith() to retrieve a frame which is necessary to handle event with another PresShell instance
Next, we need to look for a frame for first parameter of calling
PresShell::HandleEvent() of another PresShell instance. This patch creates
PresShell::EventHandler::GetFrameForHandlingEventWith() to do it.
Unfortunately, the result is used in 3 patterns. One is, the caller should
stop handling the event. Another one is, the caller should keep handling
the event by itself. The other is, the caller should call
PresShell::HandleEvent() of different PresShell instance. Therefore, this
patch makes the method take aFrame of the caller. Then, the caller can check
the last 2 patterns with check the result is same as aFrame. This is not so
smart approach, but I have no better idea without adding a bool argument or
making the return type bool and adding out argument of nsIFrame.
(Assignee) | ||
Comment 24•a month ago
|
||
Created attachment 9037513 [details]
Bug 1466208 - part 8: Clean up PresShell::EventHandler::GetFrameForHandlingEventWith()
(Assignee) | ||
Comment 25•a month ago
|
||
Created attachment 9037515 [details]
Bug 1466208 - part 9: Create PresShell::EventHandler::MaybeHandleEventWithAnotherPresShell() to handle event with another PresShell if necessary
Let's move the redirection of coming event in
PresShell::EventHandler::HandleEvent() into a method. This makes the caller
easier to read.
(Assignee) | ||
Comment 26•a month ago
|
||
Created attachment 9037516 [details]
Bug 1466208 - part 10: Create PresShell::EventHandler::MaybeDiscardEvent() to check whether it's safe to handle the event
It may not be safe to handle events even when
PresShell::EventHandler::HandleEvent(). In such case, we need to discard
received events with notifying somebody. This patch move this rare case
jobs into the new method, MaybeDiscardEvent(). Then, the caller, HandleEvnet(),
becomes easier to read.
(Assignee) | ||
Comment 27•a month ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0aeaa6c830bad2078df9469c3856a8e58d7e02b4
(Assignee) | ||
Comment 28•a month ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d8d00382e2da27d9861c0ce96cfd51597dd9482
(Assignee) | ||
Comment 29•26 days ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=51b5293e59d136fbb9161bd5db8f73065f90b294
Comment 30•26 days ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/66c3b5b15c8e part 1: Create stack class to handle events in PresShell r=smaug
Comment 31•26 days ago
|
||
bugherder |
(Assignee) | ||
Comment 32•26 days ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=681b23e26402ae5861928ff8b2cec3402c36c78f
Comment 33•26 days ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/8b7c7e0317ef part 2: Create PresShell::EventHandler::MaybeHandleEventWithAccessibleCaret() to handle event with AccessbleCaretEventHub r=smaug
Comment 34•25 days ago
|
||
bugherder |
(Assignee) | ||
Comment 35•25 days ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ee7c21360d5b51e194039626e1ff9e46a0951e8e
Comment 36•25 days ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/c650507f7fee part 3: Rewrite PresShell::EventHandler::MaybeHandleEventWithAccessibleCaret() with early-return style r=smaug
(Assignee) | ||
Comment 37•25 days ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4ce30ac236c687242d5707f4bbc9c21f1e43249
Comment 38•25 days ago
|
||
bugherder |
Comment 39•25 days ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/9d38de19e569 part 4: Create PresShell::EventHandler::GetCapturingContentFor() to retrieve capturing content for specific event r=smaug
Comment 40•24 days ago
|
||
bugherder |
(Assignee) | ||
Comment 41•24 days ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc12fba77e15a27960e4ef2bdb50ac75b82c8228
(Assignee) | ||
Comment 42•24 days ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7276db69abb703639acfaf648064652526203016
Comment 43•24 days ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/7e9c7b742cb9 part 5: Create PresShell::EventHandler::GetRetargetEventDocument() retrieve retarget document of coming event r=smaug
Comment 44•24 days ago
|
||
bugherder |
(Assignee) | ||
Comment 45•24 days ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9bc3dd03f8f4a2fbc8866cf6b688910afa093d46
Comment 46•24 days ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/646991effcda part 6: Clean up PresShell::EventHandler::GetRetargetEventDocument() r=smaug
(Assignee) | ||
Comment 47•24 days ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4da405ee8d118dd5a1b605e96e4767613681dc97
Comment 48•23 days ago
|
||
bugherder |
(Assignee) | ||
Comment 49•23 days ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f2b49f3ed0327002885b1f8238035d04eba2824
Comment 50•23 days ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/e7930893f8f0 part 7: Create PresShell::EventHandler::GetFrameForHandlingEventWith() to retrieve a frame which is necessary to handle event with another PresShell instance r=smaug
Comment 51•23 days ago
|
||
bugherder |
Comment 52•23 days ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/ea7d56b00394 part 8: Clean up PresShell::EventHandler::GetFrameForHandlingEventWith() r=smaug
Comment 53•22 days ago
|
||
bugherder |
(Assignee) | ||
Comment 54•22 days ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e06d2f0093f58c1880c721b841cc8d74a8c2d2b1
(Assignee) | ||
Comment 55•22 days ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a1238e37ac2a071567747c7061286db11916371
Comment 56•21 days ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/1d868390c454 part 9: Create PresShell::EventHandler::MaybeHandleEventWithAnotherPresShell() to handle event with another PresShell if necessary r=smaug
Comment 57•21 days ago
|
||
bugherder |
Comment 58•21 days ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/8d612e0b0258 part 10: Create PresShell::EventHandler::MaybeDiscardEvent() to check whether it's safe to handle the event r=smaug
Comment 59•20 days ago
|
||
bugherder |
(Assignee) | ||
Comment 60•20 days ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d1d7f57b2bc56fe7e9f25dfa993447c28147ed72
(Assignee) | ||
Comment 61•20 days ago
|
||
Created attachment 9041099 [details]
Bug 1466208 - part 11: Create PresShell::EventHandler::MaybeDiscardOrDelayKeyboardEvent()
PresShell::EventHandler::HandleEvent() discards or puts off to dispatch
the handling event if it's a keyboard event and event dispatching is
suppressed by the document.
This patch moves the block into the new method for making HandleEvent() simpler.
(Assignee) | ||
Comment 62•20 days ago
|
||
Created attachment 9041100 [details]
Bug 1466208 - part 12: Get rid of frame
variable from PresShell::EventHandler::HandleEvent()
There is an unclear variable frame
in PresShell::EventHandler::HandleEvent().
It's overwritten with different frame and its meanings is changed sometimes.
Finally, it's necessary only in the if (aGUIEvent->IsUsingCoordinates())
block. Therefore, we can move it into the block and rename it when them for
each purpose.
(Assignee) | ||
Comment 63•20 days ago
|
||
Created attachment 9041101 [details]
Bug 1466208 - part 13: Create PresShell::EventHandler::MaybeFlushThrottledStyles()
PresShell::EventHandler::HandleEvent() tries to flush pending animation first
when it decides frame to handle events using coordinates. This patch moves
the code into the new method.
(Assignee) | ||
Comment 64•20 days ago
|
||
Created attachment 9041103 [details]
Bug 1466208 - part 14: Create PresShell::EventHandler::ComputeRootFrameToHandleEvent()
In some reasons, handling event should be handled in specific frame even if
the coordinates are out of the frame. PresShell::EventHandler::HandleEvent()
computes it with popups, capturing content, etc. This patch moves the blocks
into new method for making HandleEvent() simpler.
Note that most of the code is just moved. The following patch will clean it
up.
(Assignee) | ||
Comment 65•20 days ago
|
||
Created attachment 9041105 [details]
Bug 1466208 - part 15: Split PresShell::EventHandler::ComputeRootFrameToHandleEvent()
PresShell::EventHandler::ComputeRootFrameToHandleEvent() computes root frame
to handle event with popup frame and/or capturing content. The former result
can be rewritten with the latter. So, for cleaning it up with early return
style, we need to split it to 2 methods.
(Assignee) | ||
Comment 66•20 days ago
|
||
Created attachment 9041106 [details]
Bug 1466208 - part 16: Clean up PresShell::EventHandler::ComputeRootFrameToHandleEvent() and its helper methods with early-return style
(Assignee) | ||
Comment 67•17 days ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=91dfdbdede5fafb84097e2abb7494c7b6668d7bd
Updated•17 days ago
|
(Assignee) | ||
Comment 68•17 days ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e7c6fdd0989ba264258224bd32b83fe3ea7741b4
Comment 69•17 days ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/7fd1b72f66c0 part 11: Create PresShell::EventHandler::MaybeDiscardOrDelayKeyboardEvent() r=smaug
Comment 70•17 days ago
|
||
bugherder |
Comment 71•17 days ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/d8420442ba89 part 12: Get rid of `frame` variable from PresShell::EventHandler::HandleEvent() r=smaug
Comment 72•16 days ago
|
||
bugherder |
(Assignee) | ||
Comment 73•16 days ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e170eeadd50fd6e22092c2e619c2046f329cce6d
(Assignee) | ||
Comment 74•16 days ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e7276fd9b8354035ce4c43327834e20ce40dbc63
Comment 75•16 days ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/da71b4d4ad40 part 13: Create PresShell::EventHandler::MaybeFlushThrottledStyles() r=smaug
Comment 76•16 days ago
|
||
bugherder |
Comment 77•16 days ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/546288d07c7c part 14: Create PresShell::EventHandler::ComputeRootFrameToHandleEvent() r=smaug
Comment 78•16 days ago
|
||
bugherder |
(Assignee) | ||
Comment 79•15 days ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f3282d059aa48323d476cf8ce7c572fe9683670
(Assignee) | ||
Comment 80•15 days ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=edae943c21dee3ec682a068d87e5cae9e49b0711
Comment 81•15 days ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/41be96f0dbbb part 15: Split PresShell::EventHandler::ComputeRootFrameToHandleEvent() r=smaug
Comment 82•15 days ago
|
||
bugherder |
Comment 83•14 days ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/b79d7da6617b part 16: Clean up PresShell::EventHandler::ComputeRootFrameToHandleEvent() and its helper methods with early-return style r=smaug
(Assignee) | ||
Comment 84•14 days ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3472bb3a9c50507ce0f33646ec1d9eb6f65e871a
(Assignee) | ||
Comment 85•14 days ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7b44755c3153259215a2be78daf3997564cf4a16
Comment 86•14 days ago
|
||
bugherder |
(Assignee) | ||
Comment 87•14 days ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cdc27350d5389d998e1b9873288d353be2987abb
(Assignee) | ||
Comment 88•14 days ago
|
||
Created attachment 9042806 [details]
Bug 1466208 - part 17: Make PresShell::EventHandler::HandleEventWithPointerCapturingContentWithoutItsFrame() to handle event when there is pointer capturing content but it does not have primary frame
This patch splits the part handling event when there is pointer capturing
content but it does not have frame.
(Assignee) | ||
Comment 89•14 days ago
|
||
Created attachment 9042807 [details]
Bug 1466208 - part 18: Create PresShell::EventHandler::MaybeDiscardOrDelayMouseEvent()
This patch moves the block, which discard or put the event into the delayed event
queue if handling event is a mouse event, to new method.
(Assignee) | ||
Comment 90•13 days ago
|
||
Created attachment 9042851 [details]
Bug 1466208 - part 19: Group PresShell, nsIFrame and nsIContent with a struct
PresShell::EventHandler::HandleEvent() looks for PresShell, nsIFrame and
nsIContent a lot for aGUIEvent. Sometimes part of them are modified,
otherwise, all of them are modified by some reasons. Therefore, for
splitting each of the modifiers into separated methods, we need a struct
for making them as a group and usable for in/out parameter.
(If you have some ideas of better name, let me know.)
(Assignee) | ||
Comment 91•13 days ago
|
||
Created attachment 9042852 [details]
Bug 1466208 - part 20: Create PresShell::EventHandler::EventTargetData::MaybeRetargetToActiveDocument()
Now, we can create methods to update event target into EventTargetData().
This moves a block in PresShell::EventHandler::HandleEvent() to retarget
to active document into the new method.
(Assignee) | ||
Comment 92•13 days ago
|
||
Created attachment 9042853 [details]
Bug 1466208 - part 21: Clean up PresShell::EventHandler::EventTargetData::MaybeRetargetToActiveDocument() with early-return style
(Assignee) | ||
Comment 93•13 days ago
|
||
Created attachment 9042854 [details]
Bug 1466208 - part 22: Create PresShell::EventHandler::EventTargetData::ComputeElementFromFrame()
This patch moves the block to compute event target of the event using
coordinates into the new method of PresShell::EventHandler::EventTargetData.
Comment 94•12 days ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/d8ad6016347f part 17: Make PresShell::EventHandler::HandleEventWithPointerCapturingContentWithoutItsFrame() to handle event when there is pointer capturing content but it does not have primary frame r=smaug
Comment 95•12 days ago
|
||
bugherder |
Comment 96•12 days ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/d70e9638ff75 part 18: Create PresShell::EventHandler::MaybeDiscardOrDelayMouseEvent() r=smaug
Comment 97•12 days ago
|
||
bugherder |
Comment 98•11 days ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/86b52991b24a part 19: Group PresShell, nsIFrame and nsIContent with a struct r=smaug
![]() |
||
Comment 99•11 days ago
|
||
bugherder |
Comment 100•9 days ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/1bcbf6ebcd45 part 20: Create PresShell::EventHandler::EventTargetData::MaybeRetargetToActiveDocument() r=smaug
Comment 101•9 days ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/4cb13cbe5f05 part 21: Clean up PresShell::EventHandler::EventTargetData::MaybeRetargetToActiveDocument() with early-return style r=smaug
Comment 102•8 days ago
|
||
bugherder |
Comment 103•8 days ago
|
||
bugherder |
Comment 104•6 days ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/4a53016221d4 part 22: Create PresShell::EventHandler::EventTargetData::ComputeElementFromFrame() r=smaug
Comment 105•6 days ago
|
||
bugherder |
Description
•