1466251 - Make sure we reject FontFace.loaded if font loading times out

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P2)

Description

[Jonathan Watt [:jwatt]]

Bug 1465983 changes document.fonts.ready so that it is no longer initialized as soon as it's created. It now has to rely on the font loading code to actually resolve/reject it as appropriate. It turns out that code is broken though, and a bunch of tests time out with the patch in that bug. Before we can land that patch we'll need to fix the font loading code.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

I'm not sure who I should get to review this. Cameron/Lee/Jonathan would any of you feel this is something you could review?

Comment 3

[Jonathan Watt [:jwatt]]

Comment on attachment 8982699 [details] [diff] [review]
patch

This is necessary to get at least testing/web-platform/tests/css/css-fonts/font-display/font-display-failure-fallback.html passing after the fix for bug 1465983.

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 8982699 [details] [diff] [review]
patch

Review of attachment 8982699 [details] [diff] [review]:
-----------------------------------------------------------------

I assume there's not a good way to add a WPT test for this.  Can you add a sub-test to test_font_loading_api.html, maybe using a trick like the "TEST LAST" sub-test does to have a network request that never finishes?

Comment 5

[Cameron McCormack (:heycam)]

(In reply to Cameron McCormack (:heycam) from comment #4)
> I assume there's not a good way to add a WPT test for this.

Obviously I'm wrong about this since you mention the WPT test that is failing above. :-)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a2017692aa6
part 1 - Make sure we reject FontFace.loaded if font loading times out. r=heycam
https://hg.mozilla.org/integration/mozilla-inbound/rev/963e5c161210
part 2 - Mark font-display-failure-fallback.html as now passing. rs=heycam

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/3a2017692aa6
https://hg.mozilla.org/mozilla-central/rev/963e5c161210