1466298 - Get rid of nsIDOMGeoGeolocation

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

It's not needed.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Switch the geolocation service to using a singleton constructor

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Stop using do_GetService to get the non-window geolocation in C++ code

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Remove nsIDOMGeoGeolocation

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Switch the geolocation service to using a singleton constructor

Comment 5

[Andrew McCreight [:mccr8]]

Comment on attachment 8982768 [details] [diff] [review]
part 3.  Remove nsIDOMGeoGeolocation

Review of attachment 8982768 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/geolocation/nsGeolocation.cpp
@@ -1181,5 @@
>                                  ErrorResult& aRv)
>  {
>    nsresult rv = GetCurrentPosition(GeoPositionCallback(&aCallback),
>                                     GeoPositionErrorCallback(aErrorCallback),
> -                                   std::move(CreatePositionOptionsCopy(aOptions)),

I guess the moves are redundant?

Comment 6

[Boris Zbarsky [:bzbarsky]]

> I guess the moves are redundant?

Yeah.  CreatePositionOptionsCopy returns an object by value; the moves are actually triggering the pessimizing-move warning...

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/837c9a6efe99
part 1.  Switch the geolocation service to using a singleton constructor.  r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b156f1b15ae
part 2.  Stop using do_GetService to get the non-window geolocation in C++ code.  r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/2fc5f7be292e
part 3.  Remove nsIDOMGeoGeolocation.  r=mccr8

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/837c9a6efe99
https://hg.mozilla.org/mozilla-central/rev/1b156f1b15ae
https://hg.mozilla.org/mozilla-central/rev/2fc5f7be292e