Closed
Bug 1466299
Opened 6 years ago
Closed 6 years ago
-Wself-move: remove warnings in xpcom
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
WONTFIX
Tracking | Status | |
---|---|---|
firefox62 | --- | affected |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Caused by bug 1465585. Three options (at least) * Remove the code, I am not sure to understand the purpose of the test * Add -Wno-self-move on the file level * Use the following just around the declarations: #if __clang__ && defined( __has_warning ) # if __has_warning( "-Wself-move" ) # define SUPPRESSING # pragma GCC diagnostic push # pragma GCC diagnostic ignored "-Wself-move" # endif #endif
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8982770 [details] Bug 1466299 - Remove some self-move declarations to remove some warnings https://reviewboard.mozilla.org/r/248660/#review254892 These tests are testing that self-moves working correctly, so we should not remove them. Please use `-Wno-self-move` or the `#pragma` approach; I think the former is a little better, but will approve either one. Thanks.
Attachment #8982770 -
Flags: review?(nfroyd) → review-
Assignee | ||
Comment 3•6 years ago
|
||
This has been done in bug 1465060 by miko
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•