1466299 - -Wself-move: remove warnings in xpcom

Status: RESOLVED WONTFIX

(Core :: XPCOM, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Caused by bug 1465585.

Three options (at least)
* Remove the code, I am not sure to understand the purpose of the test 
* Add -Wno-self-move on the file level
* Use the following just around the declarations:
#if __clang__ && defined( __has_warning )
#   if __has_warning( "-Wself-move" )
#       define SUPPRESSING
#       pragma GCC diagnostic push
#       pragma GCC diagnostic ignored "-Wself-move"
#   endif
#endif

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1466299 - Remove some self-move declarations to remove some warnings

Review commit: https://reviewboard.mozilla.org/r/248660/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248660/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8982770 [details]
Bug 1466299 - Remove some self-move declarations to remove some warnings

https://reviewboard.mozilla.org/r/248660/#review254892

These tests are testing that self-moves working correctly, so we should not remove them.  Please use `-Wno-self-move` or the `#pragma` approach; I think the former is a little better, but will approve either one.  Thanks.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

This has been done in bug 1465060 by miko