Open Bug 1466329 Opened 6 years ago Updated 2 years ago

"Duplicate root ID in changeset" error due to misparented unfiled root

Categories

(Firefox :: Sync, defect, P3)

Product:
Firefox
Component:
Sync
Version:
60 Branch
Platform:
x86_64
Linux
Type:
defect

Tracking

()

People

(Reporter: firefox, Unassigned)

References

Details

Attachments

(5 files)

weave.zip - contain all log files including error messages
35.28 KB, application/zip
Details
exportt_ff60
1.02 MB, text/plain
Details
log file of last sync after verify integrity
21.76 KB, text/plain
Details
last log file of sync after all bookmarks were synced
19.48 KB, text/plain
Details
Screen Shot 2018-06-05 at 10.51.39.png
109.07 KB, image/png
Details 
Having installed 
FF Version 60.0.1, first offered to Release channel users on May 16, 2018
on two desktops:
a) Linux
b) Windows 7 (new)

While testing sync , I renamed the device name, so in the database there are 3 clients now, while showing devices will show only the two.

But from scratch on FF will not sync bookmark from a) to b)
attached some log files 

thx for support
Rainer
Summary: FF can't sync bookmasks → FF 60 can't sync bookmarks
some important lines from a log file:
---
   .
   .
   .
1527945066027	Sync.Engine.Bookmarks.BookmarkSyncUtils	DEBUG	pushChanges: Processed change records: {"weak":0,"skipped":0,"updated":0}
1527945066028	Sync.Status	DEBUG	Status for engine bookmarks: error.engine.reason.unknown_fail
1527945066028	Sync.Status	DEBUG	Status.service: success.status_ok => error.sync.failed_partial
1527945066028	Sync.ErrorHandler	DEBUG	bookmarks failed: Error: Duplicate item or tombstone unfiled in changeset (resource://gre/modules/PlacesSyncUtils.jsm:1952:13) JS Stack trace: addRowToChangeRecords@PlacesSyncUtils.jsm:1952:13
pullSyncChanges@PlacesSyncUtils.jsm:2014:5
   .
   .
   .
1527945066053	Sync.Doctor	INFO	Skipping check of prefs - disabled via preferences
1527945066053	Sync.Doctor	INFO	Skipping check of passwords - disabled via preferences
1527945066053	Sync.Doctor	INFO	Skipping check of tabs - disabled via preferences
1527945066053	Sync.Doctor	INFO	Skipping check of bookmarks - disabled via preferences
1527945066053	Sync.Doctor	INFO	Skipping check of addons - disabled via preferences
1527945066053	Sync.Doctor	INFO	Skipping check of forms - disabled via preferences
1527945066053	Sync.Doctor	INFO	Skipping check of history - disabled via preferences
1527945066053	Sync.Doctor	INFO	Skipping check of extension-storage - disabled via preferences
1527945066053	Sync.Doctor	INFO	Skipping validation: no engines qualify
1527945066054	Sync.Synchronizer	INFO	Sync completed at 2018-06-02 15:11:06 after 0.98 secs.
1527945066055	Sync.Declined	DEBUG	Handling remote declined: []
1527945066055	Sync.Declined	DEBUG	Handling local declined: []
1527945066055	Sync.Declined	DEBUG	Declined changed? false
1527945066055	Sync.Service	INFO	No change to declined engines. Not reuploading meta/global.
1527945066055	Sync.ErrorHandler	ERROR	Some engines did not sync correctly.
   .
   .
   .
---
I started sync manually on both desktops a) and b)
But log files are only present on a)
on b) there is no log file
Interesting! We've seen errors like this before, but haven't been able to reproduce them. If you wouldn't mind helping us out:

* Please install the About Sync add-on from https://addons.mozilla.org/en-US/firefox/addon/about-sync/ on the device where you're seeing the error logs.
* Open Tools > About Sync.
* Under "bookmarks", click the "SQL" tab. (It might take a few seconds to load).
* Run this query, and paste the results here:

select b.guid, p.guid as parent, b.position from moz_bookmarks b left join moz_bookmarks p on p.id = b.parent where substr(b.guid, 1, 7) = 'unfiled' union all select guid, "<deleted>" as parent, -1 as position from moz_bookmarks_deleted;

* If you can, please also attach an anonymized export of your bookmarks tree. (Please scroll to the bottom, check "Anonymize data", and click "Export to file" to generate the export).

Thanks!
Flags: needinfo?(firefox)
the result of the query is:

(index) ▼	(record)	guid	parent	position
0	{"guid":"unfiled_____","parent":"menu________","position":16}	"unfiled_____"	"menu________"	16

regards
Rainer
Flags: needinfo?(firefox)
Attached file exportt_ff60 — 
export all objects for kit
Hi kit,
file generated and attached.
HTH

regards
Rainer
Thanks so much, Rainer!

> {"guid":"unfiled_____","parent":"menu________","position":16}

This is definitely a problem...somehow, your "Other Bookmarks" root has ended up in the "Bookmarks Menu" root, which is likely to cause all sorts of problems. We can add a maintenance task to fix these up, but I'm curious how this happened. Any ideas, Mak? This is using the old bookmarks engine (the mirror is 61+), and shouldn't be possible with the API: https://searchfox.org/mozilla-central/rev/292d295d6b084b43b70de26a42e68513bb7b36a3/toolkit/components/places/Bookmarks.jsm#657-659
Flags: needinfo?(mak77)
(In reply to Kit Cambridge (they/them) [:kitcambridge] from comment #7)
> We can add a maintenance task to fix these up...

Actually, Standard8 already added this in bug 1453994, and bug 1410270 automatically runs Places maintenance on bookmark sync errors. Looks like it's the same issue, too; unfiled got recreated under menu.

Rainer, could you please open about:support, scroll down to "Places Database", click "Verify Integrity", paste the result here, and try to sync again? Thanks! Also, do you remember if you installed any bookmarks add-ons, or imported or restored your bookmarks recently?
Flags: needinfo?(mak77) → needinfo?(firefox)
(In reply to Kit Cambridge (they/them) [:kitcambridge] from comment #8)
> Rainer, could you please open about:support, scroll down to "Places
> Database", click "Verify Integrity", paste the result here, and try to sync
> again?

(You'll need to do this on Beta). Or, if you'd like to stay on Release 60, you can run this in the "SQL" tab in About Sync:

UPDATE moz_bookmarks SET parent = (SELECT id FROM moz_bookmarks WHERE guid = 'root________') WHERE guid = 'unfiled_____';

...And then run "Verify Integrity" to fix indices.
verify integrity output is:
---
> Task: checkIntegrity
+ The database is sane
> Task: invalidateCaches
+ The caches have been invalidated
> Task: checkCoherence
+ The database is coherent
> Task: expire
+ Database cleaned up
> Task: vacuum
+ Initial database size is 5120KiB
+ The database has been vacuumed
+ Final database size is 5120KiB
> Task: stats
+ Places.sqlite size is 5120KiB
+ Favicons.sqlite size is 736KiB
+ pragma_user_version is 43
+ pragma_page_size is 32768
+ pragma_cache_size is -2048
+ pragma_journal_mode is wal
+ pragma_synchronous is 1
+ History can store a maximum of 43356 unique pages
+ Table moz_places has 1398 records
+ Table moz_historyvisits has 402 records
+ Table moz_inputhistory has 0 records
+ Table moz_hosts has 379 records
+ Table moz_bookmarks has 1883 records
+ Table moz_keywords has 0 records
+ Table sqlite_sequence has 1 records
+ Table moz_anno_attributes has 10 records
+ Table moz_annos has 3 records
+ Table moz_items_annos has 398 records
+ Table sqlite_stat1 has 19 records
+ Table moz_bookmarks_deleted has 0 records
+ Index sqlite_autoindex_moz_inputhistory_1
+ Index sqlite_autoindex_moz_hosts_1
+ Index sqlite_autoindex_moz_keywords_1
+ Index sqlite_autoindex_moz_anno_attributes_1
+ Index sqlite_autoindex_moz_bookmarks_deleted_1
+ Index moz_places_url_hashindex
+ Index moz_places_hostindex
+ Index moz_places_visitcount
+ Index moz_places_frecencyindex
+ Index moz_places_lastvisitdateindex
+ Index moz_places_guid_uniqueindex
+ Index moz_historyvisits_placedateindex
+ Index moz_historyvisits_fromindex
+ Index moz_historyvisits_dateindex
+ Index moz_bookmarks_itemindex
+ Index moz_bookmarks_parentindex
+ Index moz_bookmarks_itemlastmodifiedindex
+ Index moz_bookmarks_guid_uniqueindex
+ Index moz_keywords_placepostdata_uniqueindex
+ Index moz_annos_placeattributeindex
+ Index moz_items_annos_itemattributeindex
+ Index moz_bookmarks_dateaddedindex
> Task: _refreshUI
---
Flags: needinfo?(firefox)
the log file (attached) is longer, but has the same errors as pasted above:
e.g.
1528146590218	Sync.Status	DEBUG	Status for engine bookmarks: error.engine.reason.unknown_fail
1528146590218	Sync.Status	DEBUG	Status.service: success.status_ok => error.sync.failed_partial
1528146590218	Sync.ErrorHandler	DEBUG	bookmarks failed: Error: Duplicate item or tombstone unfiled in changeset (resource://gre/modules/PlacesSyncUtils.jsm:1952:13) JS Stack trace: addRowToChangeRecords@PlacesSyncUtils.jsm:1952:13
pullSyncChanges@PlacesSyncUtils.jsm:2014:5
1528146590218	Sync.SyncScheduler	TRACE	Handling weave:engine:sync:error
1528146590218	Sync.Telemetry	TRACE	observed weave:engine:sync:error bookmarks
execute "UPDATE moz_bookmarks SET parent = (SELECT id FROM moz_bookmarks WHERE guid = 'root________') WHERE guid = 'unfiled_____';"

=> 0 row(s) returned.
Application Basics
------------------

Name: Firefox
Version: 60.0.1
Build ID: 20180517114003
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
OS: Linux 4.15.0-22-generic
Multiprocess Windows: 4/4 (Enabled by default)
Web Content Processes: 5/4
Stylo: content = true (enabled by default), chrome = true (enabled by default)
Enterprise Policies: Inactive
Google Key: Found
Mozilla Location Service Key: Missing
Safe Mode: false

Crash Reports for the Last 3 Days
---------------------------------

Report ID: bp-bdd42a5e-7110-4c53-bce9-ae9221180602
Submitted: 2 days ago

All Crash Reports

Firefox Features
----------------

Name: Activity Stream
Version: 2018.04.20.1103-b3b95672
ID: activity-stream@mozilla.org

Name: Application Update Service Helper
Version: 2.0
ID: aushelper@mozilla.org

Name: Firefox Screenshots
Version: 30.1.0
ID: screenshots@mozilla.org

Name: Follow-on Search Telemetry
Version: 0.9.6
ID: followonsearch@mozilla.com

Name: Form Autofill
Version: 1.0
ID: formautofill@mozilla.org

Name: Photon onboarding
Version: 1.0
ID: onboarding@mozilla.org

Name: Pocket
Version: 1.0.5
ID: firefox@getpocket.com

Name: Web Compat
Version: 1.1
ID: webcompat@mozilla.org

Extensions
----------

Name: About Sync extension for Firefox
Version: 0.0.23
Enabled: true
ID: aboutsync@mhammond.github.com

Name: Copy PlainText
Version: 1.8
Enabled: true
ID: copyplaintext@eros.man

Name: LastPass: Free Password Manager
Version: 4.10.1.0
Enabled: true
ID: support@lastpass.com

Name: uBlock Origin
Version: 1.16.8
Enabled: true
ID: uBlock0@raymondhill.net

Name: YouTube mp3 Downloader
Version: 1.0.2
Enabled: true
ID: {defe5404-0b6f-4cce-a119-ee0df858e5f9}

Security Software
----------------- Type:

Type:

Type:

Graphics
--------

Features
Compositing: Basic
Asynchronous Pan/Zoom: wheel input enabled; scrollbar drag enabled; keyboard enabled; autoscroll enabled
WebGL 1 Driver WSI Info: GLX 1.4 GLX_VENDOR(client): Mesa Project and SGI GLX_VENDOR(server): SGI Extensions: GLX_ARB_create_context GLX_ARB_create_context_profile GLX_ARB_create_context_robustness GLX_ARB_fbconfig_float GLX_ARB_framebuffer_sRGB GLX_ARB_get_proc_address GLX_ARB_multisample GLX_EXT_buffer_age GLX_EXT_create_context_es2_profile GLX_EXT_create_context_es_profile GLX_EXT_fbconfig_packed_float GLX_EXT_framebuffer_sRGB GLX_EXT_import_context GLX_EXT_texture_from_pixmap GLX_EXT_visual_info GLX_EXT_visual_rating GLX_INTEL_swap_event GLX_MESA_copy_sub_buffer GLX_MESA_multithread_makecurrent GLX_MESA_query_renderer GLX_MESA_swap_control GLX_OML_swap_method GLX_OML_sync_control GLX_SGIS_multisample GLX_SGIX_fbconfig GLX_SGIX_pbuffer GLX_SGIX_visual_select_group GLX_SGI_make_current_read GLX_SGI_swap_control GLX_SGI_video_sync
WebGL 1 Driver Renderer: Intel Open Source Technology Center -- Mesa DRI Intel(R) Sandybridge Mobile
WebGL 1 Driver Version: 3.0 Mesa 18.0.0-rc5
WebGL 1 Driver Extensions: GL_3DFX_texture_compression_FXT1 GL_AMD_draw_buffers_blend GL_AMD_seamless_cubemap_per_texture GL_AMD_shader_trinary_minmax GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_APPLE_object_purgeable GL_APPLE_packed_pixels GL_ARB_ES2_compatibility GL_ARB_ES3_compatibility GL_ARB_arrays_of_arrays GL_ARB_blend_func_extended GL_ARB_buffer_storage GL_ARB_clear_buffer_object GL_ARB_clear_texture GL_ARB_clip_control GL_ARB_color_buffer_float GL_ARB_compressed_texture_pixel_storage GL_ARB_conditional_render_inverted GL_ARB_copy_buffer GL_ARB_copy_image GL_ARB_cull_distance GL_ARB_debug_output GL_ARB_depth_buffer_float GL_ARB_depth_clamp GL_ARB_depth_texture GL_ARB_draw_buffers GL_ARB_draw_buffers_blend GL_ARB_draw_elements_base_vertex GL_ARB_draw_instanced GL_ARB_explicit_attrib_location GL_ARB_explicit_uniform_location GL_ARB_fragment_coord_conventions GL_ARB_fragment_program GL_ARB_fragment_program_shadow GL_ARB_fragment_shader GL_ARB_framebuffer_object GL_ARB_framebuffer_sRGB GL_ARB_get_program_binary GL_ARB_get_texture_sub_image GL_ARB_half_float_pixel GL_ARB_half_float_vertex GL_ARB_instanced_arrays GL_ARB_internalformat_query GL_ARB_internalformat_query2 GL_ARB_invalidate_subdata GL_ARB_map_buffer_alignment GL_ARB_map_buffer_range GL_ARB_multi_bind GL_ARB_multisample GL_ARB_multitexture GL_ARB_occlusion_query GL_ARB_occlusion_query2 GL_ARB_pipeline_statistics_query GL_ARB_pixel_buffer_object GL_ARB_point_parameters GL_ARB_point_sprite GL_ARB_polygon_offset_clamp GL_ARB_program_interface_query GL_ARB_provoking_vertex GL_ARB_robustness GL_ARB_sample_shading GL_ARB_sampler_objects GL_ARB_seamless_cube_map GL_ARB_seamless_cubemap_per_texture GL_ARB_separate_shader_objects GL_ARB_shader_bit_encoding GL_ARB_shader_draw_parameters GL_ARB_shader_group_vote GL_ARB_shader_objects GL_ARB_shader_texture_lod GL_ARB_shading_language_100 GL_ARB_shading_language_420pack GL_ARB_shading_language_packing GL_ARB_shadow GL_ARB_sync GL_ARB_texture_barrier GL_ARB_texture_border_clamp GL_ARB_texture_compression GL_ARB_texture_compression_rgtc GL_ARB_texture_cube_map GL_ARB_texture_cube_map_array GL_ARB_texture_env_add GL_ARB_texture_env_combine GL_ARB_texture_env_crossbar GL_ARB_texture_env_dot3 GL_ARB_texture_filter_anisotropic GL_ARB_texture_float GL_ARB_texture_gather GL_ARB_texture_mirror_clamp_to_edge GL_ARB_texture_mirrored_repeat GL_ARB_texture_multisample GL_ARB_texture_non_power_of_two GL_ARB_texture_query_levels GL_ARB_texture_query_lod GL_ARB_texture_rectangle GL_ARB_texture_rg GL_ARB_texture_rgb10_a2ui GL_ARB_texture_storage GL_ARB_texture_storage_multisample GL_ARB_texture_swizzle GL_ARB_timer_query GL_ARB_transform_feedback2 GL_ARB_transform_feedback_overflow_query GL_ARB_transpose_matrix GL_ARB_uniform_buffer_object GL_ARB_vertex_array_bgra GL_ARB_vertex_array_object GL_ARB_vertex_attrib_binding GL_ARB_vertex_buffer_object GL_ARB_vertex_program GL_ARB_vertex_shader GL_ARB_vertex_type_10f_11f_11f_rev GL_ARB_vertex_type_2_10_10_10_rev GL_ARB_window_pos GL_ATI_blend_equation_separate GL_ATI_draw_buffers GL_ATI_separate_stencil GL_ATI_texture_env_combine3 GL_ATI_texture_float GL_EXT_abgr GL_EXT_bgra GL_EXT_blend_color GL_EXT_blend_equation_separate GL_EXT_blend_func_separate GL_EXT_blend_minmax GL_EXT_blend_subtract GL_EXT_compiled_vertex_array GL_EXT_copy_texture GL_EXT_draw_buffers2 GL_EXT_draw_instanced GL_EXT_draw_range_elements GL_EXT_fog_coord GL_EXT_framebuffer_blit GL_EXT_framebuffer_multisample GL_EXT_framebuffer_multisample_blit_scaled GL_EXT_framebuffer_object GL_EXT_framebuffer_sRGB GL_EXT_gpu_program_parameters GL_EXT_multi_draw_arrays GL_EXT_packed_depth_stencil GL_EXT_packed_float GL_EXT_packed_pixels GL_EXT_pixel_buffer_object GL_EXT_point_parameters GL_EXT_polygon_offset GL_EXT_polygon_offset_clamp GL_EXT_provoking_vertex GL_EXT_rescale_normal GL_EXT_secondary_color GL_EXT_separate_specular_color GL_EXT_shader_integer_mix GL_EXT_shadow_funcs GL_EXT_stencil_two_side GL_EXT_stencil_wrap GL_EXT_subtexture GL_EXT_texture GL_EXT_texture3D GL_EXT_texture_array GL_EXT_texture_compression_dxt1 GL_EXT_texture_compression_rgtc GL_EXT_texture_compression_s3tc GL_EXT_texture_cube_map GL_EXT_texture_edge_clamp GL_EXT_texture_env_add GL_EXT_texture_env_combine GL_EXT_texture_env_dot3 GL_EXT_texture_filter_anisotropic GL_EXT_texture_integer GL_EXT_texture_lod_bias GL_EXT_texture_object GL_EXT_texture_rectangle GL_EXT_texture_sRGB GL_EXT_texture_sRGB_decode GL_EXT_texture_shared_exponent GL_EXT_texture_snorm GL_EXT_texture_swizzle GL_EXT_timer_query GL_EXT_transform_feedback GL_EXT_vertex_array GL_EXT_vertex_array_bgra GL_IBM_multimode_draw_arrays GL_IBM_rasterpos_clip GL_IBM_texture_mirrored_repeat GL_INGR_blend_func_separate GL_INTEL_performance_query GL_KHR_blend_equation_advanced GL_KHR_context_flush_control GL_KHR_debug GL_KHR_no_error GL_KHR_robustness GL_MESA_pack_invert GL_MESA_shader_integer_functions GL_MESA_texture_signed_rgba GL_MESA_window_pos GL_NV_blend_square GL_NV_conditional_render GL_NV_depth_clamp GL_NV_light_max_exponent GL_NV_packed_depth_stencil GL_NV_primitive_restart GL_NV_texgen_reflection GL_NV_texture_barrier GL_NV_texture_env_combine4 GL_NV_texture_rectangle GL_OES_EGL_image GL_OES_read_format GL_S3_s3tc GL_SGIS_generate_mipmap GL_SGIS_texture_border_clamp GL_SGIS_texture_edge_clamp GL_SGIS_texture_lod GL_SUN_multi_draw_arrays
WebGL 1 Extensions: ANGLE_instanced_arrays EXT_blend_minmax EXT_color_buffer_half_float EXT_frag_depth EXT_sRGB EXT_shader_texture_lod EXT_texture_filter_anisotropic EXT_disjoint_timer_query OES_element_index_uint OES_standard_derivatives OES_texture_float OES_texture_float_linear OES_texture_half_float OES_texture_half_float_linear OES_vertex_array_object WEBGL_color_buffer_float WEBGL_compressed_texture_etc WEBGL_compressed_texture_s3tc WEBGL_compressed_texture_s3tc_srgb WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_depth_texture WEBGL_draw_buffers WEBGL_lose_context
WebGL 2 Driver WSI Info: GLX 1.4 GLX_VENDOR(client): Mesa Project and SGI GLX_VENDOR(server): SGI Extensions: GLX_ARB_create_context GLX_ARB_create_context_profile GLX_ARB_create_context_robustness GLX_ARB_fbconfig_float GLX_ARB_framebuffer_sRGB GLX_ARB_get_proc_address GLX_ARB_multisample GLX_EXT_buffer_age GLX_EXT_create_context_es2_profile GLX_EXT_create_context_es_profile GLX_EXT_fbconfig_packed_float GLX_EXT_framebuffer_sRGB GLX_EXT_import_context GLX_EXT_texture_from_pixmap GLX_EXT_visual_info GLX_EXT_visual_rating GLX_INTEL_swap_event GLX_MESA_copy_sub_buffer GLX_MESA_multithread_makecurrent GLX_MESA_query_renderer GLX_MESA_swap_control GLX_OML_swap_method GLX_OML_sync_control GLX_SGIS_multisample GLX_SGIX_fbconfig GLX_SGIX_pbuffer GLX_SGIX_visual_select_group GLX_SGI_make_current_read GLX_SGI_swap_control GLX_SGI_video_sync
WebGL 2 Driver Renderer: Intel Open Source Technology Center -- Mesa DRI Intel(R) Sandybridge Mobile
WebGL 2 Driver Version: 3.3 (Core Profile) Mesa 18.0.0-rc5
WebGL 2 Driver Extensions: GL_3DFX_texture_compression_FXT1 GL_AMD_draw_buffers_blend GL_AMD_seamless_cubemap_per_texture GL_AMD_shader_trinary_minmax GL_AMD_vertex_shader_layer GL_AMD_vertex_shader_viewport_index GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_APPLE_object_purgeable GL_ARB_ES2_compatibility GL_ARB_ES3_compatibility GL_ARB_arrays_of_arrays GL_ARB_base_instance GL_ARB_blend_func_extended GL_ARB_buffer_storage GL_ARB_clear_buffer_object GL_ARB_clear_texture GL_ARB_clip_control GL_ARB_compressed_texture_pixel_storage GL_ARB_conditional_render_inverted GL_ARB_copy_buffer GL_ARB_copy_image GL_ARB_cull_distance GL_ARB_debug_output GL_ARB_depth_buffer_float GL_ARB_depth_clamp GL_ARB_direct_state_access GL_ARB_draw_buffers GL_ARB_draw_buffers_blend GL_ARB_draw_elements_base_vertex GL_ARB_draw_instanced GL_ARB_enhanced_layouts GL_ARB_explicit_attrib_location GL_ARB_explicit_uniform_location GL_ARB_fragment_coord_conventions GL_ARB_fragment_layer_viewport GL_ARB_fragment_shader GL_ARB_framebuffer_object GL_ARB_framebuffer_sRGB GL_ARB_get_program_binary GL_ARB_get_texture_sub_image GL_ARB_half_float_pixel GL_ARB_half_float_vertex GL_ARB_instanced_arrays GL_ARB_internalformat_query GL_ARB_internalformat_query2 GL_ARB_invalidate_subdata GL_ARB_map_buffer_alignment GL_ARB_map_buffer_range GL_ARB_multi_bind GL_ARB_occlusion_query2 GL_ARB_pipeline_statistics_query GL_ARB_pixel_buffer_object GL_ARB_point_sprite GL_ARB_polygon_offset_clamp GL_ARB_program_interface_query GL_ARB_provoking_vertex GL_ARB_robustness GL_ARB_sample_shading GL_ARB_sampler_objects GL_ARB_seamless_cube_map GL_ARB_seamless_cubemap_per_texture GL_ARB_separate_shader_objects GL_ARB_shader_bit_encoding GL_ARB_shader_draw_parameters GL_ARB_shader_group_vote GL_ARB_shader_objects GL_ARB_shader_subroutine GL_ARB_shader_texture_lod GL_ARB_shader_viewport_layer_array GL_ARB_shading_language_420pack GL_ARB_shading_language_packing GL_ARB_sync GL_ARB_texture_barrier GL_ARB_texture_buffer_object GL_ARB_texture_buffer_object_rgb32 GL_ARB_texture_buffer_range GL_ARB_texture_compression_rgtc GL_ARB_texture_cube_map_array GL_ARB_texture_filter_anisotropic GL_ARB_texture_float GL_ARB_texture_gather GL_ARB_texture_mirror_clamp_to_edge GL_ARB_texture_multisample GL_ARB_texture_non_power_of_two GL_ARB_texture_query_levels GL_ARB_texture_query_lod GL_ARB_texture_rectangle GL_ARB_texture_rg GL_ARB_texture_rgb10_a2ui GL_ARB_texture_storage GL_ARB_texture_storage_multisample GL_ARB_texture_swizzle GL_ARB_timer_query GL_ARB_transform_feedback2 GL_ARB_transform_feedback_overflow_query GL_ARB_uniform_buffer_object GL_ARB_vertex_array_bgra GL_ARB_vertex_array_object GL_ARB_vertex_attrib_binding GL_ARB_vertex_shader GL_ARB_vertex_type_10f_11f_11f_rev GL_ARB_vertex_type_2_10_10_10_rev GL_ARB_viewport_array GL_ATI_blend_equation_separate GL_ATI_texture_float GL_EXT_abgr GL_EXT_blend_equation_separate GL_EXT_draw_buffers2 GL_EXT_draw_instanced GL_EXT_framebuffer_blit GL_EXT_framebuffer_multisample GL_EXT_framebuffer_multisample_blit_scaled GL_EXT_framebuffer_sRGB GL_EXT_packed_depth_stencil GL_EXT_packed_float GL_EXT_pixel_buffer_object GL_EXT_polygon_offset_clamp GL_EXT_provoking_vertex GL_EXT_shader_integer_mix GL_EXT_texture_array GL_EXT_texture_compression_dxt1 GL_EXT_texture_compression_rgtc GL_EXT_texture_compression_s3tc GL_EXT_texture_filter_anisotropic GL_EXT_texture_integer GL_EXT_texture_sRGB GL_EXT_texture_sRGB_decode GL_EXT_texture_shared_exponent GL_EXT_texture_snorm GL_EXT_texture_swizzle GL_EXT_timer_query GL_EXT_transform_feedback GL_EXT_vertex_array_bgra GL_IBM_multimode_draw_arrays GL_INTEL_performance_query GL_KHR_blend_equation_advanced GL_KHR_context_flush_control GL_KHR_debug GL_KHR_no_error GL_KHR_robustness GL_MESA_pack_invert GL_MESA_shader_integer_functions GL_MESA_texture_signed_rgba GL_NV_conditional_render GL_NV_depth_clamp GL_NV_packed_depth_stencil GL_NV_texture_barrier GL_OES_EGL_image GL_S3_s3tc
WebGL 2 Extensions: EXT_color_buffer_float EXT_texture_filter_anisotropic EXT_disjoint_timer_query OES_texture_float_linear WEBGL_compressed_texture_etc WEBGL_compressed_texture_s3tc WEBGL_compressed_texture_s3tc_srgb WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_lose_context
GPU #1
Active: Yes
Description: Intel Open Source Technology Center -- Mesa DRI Intel(R) Sandybridge Mobile
Vendor ID: Intel Open Source Technology Center
Device ID: Mesa DRI Intel(R) Sandybridge Mobile
Driver Version: 3.0 Mesa 18.0.0-rc5

Diagnostics
AzureCanvasAccelerated: 0
AzureCanvasBackend: skia
AzureContentBackend: skia
AzureFallbackCanvasBackend: none
CairoUseXRender: 0
Decision Log
HW_COMPOSITING:
blocked by default: Acceleration blocked by platform
OPENGL_COMPOSITING:
unavailable by default: Hardware compositing is disabled
WEBRENDER:
opt-in by default: WebRender is an opt-in feature
unavailable by runtime: Build doesn't include WebRender
OMTP:
disabled by default: Disabled by default




Media
-----

Audio Backend: remote
Max Channels: 2
Preferred Channel Layout: stereo
Preferred Sample Rate: 44100
Output Devices
Name: Group
Built-in Audio Analog Stereo: /devices/pci0000:00/0000:00:1b.0/sound/card0
Input Devices
Name: Group
Monitor of Built-in Audio Analog Stereo: /devices/pci0000:00/0000:00:1b.0/sound/card0
Built-in Audio Analog Stereo: /devices/pci0000:00/0000:00:1b.0/sound/card0

Important Modified Preferences
------------------------------

accessibility.typeaheadfind: true
accessibility.typeaheadfind.flashBar: 0
browser.cache.disk.capacity: 358400
browser.cache.disk.filesystem_reported: 1
browser.cache.disk.smart_size.first_run: false
browser.download.useDownloadDir: false
browser.places.smartBookmarksVersion: 8
browser.startup.homepage: https://www.google.de/?gws_rd=ssl
browser.startup.homepage_override.buildID: 20180517114003
browser.startup.homepage_override.mstone: 60.0.1
browser.urlbar.matchBuckets: general:5,suggestion:Infinity
browser.urlbar.placeholderName: Google
browser.urlbar.suggest.bookmark: false
browser.urlbar.suggest.history: false
browser.urlbar.timesBeforeHidingSuggestionsHint: 0
dom.push.userAgentID: 5f11e7c19d0c4305a497a2fe207fc6ac
extensions.lastAppVersion: 60.0.1
media.gmp-gmpopenh264.abi: x86_64-gcc3
media.gmp-gmpopenh264.lastUpdate: 1527943614
media.gmp-gmpopenh264.version: 1.7.1
media.gmp-manager.buildID: 20180517114003
media.gmp-manager.lastCheck: 1527943884
media.gmp.storage.version.observed: 1
network.cookie.prefsMigrated: true
network.dns.disablePrefetch: true
network.http.speculative-parallel-limit: 0
network.predictor.cleaned-up: true
network.predictor.enabled: false
network.prefetch-next: false
places.database.lastMaintenance: 1527954544
places.history.expiration.transient_current_max_pages: 43356
plugin.disable_full_page_plugin_for_types: application/pdf
print.print_bgcolor: true
print.print_bgimages: false
print.print_duplex: 0
print.print_evenpages: true
print.print_margin_bottom: 0.5
print.print_margin_left: 0.5
print.print_margin_right: 0.5
print.print_margin_top: 0.5
print.print_oddpages: true
print.print_orientation: 1
print.print_page_delay: 50
print.print_paper_data: 0
print.print_paper_height: 11,69
print.print_paper_name: iso_a4
print.print_paper_size_unit: 0
print.print_paper_width: 8,27
print.print_scaling: 1,00
print.print_shrink_to_fit: true
print.print_to_file: false
print.print_unwriteable_margin_bottom: 56
print.print_unwriteable_margin_left: 25
print.print_unwriteable_margin_right: 25
print.print_unwriteable_margin_top: 25
privacy.clearOnShutdown.offlineApps: true
privacy.history.custom: true
privacy.sanitize.pending: [{"id":"shutdown","itemsToClear":["cache","cookies","offlineApps","history","formdata","downloads","sessions"],"options"
privacy.sanitize.sanitizeOnShutdown: true
privacy.trackingprotection.enabled: true
security.default_personal_cert: Select Automatically
security.sandbox.content.tempDirSuffix: 07f6a33f-dbe8-4715-8b95-417d7af6503d
services.sync.declinedEngines: tabs,forms,history
services.sync.engine.history: false
services.sync.engine.prefs.modified: false
services.sync.engine.tabs: false
services.sync.lastPing: 1528121157
services.sync.lastSync: Mon Jun 04 2018 23:01:20 GMT+0200 (CEST)
storage.vacuum.last.index: 1
storage.vacuum.last.places.sqlite: 1527954544

Important Locked Preferences
----------------------------

Places Database
---------------

JavaScript
----------

Incremental GC: true

Accessibility
-------------

Activated: false
Prevent Accessibility: 0

Library Versions
----------------

NSPR
Expected minimum version: 4.19
Version in use: 4.19

NSS
Expected minimum version: 3.36.1
Version in use: 3.36.1

NSSSMIME
Expected minimum version: 3.36.1
Version in use: 3.36.1

NSSSSL
Expected minimum version: 3.36.1
Version in use: 3.36.1

NSSUTIL
Expected minimum version: 3.36.1
Version in use: 3.36.1

Experimental Features
---------------------

Sandbox
-------

Seccomp-BPF (System Call Filtering): true
Seccomp Thread Synchronization: true
User Namespaces: true
Content Process Sandboxing: true
Media Plugin Sandboxing: true
Content Process Sandbox Level: 4
Effective Content Process Sandbox Level: 4

Rejected System Calls
---------------------

Internationalization & Localization
-----------------------------------

Application Settings
Requested Locales: ["en-US"]
Available Locales: ["en-GB","en-ZA","en-US"]
App Locales: ["en-US","en-GB","en-ZA"]
Regional Preferences: ["en-US","en-GB","en-ZA"]
Default Locale: "en-US"
Operating System
System Locales: ["en-US"]
Regional Preferences: ["de-DE"]
(In reply to Kit Cambridge (they/them) [:kitcambridge] from comment #7)
> This is definitely a problem...somehow, your "Other Bookmarks" root has
> ended up in the "Bookmarks Menu" root, which is likely to cause all sorts of
> problems.

So I have no idea. I can only see these possible causes:
1. We have a migration doing something stupid
2. We have a maintenance task doing something stupid
3. Some other software touches our database

I could name the other instance a coincidence, but 2 instanced of the same bug is not anymore.
I'll have a second look at all of our queries on moz_bookmarks, more eyes on that are also welcome.
so, what can I do ?

How can I export all Bookmarks
try to sync whithout any one...
and add the bookmarks step by step + sync ...

Rainer
after saving (backupand export) all bookmarks and deleting the most of them
syn works

but to my mind there are some errors 
or some lines in the log files I do not understand why:

e.g.
1528220784064	Sync.Doctor	INFO	Skipping check of prefs - disabled via preferences
1528220784064	Sync.Doctor	INFO	Skipping check of passwords - disabled via preferences
1528220784064	Sync.Doctor	INFO	Skipping check of bookmarks - disabled via preferences
1528220784064	Sync.Doctor	INFO	Skipping check of addons - disabled via preferences
1528220784064	Sync.Doctor	INFO	Skipping check of extension-storage - disabled via preferences
1528220784064	Sync.Doctor	INFO	Skipping validation: no engines qualify

Question: which preferences ???

see attachments
It's...really bizarre that comment 13 didn't fix the parent.

If you can help us debug further, and you still have the old profile, could you please:

1. Run this query in About Sync, and paste the results here:

SELECT b.id, b.guid, p.id AS parentId, p.guid AS parentGuid, b.position FROM moz_bookmarks b LEFT JOIN moz_bookmarks p ON p.id = b.parent WHERE b.guid IN ('root________', 'tags________', 'toolbar_____', 'menu________', 'unfiled_____', 'mobile______');

You should see something like this screenshot. Every `parentId` and `parentGuid` should be the `root` ID and GUID, `root` shouldn't have a parent ID or GUID.

2. Run `UPDATE moz_bookmarks SET parent = (SELECT id FROM moz_bookmarks WHERE guid = 'root________') WHERE guid = 'unfiled_____';` again.

3. Run the query from step 1 again, and see if unfiled's parent is now root. The positions might be wrong, but the parent should be fixed. If not, that's a bug.

4. Run "Verify Integrity" from about:support again.

5. Run the query from step 1 again, and check if the parents and positions are correct. If they're correct in step 3, but wrong here, it means maintenance did something wrong.

I don't have any suggestions for fixing this yet, except trying to upgrade to Beta 61, running "Verify Integrity" there, and seeing if that unblocks Sync. At this point, I'm not sure what's going on. :-/
Flags: needinfo?(firefox)
(In reply to Rainer Hartwig from comment #17)
> 1528220784064	Sync.Doctor	INFO	Skipping check of prefs - disabled via
> preferences
> 1528220784064	Sync.Doctor	INFO	Skipping check of passwords - disabled via
> preferences
> 1528220784064	Sync.Doctor	INFO	Skipping check of bookmarks - disabled via
> preferences
> 1528220784064	Sync.Doctor	INFO	Skipping check of addons - disabled via
> preferences
> 1528220784064	Sync.Doctor	INFO	Skipping check of extension-storage -
> disabled via preferences
> 1528220784064	Sync.Doctor	INFO	Skipping validation: no engines qualify

This is just log noise. It means we're not running validation for those engines after the sync, which we intentionally disable on Release and Beta because it's slow.
Hi Kit,

1: output:
0	{"id":2,"guid":"menu________","parentId":1,"parentGuid":"root________","position":0}	2	"menu________"	1	"root________"	0
1	{"id":6,"guid":"mobile______","parentId":1,"parentGuid":"root________","position":3}	6	"mobile______"	1	"root________"	3
2	{"id":1,"guid":"root________","parentId":null,"parentGuid":null,"position":0}	1	"root________"	null	null	0
3	{"id":4,"guid":"tags________","parentId":1,"parentGuid":"root________","position":2}	4	"tags________"	1	"root________"	2
4	{"id":3,"guid":"toolbar_____","parentId":1,"parentGuid":"root________","position":1}	3	"toolbar_____"	1	"root________"	1
5	{"id":1443,"guid":"unfiled_____","parentId":1,"parentGuid":"root________","position":16}	1443	"unfiled_____"	1	"root________"	16

2: update: => 0 row(s) returned.

3. did not execute as update will fix anything

4.
> Task: checkIntegrity
+ The database is sane
> Task: invalidateCaches
+ The caches have been invalidated
> Task: checkCoherence
+ The database is coherent
> Task: expire
+ Database cleaned up
> Task: vacuum
+ Initial database size is 5120KiB
+ The database has been vacuumed
+ Final database size is 5120KiB
> Task: stats
+ Places.sqlite size is 5120KiB
+ Favicons.sqlite size is 768KiB
+ pragma_user_version is 43
+ pragma_page_size is 32768
+ pragma_cache_size is -2048
+ pragma_journal_mode is wal
+ pragma_synchronous is 1
+ History can store a maximum of 43356 unique pages
+ Table moz_places has 1018 records
+ Table moz_historyvisits has 552 records
+ Table moz_inputhistory has 0 records
+ Table moz_hosts has 385 records
+ Table moz_bookmarks has 1432 records
+ Table moz_keywords has 0 records
+ Table sqlite_sequence has 1 records
+ Table moz_anno_attributes has 10 records
+ Table moz_annos has 3 records
+ Table moz_items_annos has 30 records
+ Table sqlite_stat1 has 19 records
+ Table moz_bookmarks_deleted has 0 records
+ Index sqlite_autoindex_moz_inputhistory_1
+ Index sqlite_autoindex_moz_hosts_1
+ Index sqlite_autoindex_moz_keywords_1
+ Index sqlite_autoindex_moz_anno_attributes_1
+ Index sqlite_autoindex_moz_bookmarks_deleted_1
+ Index moz_places_url_hashindex
+ Index moz_places_hostindex
+ Index moz_places_visitcount
+ Index moz_places_frecencyindex
+ Index moz_places_lastvisitdateindex
+ Index moz_places_guid_uniqueindex
+ Index moz_historyvisits_placedateindex
+ Index moz_historyvisits_fromindex
+ Index moz_historyvisits_dateindex
+ Index moz_bookmarks_itemindex
+ Index moz_bookmarks_parentindex
+ Index moz_bookmarks_itemlastmodifiedindex
+ Index moz_bookmarks_guid_uniqueindex
+ Index moz_keywords_placepostdata_uniqueindex
+ Index moz_annos_placeattributeindex
+ Index moz_items_annos_itemattributeindex
+ Index moz_bookmarks_dateaddedindex
> Task: _refreshUI

5.
0	{"id":2,"guid":"menu________","parentId":1,"parentGuid":"root________","position":0}	2	"menu________"	1	"root________"	0
1	{"id":6,"guid":"mobile______","parentId":1,"parentGuid":"root________","position":3}	6	"mobile______"	1	"root________"	3
2	{"id":1,"guid":"root________","parentId":null,"parentGuid":null,"position":0}	1	"root________"	null	null	0
3	{"id":4,"guid":"tags________","parentId":1,"parentGuid":"root________","position":2}	4	"tags________"	1	"root________"	2
4	{"id":3,"guid":"toolbar_____","parentId":1,"parentGuid":"root________","position":1}	3	"toolbar_____"	1	"root________"	1
5	{"id":1443,"guid":"unfiled_____","parentId":1,"parentGuid":"root________","position":5}	1443	"unfiled_____"	1	"root________"	5


from my pov:for a while I can work whitchout this deleted bookmarks
So, sync will work with the other bookmarks
Flags: needinfo?(firefox)
If the results are as you expected, we can temporaly close this file
until I will run into another sync bug or 61 isn't beta _and_ solve my issue -whatever it is

thanks
That all looks correct, thanks for checking! I'll leave this open, because we've seen this error come up in telemetry. Please comment if you run into the issue again.
Severity: major → normal
Status: UNCONFIRMED → NEW
Ever confirmed: true
See Also: → 1453994
Summary: FF 60 can't sync bookmarks → "Duplicate root ID in changeset" error due to misparented unfiled root
Priority: -- → P3
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: